From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69881C52D7C for ; Wed, 21 Aug 2024 17:13:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2PGuIX73MOWMnEgrAGHe44EShZU2W6VwRhKHeC2K7JU=; b=vNEbstgBSOxtgoCC/oTs9dFu0s 14e9ELi6aV3BlEmiRG69xWpE4Sz96E4hBSnE0fROdsNifwtcoNE/QXlV21Y/DkVFRl7jkVRTfqkFm Ixed2R5PDTTZWFlcNN0jf7KslNURwmOdL+kmv2kKX/2J+UY96PewZIu9M4YdzsQ0Cn7qhvEIV2n6u lL+F+UHx2PqeEC/DlL7YYh9d9tmEAqDKsQcwC7jMKf4XUPFdNT53zEsnBS1AZ8c4bY7fZv1WHzqKd ZZfKtloxlLurD1rsrEf73g91zMffO8Ecekux1jkQ2zNrmlmaejcfXzTwOPJYQKi/cUBr1BmTGKE5/ EuHWxgyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgota-00000009sxg-0Vvr; Wed, 21 Aug 2024 17:13:18 +0000 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgosq-00000009sqV-1syF for linux-arm-kernel@lists.infradead.org; Wed, 21 Aug 2024 17:12:34 +0000 Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-714287e4083so664774b3a.2 for ; Wed, 21 Aug 2024 10:12:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724260351; x=1724865151; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2PGuIX73MOWMnEgrAGHe44EShZU2W6VwRhKHeC2K7JU=; b=Cq6PuX1CXAdgcXr+e7ePGURaByEInPHV2kzg0j03KBtWRVkZGoGwpfNvuiaXSy9GJO TNGZXprPfYe3A2uVDO1FG4b27BtzHFKMKwjyU5teU/AqW9NPlXdtZony8HfWUa7/G9KD 5l3YNdR+H7wPOWQvxj2L7uceXLH9WOp7RRzTX+aztLVXd6HGDN4NlGfEN+57e88wjh7R ydoYl6+ETb+GK4/lZHUwIrbZrGuCWv7qWzyJ7ign+X65gljD6dhne/ESS1J0ELUbNAmG +0wxoKNVSv79hionMxIbbZ2kV5D4snEg8vNbBlVe2tMnIKywXjOAyK1cFxOAHY8BCcyf wVEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724260351; x=1724865151; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2PGuIX73MOWMnEgrAGHe44EShZU2W6VwRhKHeC2K7JU=; b=bVjfUta1DvyDlMSxhJMhBVTh2dmDD1LBtZbXCKWPx4ecF9ltSX9AS+XBqC5f1EpuVk XjmmKRT08naFLh7kyMcVpvW+APKNjtZ9svdZbTPgq8vWpLvYbEtxJhOM3lVGxyCKm6MN Tmk27TZgOdYcyjXyV0Kn3MEjPQakth2I9Y6iYzzL4Z3pIXaGI1VGSeAgsMzD6rLKsXls BRn35jZVIFoQuLSypGgbaiVTDbAk9s23KEWWYn3i8GvKc4L4g2DpxPO8R2XIH0+LG807 kmJjnzXzOKuqfwRrmxXlg1LGde+RxMrv3DkdtgQo+z52Owg1A4Z/FPjD2xHnF1TqNz5j 0PZA== X-Forwarded-Encrypted: i=1; AJvYcCXXVxohDUVNenBcbtzU7m/RNZwkDHkKEuWv4XPszwuV+RnvAAoBMxuA9OGr3/Z+mVrrmwRuF0/K6zWXqesb/0VC@lists.infradead.org X-Gm-Message-State: AOJu0YzMx+4HgRZZf8x7geA5IsAU01AcVzUPioZ50btmL0RcYWEYibaa NlHK/dZSGCBlZa3ZvnOaY7fXYYHbmV/iODZRI1+Tomd570qJgutM0Cyh2Nqb4QE= X-Google-Smtp-Source: AGHT+IFahu5nhyR9APNX81eGWYDvWGW2BXzcpC6njxXplKlq16tD6UzEgdsOMomgPVvunvzQIx/1lw== X-Received: by 2002:a05:6a20:c916:b0:1c3:b61c:57cb with SMTP id adf61e73a8af0-1cad818adccmr3000160637.53.1724260350919; Wed, 21 Aug 2024 10:12:30 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:167e:272c:2858:d319]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7142e28d8f9sm528460b3a.70.2024.08.21.10.12.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Aug 2024 10:12:30 -0700 (PDT) Date: Wed, 21 Aug 2024 11:12:27 -0600 From: Mathieu Poirier To: Andrew Davis Cc: Krzysztof Kozlowski , Vignesh Raghavendra , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nishanth Menon , Tero Kristo , Philipp Zabel , Hari Nagalla , linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 3/9] remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem Message-ID: References: <20240802152109.137243-1-afd@ti.com> <20240802152109.137243-4-afd@ti.com> <98d65c2e-f5a2-4894-b76d-6fa0fb8b6daf@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <98d65c2e-f5a2-4894-b76d-6fa0fb8b6daf@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240821_101232_532000_0FF93399 X-CRM114-Status: GOOD ( 27.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 19, 2024 at 10:54:11AM -0500, Andrew Davis wrote: > On 8/19/24 10:39 AM, Krzysztof Kozlowski wrote: > > On 19/08/2024 17:32, Mathieu Poirier wrote: > > > > > > > > Please remove. > > > > > Forget this comment since it would cause an error in __rproc_detach(). > > > > > > > > > > > Other than the above I'm good with this driver. That said I can't move forward > > > > > > without a nod from the DT crew. I also noticed a fair amount of code > > > > > > duplication with the k3_r5 and k3_dsp drivers. Dealing with that should not be > > > > > > part of the current work but will need to be done before another k3 driver can > > > > > > be merged. > > > > > > > > > > > > > > > The above still apply though. > > > > > > > > Me or Nishanth will pick up the SoC DT patches via TI SoC tree, once the > > > > driver patches are merged. Feel free to ignore those but queue > > > > dt-bindings (already has DT maintainers ack) and driver patches via > > > > rproc tree. > > > > > > > > > > Can you provide a link where the DT maintainers have acknowledged the bindings? > > > > The reviewed-by tag serves as acknowledgment as well and the binding > > patch has it. Conor gave it on some earlier version of the patchset. I > > did not check if there were any significant changes in the meantime, though. > > > > Was reviewed in v8: > https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240424190612.17349-2-afd@ti.com/#3302840 > I didn't notice Conor had joined the DT crew and as such was expecting something from either Rob or Krzysztof. I am applying this set. Thanks, Mathieu > If there was any significant changes since I would have dropped the tag. > > Andrew > > > > > Best regards, > > Krzysztof > >