From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4EAEEC531DF for ; Thu, 22 Aug 2024 07:04:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ykeo+6OejcW3LfPIwBroCbu3h8SlZxm1Q6n/Z4Ckav4=; b=32I/sBcr5K9zpV+h7D3Th0DDMy 3hK6tMhJ6YvmPa9bS6R0v9VyYAIt4GNJG1gj1I4Q1eBHlifch/yMZcPkLkYcw4SFmvnV7MwqN2ktZ zLFaiA3FOeITWVqBycCkY/RH3fJUU9wUmwn0DvwtwT/1RI49cEeG6cYWNmb0+AdxA9ZpZsh5xVRO+ C66SM2O3rlymgs2DHp1IiHAf9DXhWfs4zjmTEZTVpTqM3bneGXQSSdMXSpv6sZKCx6vWdkr7b646h C4zaK0Br5EFBIpOKQD8kfWuZPNr7fV+2hxxS/myk0WvUK21r5lCxTjRfEWqb6JIS7grMwTziQCq6U oYqYd3JQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh1sE-0000000BlAq-3zzW; Thu, 22 Aug 2024 07:04:46 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh1rT-0000000BkyF-3xyf for linux-arm-kernel@lists.infradead.org; Thu, 22 Aug 2024 07:04:01 +0000 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5becd359800so694248a12.0 for ; Thu, 22 Aug 2024 00:03:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724310238; x=1724915038; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ykeo+6OejcW3LfPIwBroCbu3h8SlZxm1Q6n/Z4Ckav4=; b=ARSJqddBMVDtZd6wpw+h9bCzN35c1K6YiO313Rh16/QqHmoxNrrAiDEYBy4Pa6jzzu megC8P4a/DKYD1u1iWOi4Jk9MePOez9b7wvakXe0OXiaSTCCTqEgNAtmJfgMM1MRuYI3 GUUWwBRP0J+OXiicdfB8dDkUnawTuzij14Or8rt82IsQKfAJ7sUCWy8z3x15BPtB3vhU QIuLaGxyU1laaoVz9j2LuzO0dOcizc2vWigbyd5hO3TRnKpMZMMkzkN9FbOTfDBKiQyq vjNvLgpWohbnbtCLQvrLfgUgh/qLhFCYBVCN/QyeGv1vh12qMzAj0rF0PU7ldlWVEltc 7f3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724310238; x=1724915038; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ykeo+6OejcW3LfPIwBroCbu3h8SlZxm1Q6n/Z4Ckav4=; b=Qai8Cy4o9enbIQ7gT/dSlPKVFdxi62kMZa9bOVvxoXpzV0AZNk2fePMoQgOAdpnz90 +RLg3DLAjaMwcTzQwGHpWyYkiNXJ94QahKnEpc646oyoVo8RV0JthG0DiCna/iUD6qiF 6PTImoOFGWLAiOWW5g3Ttlpg+6mIoyibk3PbBo1oVgNS0YYPjruc3TwDerEDH/fm5w4t zsjlkimBstHNhorKHskC9Cjvyk0bejCd6q+ps0mN9euThtTiXjVUQyPITtnU9dI6Cdim lKUsKIQp2vJ7q9NVEKm8OU7A0+kIfaCEhPZufPsoJ2CLIU9jIQvWnS10KG9TCuQx6E6C Uhxg== X-Forwarded-Encrypted: i=1; AJvYcCX0P9yWLZH6XTXiQ49O0UUIIKTtVBPEtmZTWcG89LYqak+MLM1d3Ff5kIdtvUWOzpdmNXLbDbrRRjnKqtjrjtBK@lists.infradead.org X-Gm-Message-State: AOJu0Yx1OFpCiDkydW0yYEDOSHNs2K6QCMXOuKBR/9mgv0Z3KkXSEHPY C8Prbh0vPPMHJcQDtVO8Lmq2ge7rJ2qKxpOpCtrU3Hb7UmPBNa7k X-Google-Smtp-Source: AGHT+IGSsNf36l7LH2UrwwyDGt/7XMjWeoEqpb8pclMdRI6cqXUAmy7bZ4Hd98389PIbKXU7Hl9JnQ== X-Received: by 2002:a17:907:968e:b0:a6f:4fc8:266b with SMTP id a640c23a62f3a-a866f135cccmr290948966b.3.1724310237810; Thu, 22 Aug 2024 00:03:57 -0700 (PDT) Received: from eichest-laptop ([2a02:168:af72:0:daa9:644d:3c2:44bb]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a868f436ccdsm72186166b.104.2024.08.22.00.03.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2024 00:03:57 -0700 (PDT) Date: Thu, 22 Aug 2024 09:03:55 +0200 From: Stefan Eichenberger To: Andi Shyti Cc: o.rempel@pengutronix.de, kernel@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, Frank.Li@nxp.com, francesco.dolcini@toradex.com, linux-i2c@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stefan Eichenberger Subject: Re: [PATCH v2 1/4] i2c: imx: only poll for bus busy in multi master mode Message-ID: References: <20240819072052.8722-1-eichest@gmail.com> <20240819072052.8722-2-eichest@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240822_000400_005824_68D3CD8D X-CRM114-Status: GOOD ( 14.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andi, On Thu, Aug 22, 2024 at 12:21:30AM +0200, Andi Shyti wrote: > Hi Stefan, > > > @@ -1468,6 +1473,8 @@ static int i2c_imx_probe(struct platform_device *pdev) > > goto rpm_disable; > > } > > > > + i2c_imx->multi_master = of_property_read_bool(pdev->dev.of_node, "multi-master"); > > + > > you might also want to add the multi-master boolean property in > the binding. We discussed this internally and weren't sure when it was required because e.g. i2c-rcar and i2c-tegra don't have it documented in their bindings. Is it still required if it is part of the dt-schema? https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/i2c/i2c-controller.yaml If so, I will add it in the next version. Thanks, Stefan