From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0DCBC52D7C for ; Thu, 22 Aug 2024 13:12:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4toNWUwVd7okly34zOUxiVP6lJnIVONZGdTQQWd7rz0=; b=wW4EZ76L2oSUmoOkxXSYJf5D+q m4XC1/7ck42tLauDxv9Hwrhg2WuDA8QrXtWzOwqR9h7ctQmoXDHj98GsrwJHG9/sbfjXkNyC+9SCw NAcwOpm2VRKA4OiAVnj4csX1buHfeURyn2hd46oexAxR501XeQ0EHwU/arUKS+j3W8Va1Enko87Ee +GlNdY6Sd3gUk58jN+x/n3+hCYRCVLVzq8IKlRh0LB8aMiu4/4N4gK1mWfnJS67GAw+B54iYjAJQi 3T8IexENMw/X4Ju4oToOgpr+z1tZTr6floQk5pRONacFs058m/zO3NV/4NKv0pHNvhiXREeuQpEVD bX5BnDIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh7cN-0000000CsRc-1ETT; Thu, 22 Aug 2024 13:12:47 +0000 Received: from mgamail.intel.com ([198.175.65.13]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh7ad-0000000Cs7V-48Qz; Thu, 22 Aug 2024 13:11:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724332260; x=1755868260; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xmonMa7CWYPhpUCav6lGTP6kAPkTd4VjdENwMfAjDQ8=; b=XP5aI6cOTulcCElQqk4aLVDcToPN7/nsV3Y75KWDB8QL5zFw/o4OAUSD peLwnfzQ4ANtp+iVnB5Q14k/mW8eGVj6NjJoFNROnHuKKbQy+8+Z+Ulc0 wsI1x/v326VQwFO38lRhlPCFJrhhQX9cisWQWLUO36RojHQG75h3d29qQ CGyya+XUwWnMiqDfP/mrB7CBopDwWBd/GrVwldLFYA5HEgBpLgqyTFp+V TEW8aAH28WgspL31Vy2vZgT33r/SJ37haU0HBryOYpZG+DYEV+oUYv/Dj XXeODw6gdMmkCp+UGZgDPg56dhGPAXNENLche5ZQn/4rGdXemgiZRmi9t w==; X-CSE-ConnectionGUID: huJQNpNyRsafJaZQpsE8GA== X-CSE-MsgGUID: h44jAJYjSpCKIf+eiLsRLg== X-IronPort-AV: E=McAfee;i="6700,10204,11172"; a="33896718" X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="33896718" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2024 06:10:16 -0700 X-CSE-ConnectionGUID: 1SNaBPdZR7KIjuHORoDEkg== X-CSE-MsgGUID: dDS462oYQ5eH9CKAcZxrOA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="61759647" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa006.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2024 06:10:03 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1sh7ZB-00000000ST5-0oxN; Thu, 22 Aug 2024 16:09:29 +0300 Date: Thu, 22 Aug 2024 16:09:28 +0300 From: Andy Shevchenko To: Lei Liu Subject: Re: [PATCH 1/8] tty: 8250_ingenic: Use devm_clk_get_enabled() helpers Message-ID: References: <20240822033924.32397-1-liulei.rjpt@vivo.com> <20240822033924.32397-2-liulei.rjpt@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240822033924.32397-2-liulei.rjpt@vivo.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240822_061100_133045_7963150C X-CRM114-Status: GOOD ( 11.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Valentin Caron , Geert Uytterhoeven , Lorenzo Pieralisi , Liviu Dudau , Alexandre Torgue , Claudiu Beznea , Paul Cercueil , Thierry Reding , Manivannan Sadhasivam , Jiri Slaby , linux-stm32@st-md-mailman.stormreply.com, opensource.kernel@vivo.com, Kunihiko Hayashi , Florian Fainelli , Jonathan Hunter , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-mips@vger.kernel.org, Patrice Chotard , John Ogness , linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org, linux-tegra@vger.kernel.org, Thomas Gleixner , Richard Genoud , Sebastian Andrzej Siewior , Greg Kroah-Hartman , Lino Sanfilippo , Masami Hiramatsu , Maxime Coquelin , Sudeep Holla , Jeff Johnson , Andreas =?iso-8859-1?Q?F=E4rber?= Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 22, 2024 at 11:39:05AM +0800, Lei Liu wrote: > The devm_clk_get_enabled() helpers: > - call devm_clk_get() > - call clk_prepare_enable() and register what is needed in order to > call clk_disable_unprepare() when needed, as a managed resource. > > This simplifies the code and avoids calls to clk_disable_unprepare(). ... > data->line = serial8250_register_8250_port(&uart); > if (data->line < 0) { > err = data->line; > - goto out_disable_baudclk; > + return err; > } data->line = serial8250_register_8250_port(&uart); if (data->line < 0) return data->line; -- With Best Regards, Andy Shevchenko