From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6648FC3DA4A for ; Thu, 22 Aug 2024 13:13:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Nac1wV7R9cw1IxTrF+jUPzMdv4iiya8srJ0rq+cuDfQ=; b=GsJ7EApn6iv1NvGjHW5HsSJ91U 8lnpXUsPPNpfUlJD35eFxwkDMBUwv7AraoEeY/CTqTBdyHc+TAR8L9wdRwezDYjyHSNfiQWfZYtSK jSkaENR9axyPdMSfPpQIQofYvMs0VY4RW/k8dodwMocha+1zFLkqBXFUkCNCj+GVJBZF0UkRI2LlI Go9WiJAlIk96V7dGI9IPWup4tzDLKUe4dcK9bXiX/LkO/zftdQ20FpzocvhWCZrnDSWFx09qVIHIq vwD7MWi01njbnWs5JNxuRn93NKS7k/zBInQkHpIJ/MQ9UxHhYBsH2yfLOY0IMta2OEZF1l1gmEPSn B58SnCdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh7d5-0000000Csc5-2Hsk; Thu, 22 Aug 2024 13:13:31 +0000 Received: from mgamail.intel.com ([198.175.65.13]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh7ao-0000000CsAH-3cqX; Thu, 22 Aug 2024 13:11:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724332271; x=1755868271; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=nFeXu58Z4i5680PFo/t6k5yRvztpjG8BD/ThcXiu3bo=; b=RtUywq0BoEWgR0hv9MN7e22dkbluwernR4BIlwvup8KYW1/gdRPFqFNR L6xTdlnLTAbMT61sG3bs5Cz0NTewliZbP7LiOay6d0sN8rLrWZ7DynNmv E5pOiNE+u4ylaUCdInnE8r6+vZP2MPj1ou+bB7L5twphiFzg598Wmz8hL wj6zH+FdQOVf/Ib8tS6X3W3b52lpW2J7vZF1r4/hxFYH0xOaWRoUfHMVP Q+IpK6iSwoP5/MWoIyzwBccH2MOD+PurdUjC90Uz5ssXW5mlcp4doLLlG 8xbXJNmGF+HXVi9H0Pxv3BJpV1kNcUY/dsxhb6xmmU37jPLI4CKc6IRSs Q==; X-CSE-ConnectionGUID: OmZtGuTxTp2NQR9K3AcYJw== X-CSE-MsgGUID: wEfU/Z1UTVi5DW1wpb7gFQ== X-IronPort-AV: E=McAfee;i="6700,10204,11172"; a="33896789" X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="33896789" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2024 06:11:01 -0700 X-CSE-ConnectionGUID: Z9hUc+AGQPCSdbALuccE+A== X-CSE-MsgGUID: Acs/L/uYTr2o+98GC88B4w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="98954827" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa001.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2024 06:10:52 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1sh7aC-00000000SUN-3Xpv; Thu, 22 Aug 2024 16:10:32 +0300 Date: Thu, 22 Aug 2024 16:10:32 +0300 From: Andy Shevchenko To: Lei Liu Subject: Re: [PATCH 2/8] tty: 8250_tegra: Use devm_clk_get_enabled() helpers Message-ID: References: <20240822033924.32397-1-liulei.rjpt@vivo.com> <20240822033924.32397-3-liulei.rjpt@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240822033924.32397-3-liulei.rjpt@vivo.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240822_061110_968280_A464144C X-CRM114-Status: GOOD ( 10.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Valentin Caron , Kunihiko Hayashi , Lorenzo Pieralisi , Liviu Dudau , Alexandre Torgue , Claudiu Beznea , Paul Cercueil , Thierry Reding , Manivannan Sadhasivam , Jiri Slaby , linux-stm32@st-md-mailman.stormreply.com, opensource.kernel@vivo.com, Florian Fainelli , Jonathan Hunter , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-mips@vger.kernel.org, Patrice Chotard , John Ogness , linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org, Amelie Delaunay , linux-tegra@vger.kernel.org, Thomas Gleixner , Richard Genoud , Sebastian Andrzej Siewior , AngeloGioacchino Del Regno , Greg Kroah-Hartman , Lino Sanfilippo , Masami Hiramatsu , Maxime Coquelin , Sudeep Holla , Jeff Johnson , Andreas =?iso-8859-1?Q?F=E4rber?= Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 22, 2024 at 11:39:06AM +0800, Lei Liu wrote: > The devm_clk_get_enabled() helpers: > - call devm_clk_get() > - call clk_prepare_enable() and register what is needed in order to > call clk_disable_unprepare() when needed, as a managed resource. > > This simplifies the code and avoids calls to clk_disable_unprepare(). ... > err_clkdisable: > - clk_disable_unprepare(uart->clk); > > return ret; Now this label (err_clkdisable) becomes redundant and code may use return ret in-line. -- With Best Regards, Andy Shevchenko