From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C8D8C52D7C for ; Thu, 22 Aug 2024 13:24:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=owwQNtDmn3QQDxdFzY/ytn6lLV3cfwU0u3sR8PF6Erg=; b=O6BMTk6XekESXuuQdVdW6TG89S 8cu7kLNJovNV5ibbzGIKHOEncHcCYZcEAoo3iTzdoJ74CG3fmtIFJ5vOisHbnSN87sd8gqHP/VeZa pnNACLUANsuRPErz/1+XTpkg0XJ8eFR87Xidhpy57zD9NFzpeIrX7iMRmQBCdBNNwR8sLfDRVjA8Y Acdbey6JihlQY4WAOdwdGIT8EC2h0PIWBymcC9uWLq+d+kgK+gihWNc9zxs+S8RJv/gRUnYXCMZUe uh0Sif0h0dCLS+e3+f/4S8WPCkwWC4h30GjN8fIv3+hrkfopPlCTUz15zpJf7WYXOFRzQzLVzZUBo 3XHkjHeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh7nI-0000000Cunb-38im; Thu, 22 Aug 2024 13:24:04 +0000 Received: from mgamail.intel.com ([198.175.65.10]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh7mW-0000000CuYE-0ndw; Thu, 22 Aug 2024 13:23:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724332997; x=1755868997; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=KFpKpnvDW0vqhhMnIVIsrqf2HnMAwgbclbS7nIfq404=; b=gvRMFUNuXM1QoVl0xwOY6ncnLPZRaKEhnhJKBEhquu772xMAL76AkeMO YDVuJLUxQkD08T0GZVTsLkpSyBrpfg1upBjMCw7fjkagxS8/cx39Rcave GsgrMCEHfaJVsnK4SQCdv1eG5wsTG/GltodFKLkdk2NhPidh0/3eCMZDG mjlqUt2r6Ee9qtRfchZjiAw8c4ioGJBTgNhvZvaYWPBSKMw69KTWrLhZR H+BwtXf0Lns6M6hmfFnIo5Ut0lCwgEd/YgrOHiKJbn/T6ksDsoBWWhjyF Wmizz3GpNA5zrpA8JTW39+XWRhJ9kxcCk1/sgeBFM449A82tSe+rkQpS9 Q==; X-CSE-ConnectionGUID: Jw9nD5fcQkubYlIBQsevIA== X-CSE-MsgGUID: KHFbrJdBRD+8TmefTyKhgQ== X-IronPort-AV: E=McAfee;i="6700,10204,11172"; a="40206704" X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="40206704" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2024 06:23:15 -0700 X-CSE-ConnectionGUID: mVP2oLmLRwW6zgMul9JDcQ== X-CSE-MsgGUID: /9OVbZTARoyrygXmExiBxw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="65644729" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2024 06:23:08 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1sh7mI-00000000Shg-0KHI; Thu, 22 Aug 2024 16:23:02 +0300 Date: Thu, 22 Aug 2024 16:23:01 +0300 From: Andy Shevchenko To: Lei Liu Subject: Re: [PATCH 8/8] tty: stm32-usart: Use devm_clk_get_enabled() helpers Message-ID: References: <20240822033924.32397-1-liulei.rjpt@vivo.com> <20240822033924.32397-9-liulei.rjpt@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240822033924.32397-9-liulei.rjpt@vivo.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240822_062316_314153_C4BF2661 X-CRM114-Status: GOOD ( 10.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Valentin Caron , Kunihiko Hayashi , Lorenzo Pieralisi , Liviu Dudau , Alexandre Torgue , Claudiu Beznea , Paul Cercueil , Thierry Reding , Manivannan Sadhasivam , Jiri Slaby , linux-stm32@st-md-mailman.stormreply.com, opensource.kernel@vivo.com, Geert Uytterhoeven , Jonathan Hunter , linux-arm-kernel@lists.infradead.org, Andi Shyti , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-mips@vger.kernel.org, Patrice Chotard , linux-serial@vger.kernel.org, John Ogness , linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org, Amelie Delaunay , linux-tegra@vger.kernel.org, Thomas Gleixner , Richard Genoud , Sebastian Andrzej Siewior , Greg Kroah-Hartman , Lino Sanfilippo , Masami Hiramatsu , Maxime Coquelin , Sudeep Holla , Jeff Johnson , Andreas =?iso-8859-1?Q?F=E4rber?= Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 22, 2024 at 11:39:12AM +0800, Lei Liu wrote: > The devm_clk_get_enabled() helpers: > - call devm_clk_get() > - call clk_prepare_enable() and register what is needed in order to > call clk_disable_unprepare() when needed, as a managed resource. > > This simplifies the code and avoids calls to clk_disable_unprepare(). ... > err_clk: > - clk_disable_unprepare(stm32port->clk); > > return ret; No unneeded label, please drop it as well and return directly. -- With Best Regards, Andy Shevchenko