From: Mike Rapoport <rppt@kernel.org>
To: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Cc: "Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Tvrtko Ursulin" <tursulin@igalia.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-dev@igalia.com,
"Maíra Canal" <mcanal@igalia.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>
Subject: Re: [PATCH 1/2] numa: Add simple generic NUMA emulation
Date: Thu, 22 Aug 2024 12:28:59 +0300 [thread overview]
Message-ID: <ZscE23zQZGCqUz0p@kernel.org> (raw)
In-Reply-To: <7673fb84-5fe8-4d80-865d-95df3f519528@igalia.com>
Hi Tvrtko,
On Mon, Aug 12, 2024 at 05:35:31PM +0100, Tvrtko Ursulin wrote:
>
> Hi Jonathan,
>
> On 08/08/2024 17:27, Jonathan Cameron wrote:
> > On Thu, 8 Aug 2024 12:56:44 +0100
> > Tvrtko Ursulin <tvrtko.ursulin@igalia.com> wrote:
> > >
> > > c)
> > > Strong nack for either a) or b) - so "do it in the firmware" comment.
> > >
> > > Trying to understand your position so we can progress this.
> >
> > See:
> > https://lore.kernel.org/all/20240807064110.1003856-20-rppt@kernel.org/
> > and rest of thread
> > https://lore.kernel.org/all/20240807064110.1003856-1-rppt@kernel.org/
> > [PATCH v4 00/26] mm: introduce numa_memblks
> >
> > Much larger rework and unification set from Mike Rapoport
> > that happens to end up adding numa emulation as part of making
> > the x86 numa_memblk work for arm64 etc.
> >
> > It's in mm-unstable now so getting some test coverage etc.
> >
> > Sorry, I'd kind of assumed this also went to linux-mm so
> > the connection would have been made.
>
> This is great - I did not see it since I don't read linux-mm regularly!
>
> I gave Mike's implementation a spin on top of RPi 6.11 kernel and it mostly
> works fine.
>
> Is the decision that this is going in pretty much set, that is, high level
> acks are there?
It's in mm-unstable now
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/log/?h=mm-unstable
and I hope will go to Linus next merge window.
> One area to potentially improve is working around CMA areas when they are
> put by the firmware at a range which straddles two nodes. In my series,
> albeit not the one I yet posted, I have some code to fudge that so that CMA
> ends up wholly in one node and so CMA initialisation can succeed.
>
> I can try and adapt that patch to this series and post as a RFC.
>
> Then there are some odd things about NUMA, memory pressure and swap
> behaviour, but that is not specific to this series and not something I got
> to the bottom off just yet. Could be specific to my board and IO for
> instance.
>
> Regards,
>
> Tvrtko
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2024-08-22 9:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 12:58 [PATCH 0/2] NUMA emulation for arm64 Tvrtko Ursulin
2024-06-25 12:58 ` [PATCH 1/2] numa: Add simple generic NUMA emulation Tvrtko Ursulin
2024-06-26 7:38 ` Greg Kroah-Hartman
2024-06-26 11:47 ` Tvrtko Ursulin
2024-07-03 7:47 ` Tvrtko Ursulin
2024-08-08 11:56 ` Tvrtko Ursulin
2024-08-08 16:27 ` Jonathan Cameron
2024-08-12 16:35 ` Tvrtko Ursulin
2024-08-22 9:28 ` Mike Rapoport [this message]
2024-06-26 7:39 ` Greg Kroah-Hartman
2024-06-25 12:58 ` [PATCH 2/2] arm64/numa: Add NUMA emulation for ARM64 Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZscE23zQZGCqUz0p@kernel.org \
--to=rppt@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-dev@igalia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcanal@igalia.com \
--cc=tursulin@igalia.com \
--cc=tvrtko.ursulin@igalia.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).