From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9644CC3DA4A for ; Thu, 22 Aug 2024 09:48:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gV1ZljvCq7omiCbtupPguMHZ99AEeDPribeRwS1pHP0=; b=qDJKLPNV5uPDmQtzO+nimnOIqQ rHq/5jVeLVnGI3SPwa8sr3kneiSTQpY/hJF8T2esrLxCdFWZk4Rb0qOCvVtdBN57WEVoIPOrixPc0 s6Gm07eF6TpHYQ8MyzmmuUdN/3CLMzmgxiZ7KR+7Y5pr/elS9AJh5UqUJV+gmDv3Tb7IZvyFP4IOK AODYahjHJNviftqH6lowq2UFckXV7eij9vpya2+3GifrssTmAkjLk+AR/0kjXuyCKBTpQ190JpChX lWWDeMxTFjdCULwYRRCdW6tDRtpkqYhgMNIN4NX4LfJynHyACYUIDd1m8Zvb7EU7Ec+NVS0+ID4o+ 0QtVmf9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh4Q3-0000000CJjR-30d0; Thu, 22 Aug 2024 09:47:51 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh4Mt-0000000CIgP-1hzk for linux-arm-kernel@lists.infradead.org; Thu, 22 Aug 2024 09:44:45 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D8014DA7; Thu, 22 Aug 2024 02:44:59 -0700 (PDT) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A8F083F58B; Thu, 22 Aug 2024 02:44:32 -0700 (PDT) Date: Thu, 22 Aug 2024 10:44:26 +0100 From: Mark Rutland To: Jing Zhang , Will Deacon Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Shuai Xue Subject: Re: [PATCH v2] drivers/perf: Fix ali_drw_pmu driver interrupt status clearing Message-ID: References: <2a70eaa3-f1c5-4803-948b-4b8eb86190c6@linux.alibaba.com> <1724297611-20686-1-git-send-email-renyu.zj@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1724297611-20686-1-git-send-email-renyu.zj@linux.alibaba.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240822_024435_588897_6BAE1BEF X-CRM114-Status: GOOD ( 17.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Will, are you happy to pick this up? Mark. On Thu, Aug 22, 2024 at 11:33:31AM +0800, Jing Zhang wrote: > The alibaba_uncore_pmu driver forgot to clear all interrupt status > in the interrupt processing function. After the PMU counter overflow > interrupt occurred, an interrupt storm occurred, causing the system > to hang. > > Therefore, clear the correct interrupt status in the interrupt handling > function to fix it. > > Fixes: cf7b61073e45 ("drivers/perf: add DDR Sub-System Driveway PMU driver for Yitian 710 SoC") > Signed-off-by: Jing Zhang > Reviewed-by: Shuai Xue > Acked-by: Mark Rutland > --- > drivers/perf/alibaba_uncore_drw_pmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c > index 38a2947..c6ff1bc 100644 > --- a/drivers/perf/alibaba_uncore_drw_pmu.c > +++ b/drivers/perf/alibaba_uncore_drw_pmu.c > @@ -400,7 +400,7 @@ static irqreturn_t ali_drw_pmu_isr(int irq_num, void *data) > } > > /* clear common counter intr status */ > - clr_status = FIELD_PREP(ALI_DRW_PMCOM_CNT_OV_INTR_MASK, 1); > + clr_status = FIELD_PREP(ALI_DRW_PMCOM_CNT_OV_INTR_MASK, status); > writel(clr_status, > drw_pmu->cfg_base + ALI_DRW_PMU_OV_INTR_CLR); > } > -- > 1.8.3.1 >