From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1A4BC5320E for ; Thu, 22 Aug 2024 10:05:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:Date:From:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MpyK4IsQzJrI6qeJJhvprKefQNt+Ld7JQCqPLKfE9e0=; b=dHchV0pPTZ6NiDDnMex0FdV9Jz 9Z4paKkFaz5IQYeHFvhWGQ0V5zALsyRkzz/47LoNCCHb8h3R32UYizISMLyaxejMGZx0/8icr1KFk 7z6TYSbOSB6w30vmS+7OC+2M7oREfJg003DpaF8XZGFWfvRGWsjrC0KI2H7B2LNBDp2mgIlxShYf2 U3hMI0JFlo6ZkM2UYGPV/w5XI+zJ1iIAmHxAUWdoTVlUrFOxyeTp+FIBEgL7fUK6aoCmdz12gvI7d iw5PQgu0SrQrPR7cnj2vAD5auBc+Lv02CjqHaT5lBoVSw7PsvJJbqB2JKgVKecm6XmrFBb2xy4SMm HqKTYhWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh4gv-0000000CMt7-45V0; Thu, 22 Aug 2024 10:05:17 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh4gA-0000000CMfg-3UfM for linux-arm-kernel@lists.infradead.org; Thu, 22 Aug 2024 10:04:32 +0000 Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-5becd359800so864670a12.0 for ; Thu, 22 Aug 2024 03:04:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724321069; x=1724925869; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=MpyK4IsQzJrI6qeJJhvprKefQNt+Ld7JQCqPLKfE9e0=; b=Zo1TihrnZ28WdTyXfDEKfYXTGKUy9w6Ivj2Um5NDX/2JUsZVaaeAKWhKuuweiaoOzU g4rGDSK3CQ6gde45vqNyRY0vU1oUmfSei6Jq2DvvzK2wDRmPkr2An4UnDT9TH6/1BCuU CBmiVOlEd/AWsgG4hbwfAhC/xpu6ck5aE4dJuhVhVvj2BmGYmmi5nGM3PeQAt3xssu6y VTmWjEdxFER1CJmVMtfSlwCkgP9c9F1Pb4v3024lsSH6wdam2t5eQHH3YVJfmVsqx9Qr wFTu/dTR5cmXgW6YkFgbdM1pgjdbku2WzMmokpBGJF6PGu91P5u2eW2933d+pEaOW6G/ 7DXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724321069; x=1724925869; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MpyK4IsQzJrI6qeJJhvprKefQNt+Ld7JQCqPLKfE9e0=; b=IxDZffTQTBrXA2hZP9s0E+R9E46Xfc9/VlTSvHgQ5/wCBv5skIRb0S6jKsd5yWhEpW QvAsBuGgQG0nXq+8oCeroCnPfZZN3QFV2xRiM+KSVtL0rLmB/qg590CcTBKSFQrVvLVQ NFFCwkI9NEgzDOy8F6noVAgqiq4m6Ys17+dZLwElKFxsz+A4hvbi4BYstwm8WKCTTT/C pBXmyeP2CXD0oOihKi15UhmlFYwloziwHP3PlMmovY/Stds1a6nPGu/GB+UqoqBUnepT IutMLhQeEW4PNhW8xm14gQfT4sdW0wo9V/Y7R+1TqaOj3dHSorrgOJveD4Ew8rNyi8Jf eGtA== X-Forwarded-Encrypted: i=1; AJvYcCWSULCfXxYD9sTtUlTCy7e7TVyQi3nGnbVPfrvaCEzue7GmB5T0mfm44o6s030nkRpNhz1nvyvoX4PQR7TvmxZ6@lists.infradead.org X-Gm-Message-State: AOJu0YzjXh7MjYuvBVChxdekx5gGbRun7HV1/JpBJFy864OAAbpka/vZ Qb5rQsBME1qV++UqgjhIuJ+mAJl8mqD9mlMZxO1817ee3BLOBLmO9XTY5umwWPc= X-Google-Smtp-Source: AGHT+IHlxXQHOoIG5Xms+dbKMTaH/vArkSFDYv8NHwvurq0I3OqBwEKhWmO0dZKyqjO8q42AqL7AQQ== X-Received: by 2002:a17:907:f14d:b0:a7a:9760:9aec with SMTP id a640c23a62f3a-a866f8c3418mr450021966b.43.1724321068912; Thu, 22 Aug 2024 03:04:28 -0700 (PDT) Received: from localhost ([87.13.33.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a868f48a9b6sm96500966b.179.2024.08.22.03.04.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2024 03:04:28 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Thu, 22 Aug 2024 12:04:34 +0200 To: Simon Horman Subject: Re: [PATCH 06/11] clk: rp1: Add support for clocks provided by RP1 Message-ID: Mail-Followup-To: Simon Horman , Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Linus Walleij , Catalin Marinas , Will Deacon , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Nicolas Ferre , Claudiu Beznea , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Saravana Kannan , Bjorn Helgaas , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, Lee Jones , Andrew Lunn , Stefan Wahren References: <20240821131757.GB6387@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240821131757.GB6387@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240822_030430_898563_ACFAC909 X-CRM114-Status: GOOD ( 28.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Catalin Marinas , Michael Turquette , Claudiu Beznea , Eric Dumazet , Dragan Cvetic , Will Deacon , linux-clk@vger.kernel.org, linux-arch@vger.kernel.org, Rob Herring , Florian Fainelli , Lee Jones , Saravana Kannan , Broadcom internal kernel review list , linux-pci@vger.kernel.org, Jakub Kicinski , Paolo Abeni , Linus Walleij , devicetree@vger.kernel.org, Conor Dooley , Arnd Bergmann , linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Bjorn Helgaas , Andrea della Porta , linux-arm-kernel@lists.infradead.org, Derek Kiernan , Stephen Boyd , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Stefan Wahren , netdev@vger.kernel.org, Krzysztof Kozlowski , "David S. Miller" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Simon, On 14:17 Wed 21 Aug , Simon Horman wrote: > On Tue, Aug 20, 2024 at 04:36:08PM +0200, Andrea della Porta wrote: > > RaspberryPi RP1 is an MFD providing, among other peripherals, several > > clock generators and PLLs that drives the sub-peripherals. > > Add the driver to support the clock providers. > > > > Signed-off-by: Andrea della Porta > > ... > > > diff --git a/drivers/clk/clk-rp1.c b/drivers/clk/clk-rp1.c > > new file mode 100644 > > index 000000000000..d18e711c0623 > > --- /dev/null > > +++ b/drivers/clk/clk-rp1.c > > @@ -0,0 +1,1655 @@ > > +// SPDX-License-Identifier: GPL > > checkpatch says: > > WARNING: 'SPDX-License-Identifier: GPL' is not supported in LICENSES/... > Alas, the system on which I executed checkpatch was missing git python module, so spdxcheck.py wasn't working properly, sorry about that. Fixed in the next release. > ... > > > +static int rp1_clock_set_parent(struct clk_hw *hw, u8 index) > > +{ > > + struct rp1_clock *clock = container_of(hw, struct rp1_clock, hw); > > + struct rp1_clockman *clockman = clock->clockman; > > + const struct rp1_clock_data *data = clock->data; > > + u32 ctrl, sel; > > + > > + spin_lock(&clockman->regs_lock); > > + ctrl = clockman_read(clockman, data->ctrl_reg); > > + > > + if (index >= data->num_std_parents) { > > + /* This is an aux source request */ > > + if (index >= data->num_std_parents + data->num_aux_parents) > > It looks like &clockman->regs_lock needs to be unlocked here. > > Flagged by Smatch, Sparse. and Coccinelle. Ack. Many thanks, Andrea > > > + return -EINVAL; > > + > > + /* Select parent from aux list */ > > + ctrl = set_register_field(ctrl, index - data->num_std_parents, > > + CLK_CTRL_AUXSRC_MASK, > > + CLK_CTRL_AUXSRC_SHIFT); > > + /* Set src to aux list */ > > + ctrl = set_register_field(ctrl, AUX_SEL, data->clk_src_mask, > > + CLK_CTRL_SRC_SHIFT); > > + } else { > > + ctrl = set_register_field(ctrl, index, data->clk_src_mask, > > + CLK_CTRL_SRC_SHIFT); > > + } > > + > > + clockman_write(clockman, data->ctrl_reg, ctrl); > > + spin_unlock(&clockman->regs_lock); > > + > > + sel = rp1_clock_get_parent(hw); > > + WARN(sel != index, "(%s): Parent index req %u returned back %u\n", > > + data->name, index, sel); > > + > > + return 0; > > +} > > ...