From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A438C5321D for ; Thu, 22 Aug 2024 10:54:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oQN7VJRq5yYZwmqAw7940dVZaTcGPczkNV+IY7gEbUY=; b=HT0WnK1GuCVcjrAxuelxATQkyz PiruaqPp3y69FmI2YJcc0lF/leABNxOkt11C3mGiaeooXHBywb5Y3CmO6W9OicXrco497JGY9A1LF +YwDRRW+nqgDNLBBvLZQW7Q0SzF9QE1+mFGekqh58WtnRdGFO7yeVE83FDRCUMtp/iDDFlcJ0Uy1z RhOtj+dzTTTLMWnHLlPuR28InxeYY+gnIebJvPF3qTobm/EqglesvZ9QgFeXhmbihLqt0r5xbLBg0 xUddzh7MaWYAfsGgUvPgfXZBvgf+o3Fw9CSFuod2NNeocuIb6u8N9mPeTL8BbUvdv9aa2y8O3b3zx IMiIoD1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh5SQ-0000000CUVv-2S4O; Thu, 22 Aug 2024 10:54:22 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh5Rh-0000000CUR5-2RPw for linux-arm-kernel@lists.infradead.org; Thu, 22 Aug 2024 10:53:38 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 19BEADA7; Thu, 22 Aug 2024 03:54:03 -0700 (PDT) Received: from bogus (e107155-lin.cambridge.arm.com [10.1.198.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BB4023F58B; Thu, 22 Aug 2024 03:53:34 -0700 (PDT) Date: Thu, 22 Aug 2024 11:53:31 +0100 From: Sudeep Holla To: "Peng Fan (OSS)" Cc: cristian.marussi@arm.com, mturquette@baylibre.com, sboyd@kernel.org, Sudeep Holla , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, d-gole@ti.com, Peng Fan Subject: Re: [PATCH V3] clk: scmi: add is_prepared hook Message-ID: References: <20240806145601.1184337-1-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240806145601.1184337-1-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240822_035337_681483_99BC00D0 X-CRM114-Status: UNSURE ( 9.84 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 06, 2024 at 10:56:01PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Some clocks maybe default enabled by hardware. For clocks that don't > have users, that will be left in hardware default state, because prepare > count and enable count is zero,if there is no is_prepared hook to get > the hardware state. So add is_prepared hook to detect the hardware > state. Then when disabling the unused clocks, they can be simply > turned OFF to save power during kernel boot. > LGTM, Reviewed-by: Sudeep Holla IIUC, there is no dependency on any SCMI changes, so this can go alone via clk tree. -- Regards, Sudeep