From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91A81C52D7C for ; Thu, 22 Aug 2024 12:04:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AY16LwIBghLKS2thXS/HdTgvr57cr8ORfO+2U5rpJTM=; b=YOPAbKefi4Iw9G62uzDeDor17u Aiejrtq4O/hgk3le1odUd4lyXSuNwE+vj2+UCYZMGweki3TBbtPvFf1b+VA1XIwIOPTyonpob9y2e QDXHreR2CiUlg++jVzbwe3MtsnbWx3WN4CGJJ2CRfzfOwrihm0lHOSYznyS9S9BeKLNVn4GpElRQH P/IyPq7SCjwcWrUy019mhXl+XAY3tC30g44KUdzNlfe8lXqO3Ui1+h3VS7XDG4C0hU45YsR5hG5/z wdU8I2Oxzz1bslXYb+kBhGGHWhPVF4e/bPQB+4lhtr7oiqRCqt53Z3JSKdjUsdh/g3UgO6T/t/WYT EZxU1S3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh6YV-0000000ChA4-1hVZ; Thu, 22 Aug 2024 12:04:43 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh6Xl-0000000Cgzn-1CiJ for linux-arm-kernel@lists.infradead.org; Thu, 22 Aug 2024 12:03:58 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-42808071810so5478315e9.1 for ; Thu, 22 Aug 2024 05:03:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724328236; x=1724933036; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AY16LwIBghLKS2thXS/HdTgvr57cr8ORfO+2U5rpJTM=; b=WwSB9vUozAM7L32hmF/sBk8Ohv9Rd3Kw8hJNubRYT5rulc+0/VtizNUyEE6OqblWzx JUkIgzkEalEY/F1pqq5zVd2wkoKXAH6LNdfCWJt9UMat7DgrSTlED/xB6Ku7aeVoU3pY 6SZP2QSgotT/Q3R/ACRSsL+j9mo2BUqpRw9/qOvqq1U6jCw/cw8q3Kq+JI/4IDQ6Uwm8 pi3SJCVhYyKcvFvfbA4kyNsILu2ZuO5J/RBkqHRYQX7tbow8pNQ30bDzl/qsXVGpA1AY px9M9+4kzuX24o1/WkH2Ezm2rVJOTjk1cLdboMtYgjpOhkvzq/pHwE18fVxoVtml9M1f CytA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724328236; x=1724933036; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AY16LwIBghLKS2thXS/HdTgvr57cr8ORfO+2U5rpJTM=; b=GCCijAXhBuO2Q0n6zjHuLFjf9mI7SyBcPJDgmRu3SxiA8ndkN8lydOTWrMCo/zuCh3 lqFaw+OF85fsosE+4lWLAu2pP9uK/qf21axb0eiS7F7L4+dQdubX6iI4R6u8Q5+CvhDZ 99nH43rLutw4Qe5+LE2GJa5LUOx3nGbPuoVp/0JMRA687DV8TnyDGsfAOjoEZdwSC+9v /O7BLqToavyhXFL+LsMaNPU8Mi09xtaV+wumhTHyvgZ2ytlRtGYeXoSAN9NEXBD0wvbm xT0dgi9xxTKCQtduldC2XjgAMd/OzQsD/rHCDuX0XOVYytzWd9T19spwOJaAfzlmNI3G GrAg== X-Forwarded-Encrypted: i=1; AJvYcCWdtnOCMRRiIJptVIQq3l40muQ1Ojxn7mqmn3hN0SWQtarNYeGUPIsFWgZQPFeL/rdnO7NO09vVA0GwwQQixtZ/@lists.infradead.org X-Gm-Message-State: AOJu0YysnohLIDTaaBvosxzdB+rgFJGDVuU0r2xsmg9yYURoaz//MU/H hCJGaAUf0eZ1DJQappKHwYsoo5IhIa9olQZ40dFPxQCiaEdfCN7s X-Google-Smtp-Source: AGHT+IEFxPFmRaY+PNp14y1u8ekMx5ha3DFQw+w7+iWj6isuIlJVoOIiRVhai99HMnCgTpLp5x6Kjw== X-Received: by 2002:a05:600c:310c:b0:428:ec2a:8c94 with SMTP id 5b1f17b1804b1-42abd11e2famr45807665e9.10.1724328235478; Thu, 22 Aug 2024 05:03:55 -0700 (PDT) Received: from eichest-laptop ([2a02:168:af72:0:daa9:644d:3c2:44bb]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42ac51860e8sm21974725e9.48.2024.08.22.05.03.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2024 05:03:55 -0700 (PDT) Date: Thu, 22 Aug 2024 14:03:53 +0200 From: Stefan Eichenberger To: Oleksij Rempel Cc: Andi Shyti , kernel@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, Frank.Li@nxp.com, francesco.dolcini@toradex.com, linux-i2c@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stefan Eichenberger Subject: Re: [PATCH v2 1/4] i2c: imx: only poll for bus busy in multi master mode Message-ID: References: <20240819072052.8722-1-eichest@gmail.com> <20240819072052.8722-2-eichest@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240822_050357_350083_DB6083DE X-CRM114-Status: GOOD ( 19.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 22, 2024 at 12:04:43PM +0200, Oleksij Rempel wrote: > On Thu, Aug 22, 2024 at 09:03:55AM +0200, Stefan Eichenberger wrote: > > Hi Andi, > > > > On Thu, Aug 22, 2024 at 12:21:30AM +0200, Andi Shyti wrote: > > > Hi Stefan, > > > > > > > @@ -1468,6 +1473,8 @@ static int i2c_imx_probe(struct platform_device *pdev) > > > > goto rpm_disable; > > > > } > > > > > > > > + i2c_imx->multi_master = of_property_read_bool(pdev->dev.of_node, "multi-master"); > > > > + > > > > > > you might also want to add the multi-master boolean property in > > > the binding. > > > > We discussed this internally and weren't sure when it was required > > because e.g. i2c-rcar and i2c-tegra don't have it documented in their > > bindings. Is it still required if it is part of the dt-schema? > > https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/i2c/i2c-controller.yaml > > The i2c-imx.yaml has "unevaluatedProperties: false", which fill discard > every thing not in this yaml > > > If so, I will add it in the next version. > > Yes, please. Perfect, thanks for the explanation. Regards, Stefan