From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6FB80C3DA4A for ; Thu, 22 Aug 2024 18:08:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GQybDFmkYIn6xZ+90bRuYKiZGiAETXvH8v85EQgpozk=; b=nleW3e2sGo0K4aYKXwppxpbCgE wQ1v4EIqX7R014uIukPmleXN3gR6PaW0dT1t226HyS3J7WTm/i3quXVMDo5K1hCQbuX5vITiy4zcE CbNTalvTMkTrPQNeprUOx0zeqSuKooY6IlgasKkXPiaQctWIbAnmJGDQ7dp2OUmcnYAkeLmkHt7DZ vzIGL++MwH8VatJURIYeWOd9UK9bcOJlWN8I3nAzFVBWffrjqSnT5QX7T4EycFldx0p1KU+ePr3AI WD7bQLUcZ2N/i2wBqIEICmGbGRD+KAoNbZbyuHQrF2iFUFKmLhhSTSTjws2mOiYPcT/6PQEDVYU50 ppXxPqgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shCEV-0000000DttJ-3rdv; Thu, 22 Aug 2024 18:08:27 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shCDm-0000000Dtkh-0C8P for linux-arm-kernel@lists.infradead.org; Thu, 22 Aug 2024 18:07:43 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-202318c4f45so10998485ad.0 for ; Thu, 22 Aug 2024 11:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724350061; x=1724954861; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GQybDFmkYIn6xZ+90bRuYKiZGiAETXvH8v85EQgpozk=; b=fPr5Vea42ICqLCnZ9ZEqn8/aIE/osd0fPK1RA1DkN1npU43NOxVusm8oAPAca+fTPF oMt8W2kAXH3uUC3hBwP+OXmvu+d0KDjyv2GHVDtTGDXZL4+BGLsyo3Ioo8EJhdmxdfYk L6vcr+pLduDanOrkF4QJlv9u4NCR0q8+uoVkTq54k05jgeE8daC8mAGKipG9rKZZ8E7L Tbk96REvGKU+WB2aPWFsB94VVftC/TdCF7U8qBn1R36yazWGvbIlRGwitvS6G3ZZ4T0i JYTK73sj7qH6H5HjegWZS5QPdHDdhkuMlA2VlEBj39sC6COqXnWL6n23nNowqUHrICXp JZWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724350061; x=1724954861; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GQybDFmkYIn6xZ+90bRuYKiZGiAETXvH8v85EQgpozk=; b=GOQf/IkDJtqpIGzFgq5R3ZFcHn40QKqVipSv3K9Wi9YfxULDynb3WRMtLJ4icdgDsC gWs/z1DwZdXn06tWuSD0HWJAm4rxOHjkJBU2U1xSuFEtpvqG9xCFRElfyCezIclXMLVo 2bu6L6MiadQfvGLQNZED+VvPPWdooCLyrgSRlLzKrKAhXUMIfduurVe2PY0UVuwhxxni n1NUDrY1ekYx/vDVDswalwqCtLS91+gxXjCli1rQLNrT2wT5slj2l3ZN3QT8KJaKOGrh 5pYlxCUp+gC5Z/NHrHZQe/oqn3rHl/hj0s1zatf2PikLvc08mujxvBeIV6Lwvjb612V2 hBUw== X-Forwarded-Encrypted: i=1; AJvYcCXzRv8A9eIkBliROOgFbA/0Nm9PlY8sEQD4zgasREtjc/C5P55ZEv6Ut2OtUa8krQ3Feb36KI+kYIeI0ISyTomL@lists.infradead.org X-Gm-Message-State: AOJu0YwWiK7P1gLY9sfq4lBD322ctpxCq6U5FPpHpSk1I7SeuKR3h6w5 dKPy4kYzbRKcQmG+4Bpzfxuk7m/JiW76HWv6B+N9tnj5dYE4FQsyar+phw== X-Google-Smtp-Source: AGHT+IHBi4GxWgUXMcq98eVE29iY0upag5vzbbKCImIrJyIAQdIDDT41hS5m+8Vv4xn3Pcuv4QSJjA== X-Received: by 2002:a17:90b:1d8d:b0:2cd:40ef:4764 with SMTP id 98e67ed59e1d1-2d5e99ebb94mr7480722a91.17.1724350060624; Thu, 22 Aug 2024 11:07:40 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:ccdb:6951:7a5:be1b]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d5eb8d235esm4544510a91.6.2024.08.22.11.07.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2024 11:07:40 -0700 (PDT) Date: Thu, 22 Aug 2024 11:07:37 -0700 From: Dmitry Torokhov To: Krzysztof Kozlowski Cc: Arnd Bergmann , Mark Brown , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, patches@opensource.cirrus.com Subject: Re: [PATCH 06/14] Input: samsung-keypad - use guard notation to acquire mutex Message-ID: References: <20240819045813.2154642-1-dmitry.torokhov@gmail.com> <20240819045813.2154642-7-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240822_110742_108104_0DCB0893 X-CRM114-Status: GOOD ( 18.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 22, 2024 at 05:48:33PM +0200, Krzysztof Kozlowski wrote: > On Sun, Aug 18, 2024 at 09:58:03PM -0700, Dmitry Torokhov wrote: > > Guard notation is more compact and ensures that the mutex will be > > released when control leaves the function. > > > > Signed-off-by: Dmitry Torokhov > > --- > > drivers/input/keyboard/samsung-keypad.c | 8 ++------ > > 1 file changed, 2 insertions(+), 6 deletions(-) > > > > You need to include cleanup.h (unless some other patch already did it > and I missed it?) Guard for mutexes defined in mutex.h which is pulled in indirectly, and cleanup.h is included there. If we want to list all the headers that we need instead of relying on indirect inclusions I think we need a separate patch. But even then I wonder if things like cleanup.h should be included by drivers directly... Thanks. -- Dmitry