From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78483C3DA4A for ; Thu, 22 Aug 2024 14:46:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nbhEGtLvA6jgmJL0W2sG1CIYVUHm8c6GXJw+PzWugZU=; b=xdKdpM7od05zrvdL9GMKccmsO8 AElUuBksLnI3G7YB1mytAbtysstXSZj5w37yR0vBakkmbzhy13OGsHJKXjEBDiutTUGiaC3zKpdLk GxC1oExMlrFbKptFa0AvHwmJAYtcQCau2dQGs3rxTDDxbUnznJh7G1hL9RpdATY+NhfdwYZD5ojbf RL3HDp3arYGGeN/SiuReApyHxzjsaXphMleYw2jYzOIUCGnDofmgiGFHaimQRZf4JCz+kyks/JUb7 m1ZMitu1ImEPLiE+KnBGybQYvcPcGZ2uUcor8ULEY6blnZVZK+iLD0n0WuCeMIgNbzH0Im5FAXXod mYx79BBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh950-0000000DD7q-35uG; Thu, 22 Aug 2024 14:46:26 +0000 Received: from mgamail.intel.com ([192.198.163.19]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh94F-0000000DCuD-32e6 for linux-arm-kernel@lists.infradead.org; Thu, 22 Aug 2024 14:45:40 +0000 X-CSE-ConnectionGUID: 0879SgZ7QMKFlxySP1tASg== X-CSE-MsgGUID: JNpykAP2R/K9uSezxUjPjQ== X-IronPort-AV: E=McAfee;i="6700,10204,11172"; a="22360679" X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="22360679" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2024 07:45:38 -0700 X-CSE-ConnectionGUID: 8qTJ1xUcTSCwD9dSqx9njw== X-CSE-MsgGUID: DQf8vM2PTiWk6u+9lqITwg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="65665426" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2024 07:45:29 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1sh93K-00000000U3f-1bWg; Thu, 22 Aug 2024 17:44:42 +0300 Date: Thu, 22 Aug 2024 17:44:42 +0300 From: Andy Shevchenko To: Philipp Stanner Cc: Jonathan Corbet , Jens Axboe , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Linus Walleij , Bartosz Golaszewski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Bjorn Helgaas , Alvaro Karsz , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Richard Cochran , Mark Brown , David Lechner , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Damien Le Moal , Hannes Reinecke , Chaitanya Kulkarni , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fpga@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, virtualization@lists.linux.dev Subject: Re: [PATCH v3 5/9] ethernet: cavium: Replace deprecated PCI functions Message-ID: References: <20240822134744.44919-1-pstanner@redhat.com> <20240822134744.44919-6-pstanner@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240822134744.44919-6-pstanner@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240822_074539_795189_526F18F6 X-CRM114-Status: GOOD ( 12.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 22, 2024 at 03:47:37PM +0200, Philipp Stanner wrote: > pcim_iomap_regions() and pcim_iomap_table() have been deprecated by > the PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate > pcim_iomap_table(), pcim_iomap_regions_request_all()"). > > Replace these functions with the function pcim_iomap_region(). ... > - err = pcim_iomap_regions(pdev, 1 << PCI_PTP_BAR_NO, pci_name(pdev)); > - if (err) > + clock->reg_base = pcim_iomap_region(pdev, PCI_PTP_BAR_NO, pci_name(pdev)); > + if (IS_ERR(clock->reg_base)) { > + err = PTR_ERR(clock->reg_base); > goto error_free; > - > - clock->reg_base = pcim_iomap_table(pdev)[PCI_PTP_BAR_NO]; > + } Perhaps clock->reg_base = pcim_iomap_region(pdev, PCI_PTP_BAR_NO, pci_name(pdev)); err = PTR_ERR_OR_ZERO(clock->reg_base); if (err) goto error_free; This will make your patch smaller and neater. P.S. Do you use --histogram diff algo when preparing patches? -- With Best Regards, Andy Shevchenko