From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D27BC3DA4A for ; Thu, 22 Aug 2024 14:52:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8VMegyUtTlW9Ho5duRtKgnmZegSS27g9XEiFgZehnLk=; b=Nlji4Z6taiDN9zwRe9JDQ4qCvv GAr+ZShb11Xkm09FVqCsNBSaMvyG1d7WFkkkrkmk9/GgVJMAsdqtY0CSMtApsvY7H/KvjiEEr41kJ vDFf3WErixigPFKIR1yFky7vwpWzETy5UNW2QhJDx6Zjjqen+3yyuOif/DSZZmR+O6tzIeW+ar+Yx LO2q3ySqk072PVnIUm5h9RYm+kr1JOQdqakXGgATL+/ebcTnN7+hQ6hRnd5Zvn7zm21MG34Ukeein M1YYL1WF4M6jvv4gDOOAn+r07kq33+IZA6BgufrM2rtFr0TGibu19Pr5o3NCbdSQ0kGh1//7dqujj RQHAeucw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh9Af-0000000DEcg-3vRU; Thu, 22 Aug 2024 14:52:17 +0000 Received: from mgamail.intel.com ([192.198.163.14]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh98M-0000000DE2O-2lV0 for linux-arm-kernel@lists.infradead.org; Thu, 22 Aug 2024 14:49:56 +0000 X-CSE-ConnectionGUID: vLEWZUxpS4qmxyBsMlMo4w== X-CSE-MsgGUID: CABa5tZyTyCE3ODeA6+WOw== X-IronPort-AV: E=McAfee;i="6700,10204,11172"; a="22941199" X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="22941199" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2024 07:49:54 -0700 X-CSE-ConnectionGUID: y0FDeu5LQeO4Qzbust16qg== X-CSE-MsgGUID: YMGGdoIlTGS26ZTcm+ckPg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="66149796" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa004.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2024 07:49:43 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1sh97e-00000000U8h-0kBa; Thu, 22 Aug 2024 17:49:10 +0300 Date: Thu, 22 Aug 2024 17:49:09 +0300 From: Andy Shevchenko To: Philipp Stanner Cc: Jonathan Corbet , Jens Axboe , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Linus Walleij , Bartosz Golaszewski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Bjorn Helgaas , Alvaro Karsz , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Richard Cochran , Mark Brown , David Lechner , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Damien Le Moal , Hannes Reinecke , Chaitanya Kulkarni , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fpga@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, virtualization@lists.linux.dev Subject: Re: [PATCH v3 8/9] vdap: solidrun: Replace deprecated PCI functions Message-ID: References: <20240822134744.44919-1-pstanner@redhat.com> <20240822134744.44919-9-pstanner@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240822134744.44919-9-pstanner@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240822_074954_801407_C6445D57 X-CRM114-Status: GOOD ( 13.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 22, 2024 at 03:47:40PM +0200, Philipp Stanner wrote: > solidrun utilizes pcim_iomap_regions(), which has been deprecated by the > PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate > pcim_iomap_table(), pcim_iomap_regions_request_all()"), among other > things because it forces usage of quite a complicated bitmask mechanism. > The bitmask handling code can entirely be removed by replacing > pcim_iomap_regions() and pcim_iomap_table(). > > Replace pcim_iomap_regions() and pcim_iomap_table() with > pcim_iomap_region(). ... > /* Request and map BAR */ > - ret = pcim_iomap_regions(pdev, BIT(snet->psnet->cfg.vf_bar), name); > - if (ret) { > + snet->bar = pcim_iomap_region(pdev, snet->psnet->cfg.vf_bar, name); PTR_ERR_OR_ZERO() ? > + if (IS_ERR(snet->bar)) { > SNET_ERR(pdev, "Failed to request and map PCI BAR for a VF\n"); > - return ret; > + return PTR_ERR(snet->bar); > } -- With Best Regards, Andy Shevchenko