From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74114C52D7C for ; Fri, 23 Aug 2024 06:34:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Nwwa4zZWKWT0C7ngpvIXaYQp8a5Xf4joWxzD56LK+ns=; b=KuswI2WwNugFhHcaUoZsbbuaCM WgXyDwHL80mGHhfBSsnleMhfuT2ZW/3vviB9lKT+PArM0Nq8HDBXx4t+pHv6I75hKVlTWmEtcXz5w BR1ROn0e67HT//EW6C27NBMA3hO1MWPaZ+eP/Dnt7S4SG8mpaoie5nGIXF/KpjlGRBntVwUICd1Lv HHPlF/4Z/2ilPNs9iS57U0bj384N8jSMzqCpgY6Baafl4+rKuNc+FMNpCLNdCyDzxJ933FjzJqLKl fxBFDzygYfnQKoWBiItl8ylUPz5LoOkmLIulQyNqfNmFv/6f6UwbIp6cv0TpQEpQTkSQkgR12e7io lMyrGMGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shNsT-0000000FTOW-3YGp; Fri, 23 Aug 2024 06:34:29 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shNri-0000000FTHT-2W4v for linux-arm-kernel@lists.infradead.org; Fri, 23 Aug 2024 06:33:43 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-428e0d184b4so11456255e9.2 for ; Thu, 22 Aug 2024 23:33:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1724394820; x=1724999620; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Nwwa4zZWKWT0C7ngpvIXaYQp8a5Xf4joWxzD56LK+ns=; b=Xu2Uuk6CTUqfZOeMtT+oqlPVA0h08LCtGhoz8ZXF/c06qsOoz22bf1u99euX2j2jNX gwumriBtgPO0lgvV0XgKkbSCNMIuLsWr5LcnjIs6TJhAK4u82mnPwAszEzCOLxVQ+Yiz iFaUCN4xiawLabXJL2a7o1HK0bZUhjLCVNEhXfnq8n21um2gfq3ITheHrYuQBfR1py6U aWqw4yUiHd5HUnEc4HP/mqPnEuLJKSOWJsw+/HmpwFFIccfa0LolE2vUpMtzOzWFxsZy P4/aCWPK4CQoviZAC79PATqMEQwTluRc8hwTfHR16S+rG0TYCyOxmMokxV5/l1n892LT hxFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724394820; x=1724999620; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Nwwa4zZWKWT0C7ngpvIXaYQp8a5Xf4joWxzD56LK+ns=; b=IvFM2NYtyQ6wY/8CXgyJmZvpPA4wRc6de8Rp8kXWbCxDhVWhj0pXMAFe3VuhZ0FyGh NfQklBoXX34DfGOdoFgSA+0S5s9USCf3IJkxYU3nBBpQuU6r99E/fYmPvdV90ikFV+22 msM7LF5wGdboFgcIo2i6mXRrk7igrJwReHO3ZO39X9EZbQlUn2FtddGzpvpq+bhr4E03 InZTgu8xYSzYzhhJdSlD0M3hCNzh8nycZxk4OkcW6u6gthxAtRvwayaTGgW2DE/5+K8k 7Ij91jhK6gq4W0M2dFKvwGvnq5Fda8gMe6QAHi/txeCIeDXzBrIxykU5NNSvFdPcFbw+ 1O+g== X-Forwarded-Encrypted: i=1; AJvYcCVrb3aK8rWUBoarQm7X+DzdWQ4jcbZDHiI4m5AY5QM+tW8ZyaTLdZGn7vJBk9H/uH0d0X54lqzQ5JeKdvc4+uNA@lists.infradead.org X-Gm-Message-State: AOJu0YzsHj6pxRYRvSh7MubCZ3SU5xsYxQo5kVQFsVW2zqogbgfG08S7 j2w0PwY0g8IvhniAtg58b9FhZYG3WT16A0AFUdbiGscOQOAUbNdT7XkxwAZS+Jw= X-Google-Smtp-Source: AGHT+IE1rLgEUi/E+JRWhk5yegpaazjUMmQ/t/cN3D8r5PCsnRrmCPHJTAiKkoCLeX2MUJRaLJ7WWw== X-Received: by 2002:a05:600c:4e01:b0:426:654e:16da with SMTP id 5b1f17b1804b1-42acd39e07cmr7246735e9.0.1724394820150; Thu, 22 Aug 2024 23:33:40 -0700 (PDT) Received: from sunil-laptop ([106.51.198.16]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42abee8c2dbsm83828835e9.21.2024.08.22.23.33.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2024 23:33:39 -0700 (PDT) Date: Fri, 23 Aug 2024 12:03:25 +0530 From: Sunil V L To: Bjorn Helgaas Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev, Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Rafael J . Wysocki" , Len Brown , Bjorn Helgaas , Anup Patel , Thomas Gleixner , Samuel Holland , Robert Moore , Conor Dooley , Haibo Xu , Andrew Jones , Atish Kumar Patra , Drew Fustini , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= Subject: Re: [PATCH v8 08/17] ACPI: pci_link: Clear the dependencies after probe Message-ID: References: <20240812005929.113499-9-sunilvl@ventanamicro.com> <20240822214415.GA351762@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240822214415.GA351762@bhelgaas> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240822_233342_664794_803D7C4D X-CRM114-Status: GOOD ( 30.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Bjorn, On Thu, Aug 22, 2024 at 04:44:15PM -0500, Bjorn Helgaas wrote: > On Mon, Aug 12, 2024 at 06:29:20AM +0530, Sunil V L wrote: > > RISC-V platforms need to use dependencies between PCI host bridge, Link > > devices and the interrupt controllers to ensure probe order. The > > dependency is like below. > > > > Interrupt controller <-- Link Device <-- PCI Host bridge. > > > > If there is no dependency between Link device and PCI Host Bridge, > > then PCI devices may be probed prior to Link devices. If a PCI > > device is probed before its Link device, we won't be able to find > > its INTx mapping. > > This seems to explain why we want these dependencies, which is useful, > but *this* patch only removes the dependencies. > > Maybe this description should be in the patch that *adds* the > dependencies, e.g., "ACPI: RISC-V: Implement function to add implicit > dependencies"? > Okay. Let me move this to the patch you suggested. > > So, add the link device's HID to dependency honor list and clear the > > dependency after probe is done so that the dependent devices are > > unblocked to probe. > > This still claims this patch adds HID, which I don't think it does. > Please see below. > > Signed-off-by: Sunil V L > > Tested-by: Björn Töpel > > --- > > drivers/acpi/pci_link.c | 2 ++ > > drivers/acpi/scan.c | 1 + > > 2 files changed, 3 insertions(+) > > > > diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c > > index aa1038b8aec4..b727db968f33 100644 > > --- a/drivers/acpi/pci_link.c > > +++ b/drivers/acpi/pci_link.c > > @@ -748,6 +748,8 @@ static int acpi_pci_link_add(struct acpi_device *device, > > if (result) > > kfree(link); > > > > + acpi_dev_clear_dependencies(device); > > + > > return result < 0 ? result : 1; > > } > > > > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > > index 28a221f956d7..753539a1f26b 100644 > > --- a/drivers/acpi/scan.c > > +++ b/drivers/acpi/scan.c > > @@ -863,6 +863,7 @@ static const char * const acpi_honor_dep_ids[] = { > > "INTC10CF", /* IVSC (MTL) driver must be loaded to allow i2c access to camera sensors */ > > "RSCV0001", /* RISC-V PLIC */ > > "RSCV0002", /* RISC-V APLIC */ > > + "PNP0C0F", /* PCI Link Device */ This is the change which I meant adding HID to the honor list. Do you recommend to make this change separate patch so that it doesn't confuse with adding a new HID to the probe match table? Thanks! Sunil