From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7AE5AC531DC for ; Fri, 23 Aug 2024 13:50:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QwrD/lbeRNRzoVUmgjpRWde1MN0URKCkPBQFtW3a+vw=; b=o669DHv92EKIunGcatmddvDOup W1KsgNUNru1gNGkwc/RTzTi4ssHMU7POn7SX/vzB5DaIJHky/6opsfZjrvEhvXy6fJSn6Zg9S8Zva v73aSVIZELw95qNo4dTsGqacwzS/GNAYQq25JbmOgd4lYHozhcgOTnFX1cRntk+240di1BVWCdubQ 2qOiykx7eQJC5latl6nfx7wW4Ma7qFCQQhu29EGWNraLIQUKUwyfkXhq0WzzusFYfaZGipayVe1ml cptWKm0TJNTUO4lmQBc69FCCPVksL4t1tbXC8CmoAYQ7wgKBNXnEB/ZBe7YKTELU8GxsyuC7hsZGN tiw2VcWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shUfq-0000000GwbF-2Z5U; Fri, 23 Aug 2024 13:49:54 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shUea-0000000GwIL-1q9r for linux-arm-kernel@lists.infradead.org; Fri, 23 Aug 2024 13:48:37 +0000 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5bef295a2b4so3286879a12.0 for ; Fri, 23 Aug 2024 06:48:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724420914; x=1725025714; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QwrD/lbeRNRzoVUmgjpRWde1MN0URKCkPBQFtW3a+vw=; b=N1tiCMBmU2xzbyYHu+PJz6BBxxEl8LOVBN/Qy2ZXqyOEQEkAF0OtGcer40ecuqnHMr rfq9ZG3dVuQ4sxcM9f7BeVZi96vQHTPwVKGH6sFLaLHMy9kjr9swmclcSMJe5DICO2WW QqY4yv2HOkx4ic/m/s+31P7lOzGlLqwGPfpJZSUUZOMYzZ0UJIuWedXdniyUAmtHuZ6p WWEZu/OzXCsNEENQ2cjf+laWCPixB6+KLGGkj8qK/Anr3pUU3HFukIi70/uUmey/1FmR vL3DOYwO/hREKjH5jonxgrQbU0MFymuqyg7yAQj7Y2enfTn+pw0yXX8C+4NztrBptTTt MgOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724420914; x=1725025714; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QwrD/lbeRNRzoVUmgjpRWde1MN0URKCkPBQFtW3a+vw=; b=Cpus5QoMfv/YKp7Ypg6Q9C1jPO6SheOFs4owWuQWhQYoVqRUcNbzQJlTwrAbFpHC+h tyRlH/6FjIW8QjNTSdxYGyWMvqZjoePP0ynYUSIbS74+lRumxI1TEpTyYWwRnfhIZspF uMvpZ3Lx3lUBAnyZvI4bye/Te32xfuvjCFFrkwDLB1c1QJxLoc1Wi6TMAUmXwhMdyVf1 wJJ076dXyzyTBS7IU1r7podzbUXZwxKggK3bbiaBRjzRlGrzL3ZdzoT5gAwyxr83LZrC dU53hnl4LUDpjKXieas6fyLcw7xMrVCtbhRpGgaK15TzSeFbHex6cbREZI5XH+Dhw59y HLMg== X-Forwarded-Encrypted: i=1; AJvYcCVXBfRJUgsX/b4Q6hGwQocmsZsWy2ak90RcoAgWAa8BgR0shbgZfBdPUweEnse40CF1mGoepZEA1s1hk7rAsUkb@lists.infradead.org X-Gm-Message-State: AOJu0YyW+IY3jrAvqgz/nqWoK9M0hrQWjYvKDdbTpxNOK5x7q6Bx7e1Q JF1xCdRg211lQZDte/m2eQrEFqJ7H1OdK3HKnWBv5auP+uReTDSJ X-Google-Smtp-Source: AGHT+IHd2Dy4icrEZJ3J8EXqviPjWTYhwIADABNxwIWTMxUTKe6s4D9yDboiSs3kZIrTIP397YtD6A== X-Received: by 2002:a05:6402:35ce:b0:5c0:8ff8:d7da with SMTP id 4fb4d7f45d1cf-5c08ff8d8d6mr325127a12.12.1724420913934; Fri, 23 Aug 2024 06:48:33 -0700 (PDT) Received: from eichest-laptop ([2a02:168:af72:0:48ba:80d8:cf77:1f49]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c04a4c438fsm2110850a12.61.2024.08.23.06.48.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Aug 2024 06:48:33 -0700 (PDT) Date: Fri, 23 Aug 2024 15:48:32 +0200 From: Stefan Eichenberger To: Andi Shyti Cc: Oleksij Rempel , kernel@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, Frank.Li@nxp.com, francesco.dolcini@toradex.com, linux-i2c@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stefan Eichenberger , Krzysztof Kozlowski Subject: Re: [PATCH v2 1/4] i2c: imx: only poll for bus busy in multi master mode Message-ID: References: <20240819072052.8722-1-eichest@gmail.com> <20240819072052.8722-2-eichest@gmail.com> <2bbddaxyjkxfmlgmq3yqcbzo7dsb2pq5bvdatk2y4ig4iintkt@35btqkdv7sy3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2bbddaxyjkxfmlgmq3yqcbzo7dsb2pq5bvdatk2y4ig4iintkt@35btqkdv7sy3> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240823_064836_500828_61F34FF8 X-CRM114-Status: GOOD ( 26.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andi, On Fri, Aug 23, 2024 at 02:35:54AM +0200, Andi Shyti wrote: > Hi, > > On Thu, Aug 22, 2024 at 12:04:43PM GMT, Oleksij Rempel wrote: > > On Thu, Aug 22, 2024 at 09:03:55AM +0200, Stefan Eichenberger wrote: > > > Hi Andi, > > > > > > On Thu, Aug 22, 2024 at 12:21:30AM +0200, Andi Shyti wrote: > > > > Hi Stefan, > > > > > > > > > @@ -1468,6 +1473,8 @@ static int i2c_imx_probe(struct platform_device *pdev) > > > > > goto rpm_disable; > > > > > } > > > > > > > > > > + i2c_imx->multi_master = of_property_read_bool(pdev->dev.of_node, "multi-master"); > > > > > + > > > > > > > > you might also want to add the multi-master boolean property in > > > > the binding. > > > > > > We discussed this internally and weren't sure when it was required > > > because e.g. i2c-rcar and i2c-tegra don't have it documented in their > > > bindings. Is it still required if it is part of the dt-schema? > > > https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/i2c/i2c-controller.yaml > > > > The i2c-imx.yaml has "unevaluatedProperties: false", which fill discard > > every thing not in this yaml > > > > > If so, I will add it in the next version. > > > > Yes, please. > > sorry for the confusion, please don't add it. I had a chat with > Krzysztof and I will quote him: "this is a core property, coming > with dtschema, so they dont need to update bindings". > > He also sent a cleanup to remove the only binding using it. No problem, thanks for the clarification. Should I still separate the multi-master patch from the rest of the series, even though it doesn't seem to fix the problem Fabio sees? I did some more testing today and the workarounds he found do not solve the problem I see, so they are definitely not the same. Regards, Stefan