From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5836EC531DC for ; Fri, 23 Aug 2024 14:45:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LV5pX2MG/y9Od0ZypEKmss4zCvIjkPOalHMBZaJ1+Ug=; b=Om+s2mCEhcL4uS3DMYnUokR3O/ K69ojPI+FDBaAAN6Svh5cJie/GJhRCxDNQeXbM8PQ+nJoI6GcAkN+D3CPXuTembJfDluHSkIrmfsg Pgh31Cg7FteL/Hse+taiigTHbTmMrn4cAc0OeFDNxGbdGXSd6ssdE4bcSGtyUosvLoamzEbC2Ka7h e3R+oTT8j4rJ2e7DJ0ymE0ndt3UT1Qh0ekC0YSHjLPkICgQijkj77wWvIqJtYnhSNoMh1RwBWbZtW jJRLMAbdBsHcl8HfNabkn73i3E0aFgrTDTvojjt6oV0i/gxZVZDAbQOs2k2DWPQWg6OAnJHyA1VN0 DFRvrHag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shVXQ-0000000H9RD-154j; Fri, 23 Aug 2024 14:45:16 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shVV3-0000000H95p-05T9 for linux-arm-kernel@lists.infradead.org; Fri, 23 Aug 2024 14:44:30 +0000 Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-5becfd14353so2403852a12.1 for ; Fri, 23 Aug 2024 07:42:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724424167; x=1725028967; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LV5pX2MG/y9Od0ZypEKmss4zCvIjkPOalHMBZaJ1+Ug=; b=UL1kymUvrMWN50mgV38SCm0aNwx11xlSckhfsY3vV4e+bQpfRTP7p98jDiDj4tglF3 w5aBjA+bjkxw8pqhZElQVVwI8ZRcb53Jnwvb38g74o9gWDcddxe7My/r8TvkfsPQt913 5zvIOfh/pIOAREkZ7Sx848cGgpzK6m8o76mlrI4eYwyhjEmfzxM11IypSRoH2jG0QUGV q8w5yivoUrEdXZRsGBrg+13ZkQE7rT5gTrgqAdYFlzfte29J/GFPXL1/TG7X1dtfehpH 2hXULUgh+M0Xll/OREiO5i7O73Oj/KxY9x+efl4QUtuwbvI/+020WfjBsxPZmKWGqw+R xf/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724424167; x=1725028967; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LV5pX2MG/y9Od0ZypEKmss4zCvIjkPOalHMBZaJ1+Ug=; b=EbzBRc6FESaXVsznXUkMk6raqbsAexwStCTNRs+DEzsbF8fvI4tUX29a8bvSRFrTfv a/qt/v06chO+146jFg6N0pMpZH2ok6ZpTs6dozgkybre3m4QVo5lOocYb4tQUqGMstO6 3zfAZo4FZQ8aw0QYrK0QU8i3hKSRYT8J7RIuKD/8OxltbHQHXo42dMBrPKTzQP3DUYcK Wo5YOLSS5NeRbUJociL45/ZrkmQHTg6o7RUVnU57A1XYlB0BgsT98j5lxyLupSRlFmzK D3miY5c8uM21Vq3+iGrtfNkan/8BSceVKWK+1BvKh+mlFM9Y+2Gsp9qDIMs4aXcoM+3M SBLQ== X-Forwarded-Encrypted: i=1; AJvYcCXmNxMpKs3ZpblZ4YCpcMi9YC7tuSYM2g/RpASeAmp3hTJasnefguwrSpVKc1QhwRbHHLIh6cMuaBSsL9aC26W/@lists.infradead.org X-Gm-Message-State: AOJu0YwuflYgBQJoA7GbrYF6W/mJSmJxaPzMyDb7nJaksscM5yzIN7Mn 1NVSOI+LvOAmNcl2jAGlPsNrXYPWnq5+fNORMoXfNm7v/cnUaNwsAdvdi1kc X-Google-Smtp-Source: AGHT+IGwetwCqXvv36+SgUec6tmmzyF7k13urczzdeBDsGK/FPZM9wWzm9eMTCI/L76tBdldq1w91w== X-Received: by 2002:a05:6402:278e:b0:5bf:257f:9ee5 with SMTP id 4fb4d7f45d1cf-5c0891a97f4mr1705242a12.34.1724424166808; Fri, 23 Aug 2024 07:42:46 -0700 (PDT) Received: from eichest-laptop ([2a02:168:af72:0:48ba:80d8:cf77:1f49]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c04a4c6ce9sm2169541a12.72.2024.08.23.07.42.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Aug 2024 07:42:46 -0700 (PDT) Date: Fri, 23 Aug 2024 16:42:44 +0200 From: Stefan Eichenberger To: Oleksij Rempel Cc: Andi Shyti , kernel@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, Frank.Li@nxp.com, francesco.dolcini@toradex.com, linux-i2c@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stefan Eichenberger , Krzysztof Kozlowski Subject: Re: [PATCH v2 1/4] i2c: imx: only poll for bus busy in multi master mode Message-ID: References: <20240819072052.8722-1-eichest@gmail.com> <20240819072052.8722-2-eichest@gmail.com> <2bbddaxyjkxfmlgmq3yqcbzo7dsb2pq5bvdatk2y4ig4iintkt@35btqkdv7sy3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240823_074249_157762_873D2935 X-CRM114-Status: GOOD ( 30.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Oleksij, On Fri, Aug 23, 2024 at 04:04:58PM +0200, Oleksij Rempel wrote: > On Fri, Aug 23, 2024 at 03:48:32PM +0200, Stefan Eichenberger wrote: > > Hi Andi, > > > > On Fri, Aug 23, 2024 at 02:35:54AM +0200, Andi Shyti wrote: > > > Hi, > > > > > > On Thu, Aug 22, 2024 at 12:04:43PM GMT, Oleksij Rempel wrote: > > > > On Thu, Aug 22, 2024 at 09:03:55AM +0200, Stefan Eichenberger wrote: > > > > > Hi Andi, > > > > > > > > > > On Thu, Aug 22, 2024 at 12:21:30AM +0200, Andi Shyti wrote: > > > > > > Hi Stefan, > > > > > > > > > > > > > @@ -1468,6 +1473,8 @@ static int i2c_imx_probe(struct platform_device *pdev) > > > > > > > goto rpm_disable; > > > > > > > } > > > > > > > > > > > > > > + i2c_imx->multi_master = of_property_read_bool(pdev->dev.of_node, "multi-master"); > > > > > > > + > > > > > > > > > > > > you might also want to add the multi-master boolean property in > > > > > > the binding. > > > > > > > > > > We discussed this internally and weren't sure when it was required > > > > > because e.g. i2c-rcar and i2c-tegra don't have it documented in their > > > > > bindings. Is it still required if it is part of the dt-schema? > > > > > https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/i2c/i2c-controller.yaml > > > > > > > > The i2c-imx.yaml has "unevaluatedProperties: false", which fill discard > > > > every thing not in this yaml > > > > > > > > > If so, I will add it in the next version. > > > > > > > > Yes, please. > > > > > > sorry for the confusion, please don't add it. I had a chat with > > > Krzysztof and I will quote him: "this is a core property, coming > > > with dtschema, so they dont need to update bindings". > > > > > > He also sent a cleanup to remove the only binding using it. > > > > No problem, thanks for the clarification. > > > > Should I still separate the multi-master patch from the rest of the > > series, even though it doesn't seem to fix the problem Fabio sees? I did > > some more testing today and the workarounds he found do not solve the > > problem I see, so they are definitely not the same. > > I'll try to review your DMA patches next week. Perfect, thank you, no need to hurry. Regards, Stefan