From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ABD22C52D7C for ; Fri, 23 Aug 2024 14:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IJV6+x8H7MHWBw1YLFKzqVlTUlhyTBZFthiAD4vkgiM=; b=HCagjfL9p6NB0wn8L/6yLdJJba FotuqOMsJnyjH2/m5QXQoC3g4u2S7hmMuZ/BdCFf2t8UFYZqCzGn51pGtrfpI/OJazCQ3IvrSFGfj yl21WrQNvUiHHScni5hD1rVWioP3airPjrbx47cx7sKwqV0aYv9g7rePW/od3CrUTM2FgrJWsKfV4 NdX1Qx0eHDhq95wX7ybFfEonKNpt5WQ2sNxdBg3COjdYDxLRJ+a3mrS7mjpVRlFrADYg3wXjIIi9j NFcyp4kyuWyQJf8iGiTu/Um4fht4g8GTqV4UJnTvrVeZCpfVIupdrJ5bkdou0aDDK/XgH1LQ9etAj oqco9V5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shVc6-0000000HAXR-0jGL; Fri, 23 Aug 2024 14:50:06 +0000 Received: from mgamail.intel.com ([198.175.65.21]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shVbL-0000000HAR2-3KzB; Fri, 23 Aug 2024 14:49:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724424560; x=1755960560; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=F1xamHkmCiWIgbmGDKsQayOzdfeCChJxTzpDnXIDvGc=; b=YKcLg4V4c9ODGwRoGOUhbwZBFyXMJ1bdIaDsZ1RcCPEYx3JRFphZF6Oe 9U+Go8yuLpynjUuFesM29PT2BDQwt9Gn4EJgvzMw3I7M/abRDl3mNhnmn d2wncx6ui1MJpxRDmDbFfC4bDpus4cJJ8BG6AKlauW379qCJU0IALgSCH YKRgzRwhjin03NOn8uddI0cjxwKYbpCa0eHk0ucdQeoZ5SWAx0udVCmUF EITDm1oCicl1bcg71nnMRcQjDXBtdujJ/QiRbtKzx/H3ZvuRRkkAhQTyo /qL63W6fNeM+7/+cOlTPq+ExHuMx270hheyT1mVTvqSkixUYZL7RjLP5q A==; X-CSE-ConnectionGUID: QfsDeUigQUqN3JtjJ3LYRw== X-CSE-MsgGUID: jOL9eravS3qUrtD5xd7fIw== X-IronPort-AV: E=McAfee;i="6700,10204,11172"; a="22861435" X-IronPort-AV: E=Sophos;i="6.10,170,1719903600"; d="scan'208";a="22861435" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2024 07:49:19 -0700 X-CSE-ConnectionGUID: NnZPkaVTTAa4ZTeJQ8odGw== X-CSE-MsgGUID: RN6n3lZNRiCpKSvSSGi7Cw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,170,1719903600"; d="scan'208";a="92611103" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2024 07:49:15 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1shVbF-00000000pFB-1A2I; Fri, 23 Aug 2024 17:49:13 +0300 Date: Fri, 23 Aug 2024 17:49:13 +0300 From: Andy Shevchenko To: Shawn Lin Cc: Ye Zhang , linus.walleij@linaro.org, brgl@bgdev.pl, heiko@sntech.de, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, mika.westerberg@linux.intel.com, tao.huang@rock-chips.com, finley.xiao@rock-chips.com, tim.chen@rock-chips.com, elaine.zhang@rock-chips.com Subject: Re: [PATCH v2] gpio: rockchip: resolve overflow issues Message-ID: References: <20240823034314.62305-1-ye.zhang@rock-chips.com> <20240823034314.62305-4-ye.zhang@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240823_074919_903628_CE797F32 X-CRM114-Status: UNSURE ( 6.81 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 23, 2024 at 06:59:40PM +0800, Shawn Lin wrote: > 在 2024/8/23 11:43, Ye Zhang 写道: ... > > - max_debounce = (GENMASK(23, 0) + 1) * 2 * 1000000 / freq; > > + div = (u64)(GENMASK(23, 0) + 1) * 2 * 1000000; > > + max_debounce = DIV_ROUND_CLOSEST_ULL(div, freq); > > can't max_debounce = DIV_ROUND_CLOSEST_ULL((GENMASK(23, 0) + 1) * 2 * > 1000000, freq) work? Wouldn't be too long line in this case? -- With Best Regards, Andy Shevchenko