Re: [PATCH v3 1/4] soc: ti: pruss: factor out memories setup

[Kousik Sanagavarapu <five231003@gmail.com>]

On Sat, Aug 24, 2024 at 01:49:50PM -0500, Nishanth Menon wrote:
> On 10:44-20240707, Kousik Sanagavarapu wrote:
> > Factor out memories setup code from probe() into a new function
> > pruss_of_setup_memories().  This sets the stage for introducing auto
> > cleanup of the device node (done in the subsequent patch), since the
> > clean up depends on the scope of the pointer and factoring out
> > code into a seperate function obviously limits the scope of the various
> typo s/seperate/separate - use --codespell with checkpatch to catch :)
> 
> A follow on patch has the same problem as well.

Oh, yes should've used --codespell, my bad.  Thanks for spotting.

> > variables used in that function.

[...]

> > -	of_node_put(child);
> > +	ret = pruss_of_setup_memories(dev, pruss);
> > +	if (ret < 0)
> > +		goto rpm_put;
> 
> Why? We have not called pm_runtime_enable at this point.

Didn't catch this too, will change.

Thanks