From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C35DC5321E for ; Sun, 25 Aug 2024 06:39:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EnWipGSGRNUpxTH706hRTY90cJiU4b+kfr2jSKM5g/s=; b=qnJyH11ELPDi53wN0K9bCAIafB S4q996V/bDammoXyXUIJdB7Xaxdtzr6t5I8iNqckcm2dlRA8D8GjKv4I5aoWNCfwK2Rp72Kf8VhdN mb/lbjVx9OHGyVuviT5fJmbQ/jrBquHhqqrMi5VlJWGOYXegI5OrxjhFSaBHOC+sSt8VNhAAKQfLE hp0v87qwqwGlp1NpMqosnFKMzalbvjwPjRIi3d9nbPDseH2uERVL+69xxXon5WBuuwo6uVV2nogT7 SkKyGXmVbc2m+9QmjlcimZqQvqBNqfhIP03InmeKFFc2cI7RdwR/TcV4nzz/t0yIfd7qw6ifeAWYo gELQ2Xpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1si6uK-00000003nBa-1weF; Sun, 25 Aug 2024 06:39:24 +0000 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1si6tY-00000003n5o-2LKv for linux-arm-kernel@lists.infradead.org; Sun, 25 Aug 2024 06:38:37 +0000 Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-7141e20e31cso2797318b3a.3 for ; Sat, 24 Aug 2024 23:38:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724567915; x=1725172715; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EnWipGSGRNUpxTH706hRTY90cJiU4b+kfr2jSKM5g/s=; b=mDI1vIGzOlLQXnnjFOpxh9qMiIuHE/ARRboG52qOJ1M86a91yqajxJ9NnAPoWahgyi xQb8PJ6JTjdZDUbxe8+n5AvluX4ZDdj/W1Nk1lsPAaTM25lYp8BOt1Kp6lJnEy9mHhks ulQ/ZsfshtAXL5l5kF5L/zQxy6Fv5I4DyqJNR4fTEyR5VSpgr9YqrKgTgigT679asBNe N0ICLoh36V2noxmSsoI2PCypchDqii2bD2qQlCVRpeS+6sT+hnS8AXjDkc9TwEbg36OO 5B0A1yTWoAYuMNjCxjH5JhyFXdRiVCUyBJTKHq/pLLDNh/1Zre1t7ZkcDln7U1DW3vbt laRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724567915; x=1725172715; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EnWipGSGRNUpxTH706hRTY90cJiU4b+kfr2jSKM5g/s=; b=eJqdv0JJiKQT7iEdlzwuCoRXiTiWAkcG+boXHTYDNJFUy8W4waHuA4slsiGAx/Is1b NGnmoRn2GZGdCksexWe+XtkSFVXL4jInABSvR54yN9D960MUrjRRd6e7ceIWornvHkt+ 8a2fRbKniWUnvLwXwZZ/RTILwHPQvVtP95jqbp1D6RptleeNorBb0oAkFYapTsChOq0a mZtsGj4feXnyzz7yIJHvO/mM26v+Vm6PthodqcqfcxC07Z5f7LsK2LnCauTWA4u9Vkqb SH+Hr1Zjh3uCNfrKSPjKazoApLqVASXQH0O71dMbWxZAbmT4og5q0eNhFKiQ+AIZafMX AADg== X-Forwarded-Encrypted: i=1; AJvYcCX0O2UAtDpcjgFsW9yVn2/LX2Rlcn/0xwy4x/MWMM5z+vbTLc4l7t02PECQUK6EV1CCR+SiSMBEa/Flj/2jRWZG@lists.infradead.org X-Gm-Message-State: AOJu0YxcqwEv3wm6ZMPcHmKcI8DcXJhs+xR7UbRoqswEbd1mP6ezPgEz ukcIxhl/cpo2Rkqqf4RzBU/hAX+o9B8GNXDq4Kzjn8Eor3xnTfYum+vpUZ0Q X-Google-Smtp-Source: AGHT+IETSpALFu2+A7eFzubBAgBvk/KzvFDhLlTmDgXtMQ3q7/INDCIeOJBXA4FjqYO6SRjgZntLJw== X-Received: by 2002:a05:6a20:c793:b0:1bd:feed:c031 with SMTP id adf61e73a8af0-1cc89d80195mr7497177637.28.1724567914814; Sat, 24 Aug 2024 23:38:34 -0700 (PDT) Received: from five231003 ([2405:201:c006:3236:b871:d8f1:d936:dc0c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2038560e3e8sm49676505ad.219.2024.08.24.23.38.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Aug 2024 23:38:34 -0700 (PDT) Date: Sun, 25 Aug 2024 12:08:28 +0530 From: Kousik Sanagavarapu To: Nishanth Menon Cc: Jonathan Cameron , Santosh Shilimkar , Nathan Chancellor , Julia Lawall , Shuah Khan , Javier Carrasco , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 1/4] soc: ti: pruss: factor out memories setup Message-ID: References: <20240707055341.3656-1-five231003@gmail.com> <20240707055341.3656-2-five231003@gmail.com> <20240824184950.gzsgdawt2ujjt6ky@subgroup> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240824184950.gzsgdawt2ujjt6ky@subgroup> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240824_233836_637878_1700D970 X-CRM114-Status: GOOD ( 17.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Aug 24, 2024 at 01:49:50PM -0500, Nishanth Menon wrote: > On 10:44-20240707, Kousik Sanagavarapu wrote: > > Factor out memories setup code from probe() into a new function > > pruss_of_setup_memories(). This sets the stage for introducing auto > > cleanup of the device node (done in the subsequent patch), since the > > clean up depends on the scope of the pointer and factoring out > > code into a seperate function obviously limits the scope of the various > typo s/seperate/separate - use --codespell with checkpatch to catch :) > > A follow on patch has the same problem as well. Oh, yes should've used --codespell, my bad. Thanks for spotting. > > variables used in that function. [...] > > - of_node_put(child); > > + ret = pruss_of_setup_memories(dev, pruss); > > + if (ret < 0) > > + goto rpm_put; > > Why? We have not called pm_runtime_enable at this point. Didn't catch this too, will change. Thanks