From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84789C5321D for ; Mon, 26 Aug 2024 09:08:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:Date:From:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UqD5UWcEcVPtLKNughX5xFAsztARfJbyIdaLj7krJ48=; b=ozRQyRkb0o48YXcfJ909bHvv6+ 5SiLXk+RbAfg9I0tdiadfFitd0hNiYsJ2DOuUTxxcTipaxq4C7YdT0J4v22JOPJAfNxQQt4oktRuh /lDstA8Ntq/Wlx0dactmP0lxXEMx8qyekXD7jYORViTu64LN79z0dDuGpvx3DdlJbrEY2hzcwb2CX Oh+xyzKPXYD2ZMRdCLqaObQAk3XllTFYyf0ZNmr/GJCwOgDKI7MKxQ1Jrh18rB7VrM4s2wiQid4Vq otBXYxGpRdOhXdF7//dJuetHu0Nr2eP0sB7pqiPjMasQwlCw7c762u0SSFPs/r7Nzw+Vcl6+eOIdX 24lyPaPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1siVi0-00000006beB-0C23; Mon, 26 Aug 2024 09:08:20 +0000 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1siVhC-00000006bRB-1xHt for linux-arm-kernel@lists.infradead.org; Mon, 26 Aug 2024 09:07:32 +0000 Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2f3f163e379so64275191fa.3 for ; Mon, 26 Aug 2024 02:07:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724663248; x=1725268048; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=UqD5UWcEcVPtLKNughX5xFAsztARfJbyIdaLj7krJ48=; b=BZm3oMpsOY+7zydiYjgbKvl70FotdzR6mFSSei1SshV1M1DaL7Bkb/HfxXul7YcwQV /FVfRyKik2toHQjY6Bb+lK+6SD4/OfwsdzpGVtpkDzlBbBKYglbHtv6yyItSEsjLaLF1 /XV0Fth0u8cL75cuuAthX/NNmaDQ3mMCr1heoLXDSKLMRuiV9zadi2iYDSBzNbIiYbZC d9rWMp3dmr2gfqRbc6NeRHv6GLbp01N3XJBR783xbTMZ/Xgs+jro1uGfssa0T8goBrcR zs0Hjicoh79GsbJo0bQ582ZGZGWXHYjZwNynjVgPOxOPPwLEM6VTxTd0A1+Hfzdu9nXK cFSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724663248; x=1725268048; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UqD5UWcEcVPtLKNughX5xFAsztARfJbyIdaLj7krJ48=; b=K5evkIrWJAjn/NuyYtj9nmfp9O+4jWguS2tZoxT5kHo28M/rANezymSi8bbSxh/sdX +kp4WsnZwr+swlouiXWwkNXgGKXp/3mOI2W6KR2/Ipd/U58WJc9cGLvTWi6yQCKWitb3 CbYjFGi4tb3E649ecUVxlIy+d+AcfQS6fJimPEGuBJyw2yW11YFZJkTBABFUsABniol/ 60DGreomvkPzcstQx4rr45NDJRP1m4RlhAB7pJcNV9d598tW4r0+KRcVeNuLSngTQiFs rXWeWrAXXl2KhQwzpNPr5yYvyeXt56gmcZlDxHPBLX4mlwbIaYH+UDh/ffdDikuil0uz 6Wiw== X-Forwarded-Encrypted: i=1; AJvYcCX+KPdLz8tdmqjzalD9NQfrH2IaahRKCp7dEM7DsoxwNXQi4acGLDMD2mrBQIy3JW+1Eg8zqLJHHzxcwFCkNxs0@lists.infradead.org X-Gm-Message-State: AOJu0YzYC0nkXG9IAIERn7Ec1mra2d2wmmbbkfSJhHF0+7VD+6XR0V+P djazL971tF6jj/kNeMWqoVakwRAua8DnnOF7qWHyDPHpif19I86a50HL4s5K7Wo= X-Google-Smtp-Source: AGHT+IEK0yN2RYKBDuaStUQnXKZRjXxJWE9pErYm6IieseugH4NhuZzdiuxipurv3igkJJwF0aMRAw== X-Received: by 2002:a2e:b892:0:b0:2f3:cf43:c2a8 with SMTP id 38308e7fff4ca-2f4f579e8eamr76624181fa.42.1724663247306; Mon, 26 Aug 2024 02:07:27 -0700 (PDT) Received: from localhost ([87.13.33.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a868f2205e1sm652753666b.12.2024.08.26.02.07.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Aug 2024 02:07:26 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Mon, 26 Aug 2024 11:07:33 +0200 To: Greg Kroah-Hartman Subject: Re: [PATCH 08/11] misc: rp1: RaspberryPi RP1 misc driver Message-ID: Mail-Followup-To: Greg Kroah-Hartman , Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Linus Walleij , Catalin Marinas , Will Deacon , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Nicolas Ferre , Claudiu Beznea , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Saravana Kannan , Bjorn Helgaas , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, Lee Jones , Andrew Lunn , Stefan Wahren References: <5954e4dccc0e158cf434d2c281ad57120538409b.1724159867.git.andrea.porta@suse.com> <2024082420-secluding-rearrange-fcfd@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2024082420-secluding-rearrange-fcfd@gregkh> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240826_020730_530166_30EE70F7 X-CRM114-Status: GOOD ( 17.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Catalin Marinas , Michael Turquette , Claudiu Beznea , Eric Dumazet , Dragan Cvetic , Will Deacon , linux-clk@vger.kernel.org, linux-arch@vger.kernel.org, Rob Herring , Florian Fainelli , Lee Jones , Saravana Kannan , Broadcom internal kernel review list , linux-pci@vger.kernel.org, Jakub Kicinski , Paolo Abeni , Linus Walleij , devicetree@vger.kernel.org, Conor Dooley , Arnd Bergmann , linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Bjorn Helgaas , Andrea della Porta , linux-arm-kernel@lists.infradead.org, Derek Kiernan , Stephen Boyd , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Krzysztof Kozlowski , "David S. Miller" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Greg, On 09:53 Sat 24 Aug , Greg Kroah-Hartman wrote: > On Tue, Aug 20, 2024 at 04:36:10PM +0200, Andrea della Porta wrote: > > --- a/include/linux/pci_ids.h > > +++ b/include/linux/pci_ids.h > > @@ -2610,6 +2610,9 @@ > > #define PCI_VENDOR_ID_TEKRAM 0x1de1 > > #define PCI_DEVICE_ID_TEKRAM_DC290 0xdc29 > > > > +#define PCI_VENDOR_ID_RPI 0x1de4 > > +#define PCI_DEVICE_ID_RP1_C0 0x0001 > > Minor thing, but please read the top of this file. As you aren't using > these values anywhere outside of this one driver, there's no need to add > these values to pci_ids.h. Just keep them local to the .c file itself. > Thanks, I've read the top part of that file. The reason I've declared those two macroes in pci_ids.h is that I'm using them both in the main driver (rp1-pci.c) and in drivers/pci/quirks.c. I suppose I could move DECLARE_PCI_FIXUP_FINAL() inside rp1-pci.c to keep those two defines local, but judging from the number of entries of DECLARE_PCI_FIXP_FINAL found in quirks.c versus the occurences found in respective driver, I assumed the preferred way was to place it in quirks.c. Many thanks, Andrea > thanks, > > greg k-h