From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82BF8C5321E for ; Mon, 26 Aug 2024 10:04:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kAkUdDtZJJGYjLMMnRCnK4sRRBLRx1nib4NAFhH5o0E=; b=Rz9EG32qwj2lpF5avgiL8A0wtC 9rofQkMY7k6xlELi1FRAzRrWBRql82uo8ZQqHBuleSe83Ky7KWQqn5EBMG9v4THIyo3iWTuWeSGlv T8RE+9V6OS9sPJH4GkVSYCkbHPc3IxnobFalf96Svtp36ndm3uJpqOQNkLMOKnxfDXc3qT++qL+Va V6qV+FtepP7erSWI5miSgwAlCS0W00mrR2Eh4Z1ERJrNax82fyu/KMq4hdKkWhcvg9rgySXsXUSZ7 pDQBJayo5+rja2344av4nh2CBeRjfo5kOYn6NIsmkFk+R6MEdD5J4GR98sBsG0gECUmaJub2k6ojT OD2bQXpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1siWaa-00000006q4V-1kjE; Mon, 26 Aug 2024 10:04:44 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1siWZA-00000006peH-2moL for linux-arm-kernel@lists.infradead.org; Mon, 26 Aug 2024 10:03:18 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id E2D41A41D89; Mon, 26 Aug 2024 10:03:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10508C51407; Mon, 26 Aug 2024 10:03:10 +0000 (UTC) Date: Mon, 26 Aug 2024 13:03:19 +0300 From: Catalin Marinas To: Steven Price Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Gavin Shan , Shanker Donthineni , Alper Gun , Jean-Philippe Brucker Subject: Re: [PATCH v5 04/19] firmware/psci: Add psci_early_test_conduit() Message-ID: References: <20240819131924.372366-1-steven.price@arm.com> <20240819131924.372366-5-steven.price@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240819131924.372366-5-steven.price@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240826_030316_787036_B915D7F2 X-CRM114-Status: GOOD ( 13.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 19, 2024 at 02:19:09PM +0100, Steven Price wrote: > From: Jean-Philippe Brucker > > Add a function to test early if PSCI is present and what conduit it > uses. Because the PSCI conduit corresponds to the SMCCC one, this will > let the kernel know whether it can use SMC instructions to discuss with > the Realm Management Monitor (RMM), early enough to enable RAM and > serial access when running in a Realm. > > Signed-off-by: Jean-Philippe Brucker > Signed-off-by: Steven Price On the code itself: Reviewed-by: Catalin Marinas However, Will has a point and it would be good if we can avoid this early setup as much as possible. If it's just the early console used for debugging, maybe just pass the full IPA address on the command line and allow those high addresses in fixmap. Not sure about the EFI map. -- Catalin