From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20BEAC5321E for ; Mon, 26 Aug 2024 10:43:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fWfHefVtFQlwVhk90XVUP9JVuQoCr2dld8kqfnUw96A=; b=n0CrBIJIuu9WR7jUcNntlfGVIH H/nmJN/SXXlg0x4QCWEohbPSZa70SffaHmNPcrjw9G+qQrRpSRBxzIogH/tLBDbZ6eDH9qCy5KwNk t9vGr1slV4/V9+VwYaD92/AkzwWWbzddmwoQAh//mXtbT9+4QdaWPAJxqmxZeBWy5fqKbn9ei9myw 75kJj5d3bb1EehnifMU55UBknNJcHBRm3IN2jMKy5QOAsbPlZqpdAK4zo8KLR/Ydswu724mO6irjR zQ4jCc0YItsd8PSBmlQEfdKoVl0CgFxTc5rS+oEE5xG93EZ/m+/QQD5ObAmkdvXyobx7vLI2ajmY/ QmaHyptQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1siXBf-00000006ynF-3Xe3; Mon, 26 Aug 2024 10:43:03 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1siXAQ-00000006yP5-0jl3 for linux-arm-kernel@lists.infradead.org; Mon, 26 Aug 2024 10:41:47 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7E6D8CE0CE2; Mon, 26 Aug 2024 10:41:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AC6BC51408; Mon, 26 Aug 2024 10:41:39 +0000 (UTC) Date: Mon, 26 Aug 2024 13:41:48 +0300 From: Catalin Marinas To: Steven Price Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Gavin Shan , Shanker Donthineni , Alper Gun Subject: Re: [PATCH v5 15/19] arm64: mm: Avoid TLBI when marking pages as valid Message-ID: References: <20240819131924.372366-1-steven.price@arm.com> <20240819131924.372366-16-steven.price@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240819131924.372366-16-steven.price@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240826_034146_430096_F073A632 X-CRM114-Status: UNSURE ( 9.35 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 19, 2024 at 02:19:20PM +0100, Steven Price wrote: > When __change_memory_common() is purely setting the valid bit on a PTE > (e.g. via the set_memory_valid() call) there is no need for a TLBI as > either the entry isn't changing (the valid bit was already set) or the > entry was invalid and so should not have been cached in the TLB. > > Signed-off-by: Steven Price Reviewed-by: Catalin Marinas