From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CE77C5321E for ; Mon, 26 Aug 2024 14:35:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:In-Reply-To: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VW+HIHEhMAo3/O8qS6yn7a/M9Jq5ewUkNW1oEWQ5L3A=; b=M2o+cEgV2PChT0DJgMXvUS8BV0 D+n9bVkrH6LhtV8/OP2TtYkqnVNQS3Y9fxhhQco3vsq8JWiM7k9Uyw9W1ozsDMxMsCJpsbQJAeViH eM3Ez8sCJq5L33mnV9jRv+baK40EmSg2WeFqT605TacyOrT0XlrbptBjThZZyOzGgAcqEJEfhaA2h fM0vXHHJbHCv0RllocDNKfYrSaja51j6sHvYTLmrq7MRfMpBUWfR0eV+mjMjQo5bPiBCU/NrNabAu bqnBiBE9j+qYQDo8hGWaAzR6phk3tADlrDl3MKFbtXVl922FZvTx0RObl7kTKp0nMf+pSDrZmjvZ0 RC1a6dNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1siaop-00000007fvR-0C0I; Mon, 26 Aug 2024 14:35:43 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1siao1-00000007fod-2h5O for linux-arm-kernel@bombadil.infradead.org; Mon, 26 Aug 2024 14:34:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:In-Reply-To:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VW+HIHEhMAo3/O8qS6yn7a/M9Jq5ewUkNW1oEWQ5L3A=; b=eOOBARJFx0N77i0Les6OCd2UZQ TucXeYFFe2y4qycc41toA+6WbW5e+PF9IL3uEPNHELtkpAXdQHeT0H+w1+UlSwaOdMHGRxMhGsYFp Bb37h/zemL0wUtDQPaDjMxJGfjsCCtavnOh8ZxvvWWuiCZubbQTKblR1eHk/ljadk58MEzLzsn4Ra lMv9R+kVuy6YEOTv8HYXXIwJ0M2M2x/R5LRCCPrOBUeuYcp5BXAe0382+liUEI3fDqG8YO1fNFW+d EK9LFdp3v2hefwXairbEb9b2AtIjspO5W6SSHjE81EeAM5wTE/OSfq47+amUgFkC7FDe2bbw75J/H TSDa+4mw==; Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1siany-0000000AfUT-14D6 for linux-arm-kernel@lists.infradead.org; Mon, 26 Aug 2024 14:34:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724682885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VW+HIHEhMAo3/O8qS6yn7a/M9Jq5ewUkNW1oEWQ5L3A=; b=ASjHTVpIeCTSeGgid4jlaNZjwZpjL+AIUsYYQe5rFo8Ccg1aVGo926oYYaCdf0NLoixEKc 7nJW68+t/lfkrJ5qwRyVujGWSaIuHl4rVe2qa18knxDIAmm3VlpJ6JdyDhxFpxtI6sOPAw Tk7UNpy+kRTmOh1n7vfE+og5BBon4fE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724682886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VW+HIHEhMAo3/O8qS6yn7a/M9Jq5ewUkNW1oEWQ5L3A=; b=ggB39D5xR4X/ji5g2y9it2UOgX1nfp4GhJoDhVym0Rlz5J0/+LW2w3R/MK3/s1jWbbEnOf 6Z/uot7+ApgbzuX//rvxUh5i2IpfoC8XyAW8+/qAWASKfk9JCS289LzIQ7Fn3hspkqIgUY 1jZYxoSFEGrSiqKH8cZOYF++UKUQxkM= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-605-yAbAW1wvNHCpTek_PApAlA-1; Mon, 26 Aug 2024 10:34:44 -0400 X-MC-Unique: yAbAW1wvNHCpTek_PApAlA-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6c181e15e90so17578346d6.0 for ; Mon, 26 Aug 2024 07:34:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724682884; x=1725287684; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VW+HIHEhMAo3/O8qS6yn7a/M9Jq5ewUkNW1oEWQ5L3A=; b=lAVoLtZaDBrUQfrMXOo/dJxwE+a1Es63Ff/5sq8N1zha7YEqVGV0tazZjmJ6bOiGXv kKs14bhy3FHYXSbvynE+hGfaXLFpSYgPIJ4EcMckjxVpXcKbcW6CiwWuYVR1HWDfUkzs p0z2stiuGA/gCE4SWlBAxLMrlODWBB+I2Gl3we1nN0rebh5aIGlnpRnieH/DQoGqNefL i7paW449BLrro7kPha+EWVWI08oDg111JLLExfVj5jMgLpVX4h0ituqh/Br1kXgINc/x 22lMjLdkt+9ADd9zybRp5CXBkCScsqNLtfScBS+KmijSSSaAKAXaowr0YhANbqQAYT73 1Hzg== X-Forwarded-Encrypted: i=1; AJvYcCVWye7CElUQDNORKVZxicK2lNsRDwfqSWNcjbtK05CWrNJKonslIo6EF+xh3HHxkSFv1glEAIvoiH3pjU6rJY2A@lists.infradead.org X-Gm-Message-State: AOJu0Yx1UhDtLoOXsc6hIneydHvoBlzm6amU1MCgmjQgi+wlg4a1c70W Yo7hx6MOcnt4z9Eq+HXkcOtz6Q8GZPpOrFClyVHgupJ9hKVmag41Tzp1Fck8B+ZCUOdjsu/9osJ 0KhOzLi9cvuqikSywVvrwGIXW6dDguNG3dD/GTlcpCcWfRI0Ax+EhGUYlTq/CBAtM3zrBO+z0 X-Received: by 2002:a05:6214:4304:b0:6bb:a16d:279f with SMTP id 6a1803df08f44-6c16dcb7b2amr123088916d6.38.1724682883702; Mon, 26 Aug 2024 07:34:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGJyXhGmqDSVXXp1D+XITrKt9Uq9T5JuT4lUbtmj8ua5Df7FPqa8sCBxKyCSdGvctdo+BxBQQ== X-Received: by 2002:a05:6214:4304:b0:6bb:a16d:279f with SMTP id 6a1803df08f44-6c16dcb7b2amr123088766d6.38.1724682883376; Mon, 26 Aug 2024 07:34:43 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6c184ce9034sm10939096d6.73.2024.08.26.07.34.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Aug 2024 07:34:42 -0700 (PDT) Date: Mon, 26 Aug 2024 10:34:39 -0400 From: Peter Xu To: LEROY Christophe Cc: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Vlastimil Babka , David Hildenbrand , Oscar Salvador , "linux-s390@vger.kernel.org" , Andrew Morton , Matthew Wilcox , Dan Williams , Michal Hocko , "linux-riscv@lists.infradead.org" , "sparclinux@vger.kernel.org" , Alex Williamson , Jason Gunthorpe , "x86@kernel.org" , Alistair Popple , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , Ryan Roberts , Hugh Dickins , Axel Rasmussen Subject: Re: [PATCH RFC 2/6] mm: PGTABLE_HAS_P[MU]D_LEAVES config options Message-ID: References: <20240717220219.3743374-1-peterx@redhat.com> <20240717220219.3743374-3-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240826_153450_515505_FB7B6FF4 X-CRM114-Status: GOOD ( 12.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 23, 2024 at 06:19:52AM +0000, LEROY Christophe wrote: > Why is an option needed for that ? If pmd_leaf() returns always false, > it means the arch doesn't support pmd mappings and if properly used all > related code should fold away without a config option, shouldn't it ? It's not always easy to leverage an "if" clause there, IIUC. Take the case of when a driver wants to inject a pmd pfnmap, we may want something like: if (pmd_leaf_supported()) inject_pmd_leaf(&pmd); We don't have a pmd entry to reference at the point of pmd_leaf_supported() when making the decision. Thanks, -- Peter Xu