From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41712C5321D for ; Mon, 26 Aug 2024 21:30:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:Date:From:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NQcMPtKwW2Ur+/ekeJHQBfttffMZ3TRumocDv4AvDhE=; b=aj7THYZ6thbmN+X+71qE9pyp2J bPEqZrRoJkxPVebGrzFrXlDwvogDE6LEi0HzEgCwiDU7fZlIsicO4VQ7CgJmQ1pbFENGgwsu0tOP9 pLUwbIZUgcYGvZabL1W/crmwYmQmItSb1uMdWPkRVcgEdUtxED6s9jSVtrWaINjdY6/KT8Y4e1uim tl777crK69fZ61eJLVfGBq4wOxRojwZShHJkYR5YBI6d/BoNY9rCMlMzZsOqeKaF9JZmOO2Y6XxoD NSHZYo4q8pUKzWpPR6jPxih+LrKDPOC8s7PDugt1qgR7TCK/G7JosyBaG5H00XrY1vpwUjRET5XJp /Mkil29g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sihI8-00000008oe0-1yB6; Mon, 26 Aug 2024 21:30:24 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sigAS-00000008bOX-2jiF for linux-arm-kernel@lists.infradead.org; Mon, 26 Aug 2024 20:18:26 +0000 Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-a86b64ebd8aso141738566b.1 for ; Mon, 26 Aug 2024 13:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724703503; x=1725308303; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=NQcMPtKwW2Ur+/ekeJHQBfttffMZ3TRumocDv4AvDhE=; b=Zq4ricFuHENk1wXf6d1X0A12TBZQ5+pL3oPon29lvdwcY6ytTJ7NUfyjz/Beu7Mw5u Iu3Lf7UnlTEFcRNVzLdY2grTWy41c4n4K3qht0V9jEqulDYv10rI3JkB2WXrXI9lzk25 dTO7O1NvZm/zibdHX5T6WTRmFoGOY2xI35HaP0nRfFJGr3fq9weD565O7reKrtfW1Z6N jY1Sd3ZX18Gpbu3J4zIg771QoYc65wREm+OC2opJ6UDI3ObrFXBCa8PwE/S2xYjBEC1Q maTVH70WJ22kNMnbhTL+TUuLPezqGsQpVw2NxRVEmkQj0/T++DfcHrrTmLIDNNfpA7mo AQHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724703503; x=1725308303; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NQcMPtKwW2Ur+/ekeJHQBfttffMZ3TRumocDv4AvDhE=; b=FtieLuVQHIn5lJHIAhdZT2mtNOKw/vtQ6Mst5hE3snwRKSaV25pPQOWgrFLt+6YvvZ 0KkMYVnd23AYK8JjPQAh8HNwki4wcL9Ioaxl1y7boXF+0Bhzavww473dOFagEVanB2s0 rNhpAcwUPhfNKZkHQMU0O+qgsaUU0QYbIhmq78R6gte23qbf+ShEqfJyUikK95/dQlk1 +AFPd32bjZkPbqhRgFEgQBILXbqUEljCM0/jHg+fQzk/2jVg/TjL3m7m3AF5F6cy/Iwp ZtDjkH4PcIAFH06RU94rXPdSOo7g0UpwJnVtPlIFifkXHuaGTYyxdHt8RfwWQb6fQrRT FPpA== X-Forwarded-Encrypted: i=1; AJvYcCXSM+elIaU75SuQt62/sY9EXILA9cVTMEzfSe45k2YaHGb33QwHfO1weRlOV1YoEpik8xhIhrLhQTbehNBjUF6R@lists.infradead.org X-Gm-Message-State: AOJu0YyufXoBkD4paixxUI3Itm0qaTanBhO6qP4ZkMNY5LU65mTpPnaq ERSzaLHaKmSl9UebUQG69cdHiDum2rUIW+xwtdG8BCSWvSSmDMyHQXd646sF8Ys= X-Google-Smtp-Source: AGHT+IGg3wF8BNSAEwrMaM1mnP282cCzSjHmPqhfR3e+bo7xqlwNcVANiEFofVeUFy+v47Ksb4HTjw== X-Received: by 2002:a05:6402:26d3:b0:5a1:2ce9:f416 with SMTP id 4fb4d7f45d1cf-5c0891b4825mr9974880a12.37.1724703502649; Mon, 26 Aug 2024 13:18:22 -0700 (PDT) Received: from localhost ([87.13.33.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a86e5485003sm16833066b.13.2024.08.26.13.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Aug 2024 13:18:22 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Mon, 26 Aug 2024 22:18:29 +0200 To: Florian Fainelli Subject: Re: [PATCH 11/11] arm64: dts: rp1: Add support for MACB contained in RP1 Message-ID: Mail-Followup-To: Florian Fainelli , Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Broadcom internal kernel review list , Linus Walleij , Catalin Marinas , Will Deacon , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Nicolas Ferre , Claudiu Beznea , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Saravana Kannan , Bjorn Helgaas , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, Lee Jones , Andrew Lunn , Stefan Wahren References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240826_131824_719515_DDBD4AF0 X-CRM114-Status: GOOD ( 20.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Catalin Marinas , Michael Turquette , Claudiu Beznea , Eric Dumazet , Dragan Cvetic , Will Deacon , linux-clk@vger.kernel.org, linux-arch@vger.kernel.org, Rob Herring , Saravana Kannan , Lee Jones , Broadcom internal kernel review list , linux-pci@vger.kernel.org, Jakub Kicinski , Paolo Abeni , Linus Walleij , devicetree@vger.kernel.org, Conor Dooley , Arnd Bergmann , linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Bjorn Helgaas , Andrea della Porta , linux-arm-kernel@lists.infradead.org, Derek Kiernan , Stephen Boyd , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Stefan Wahren , netdev@vger.kernel.org, Krzysztof Kozlowski , "David S. Miller" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Florian, On 10:02 Wed 21 Aug , Florian Fainelli wrote: > On 8/20/24 07:36, Andrea della Porta wrote: > > RaspberryPi RP1 is multi function PCI endpoint device that > > exposes several subperipherals via PCI BAR. > > Add an ethernet node for Cadence MACB to the RP1 dtso > > > > Signed-off-by: Andrea della Porta > > --- > > arch/arm64/boot/dts/broadcom/rp1.dtso | 23 +++++++++++++++++++++++ > > 1 file changed, 23 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/broadcom/rp1.dtso b/arch/arm64/boot/dts/broadcom/rp1.dtso > > index d80178a278ee..b40e203c28d5 100644 > > --- a/arch/arm64/boot/dts/broadcom/rp1.dtso > > +++ b/arch/arm64/boot/dts/broadcom/rp1.dtso > > @@ -78,6 +78,29 @@ rp1_clocks: clocks@c040018000 { > > <50000000>; // RP1_CLK_ETH_TSU > > }; > > + rp1_eth: ethernet@c040100000 { > > + reg = <0xc0 0x40100000 0x0 0x4000>; > > + compatible = "cdns,macb"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + interrupts = ; > > + clocks = <&macb_pclk &macb_hclk &rp1_clocks RP1_CLK_ETH_TSU>; > > + clock-names = "pclk", "hclk", "tsu_clk"; > > + phy-mode = "rgmii-id"; > > + cdns,aw2w-max-pipe = /bits/ 8 <8>; > > + cdns,ar2r-max-pipe = /bits/ 8 <8>; > > + cdns,use-aw2b-fill; > > + local-mac-address = [00 00 00 00 00 00]; > > + phy-handle = <&phy1>; > > + phy-reset-gpios = <&rp1_gpio 32 GPIO_ACTIVE_LOW>; > > + phy-reset-duration = <5>; > > + > > + phy1: ethernet-phy@1 { > > + reg = <0x1>; > > + brcm,powerdown-enable; > > Undocumented property, and I would like to understand why this needs to be > specified in the Device Tree? What model of Broadcom Ethernet PHY is being > used here? It's a Broadcom BCM5421 transceiver, and that property is intended to support the optional link-down powersave from DT. It will require slight changes in drivers/net/phy/broadcom.c too and is not really necessary for minimal support, so I will drop it in the next iteration. Many thanks, Andrea > -- > Florian >