From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37E57C83F0A for ; Thu, 29 Aug 2024 12:03:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:Date:From:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mXBtr/JbiSQG7W9JfMUYCtQfQyKUiftjthV/2nojugU=; b=ZmijU1hpFNZs2P0cfHvlISFHh+ jlCFVSuW5gqMgwyewTd8FYzyvUMNtLFf6WATO2FlgcnL+yQy8d6AE2c3jFeYEFJZ9pHmIfgv4+Goh Pp9n/aj3KBxZBy/ausqHmCojlaOw65JgPwmQisLNa9rYxAvPNJRo+Jgj4o1Ui0i1FN45AGDBdunY6 OmPITyZZzoE2idxlVJIKHQZ9ZKYV19GBpcGcnDQQIP6rd80HE2xR/JHi283Yq8+qD7QIDNJyg6nrS ZLxkQMF1vrtcqV36s0JCbO9da6q5SMoWKTnv8jX+8Z7Wo9d2a9CVOtakf8V12mg8s/Q9g7Uo2nRG9 HgrlqJIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjdrg-00000001qTA-2FEX; Thu, 29 Aug 2024 12:03:00 +0000 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjdqb-00000001qAk-3Yoh for linux-arm-kernel@lists.infradead.org; Thu, 29 Aug 2024 12:01:55 +0000 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a86acbaddb4so63861966b.1 for ; Thu, 29 Aug 2024 05:01:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724932912; x=1725537712; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=mXBtr/JbiSQG7W9JfMUYCtQfQyKUiftjthV/2nojugU=; b=F0n9xVZcXZAeNhDW43k+Y3JnDj/vqLD9yaqDT/8O+4fNYucZ0R7heA4h29+vp1CoPD 1XDOyoDsVChmo0uEQfqvSu1MwpDadmy0opJ2dCI4uOi5HA4WlaaAeV7+V0UrsVosKnMM FKGEm7otCCI78SDa0c8yaybwesCrMZDfcCkoyaa7lFEu91kC7ylrInHJCHSXZ2+spYgf 29KLBcNI9QcDSKr+Xzs6hfuSMyh3F8t4hcddzoGDLLD+iO4i/wVJt6JxeCIVgx4B2KLx 34DeLmJLCOFC+P4Mchb2DT4suq5VAzTOPwcwYbn0lzlej56p/PB64+8UvRQ1lzviewDb ATKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724932912; x=1725537712; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mXBtr/JbiSQG7W9JfMUYCtQfQyKUiftjthV/2nojugU=; b=VCzVPR2vlkEbi0jzerh9ife2ecYsULw5IfqkgcdmW/fJKPEUfE6RKMwmLmu1OpHJEq FM2H+t02oOYQnwwcav3UY9NC7XLmdJDFhMI9phlopcLw1uXo5VY1+8FMph+s318C02Ar bvMMHE0uafMrAbISo+wh/qqlEOb7Sz1HYrAYhzSNlTwJpX1NrEgKVp/D+GLLUbZvP+fQ bVg6kJLzsLMXHsA/0FZBzbOkhpNrDfHDb7vG1sLerQMgzDPganPln1LyeE1sjfzIWEFL X55hZKa8gWRM4IAGVMB0FJcww2qD1Lu1NNG+dgt1sGzw89fOHRVy5yBmRsdtreJ4HvJ8 NI4Q== X-Forwarded-Encrypted: i=1; AJvYcCUYc1UAb1wi5sK7MYaWQQp6KOYwo7cRYS9d5bWhzcIlZOAUL2yvn3u0glpF9iqyXJ2ygUAceYf1lXTM6HFyiohZ@lists.infradead.org X-Gm-Message-State: AOJu0YwgSh4P6yQHpPyRilo1xrMyvx9eAeSFRp/tLONUc/5oatxDrm1R mV9oWypLWTh1RL3auS7fAqebqxdJ4BwQJotk50A0Ghe9UKshE8rb4gAzpjkn2DY= X-Google-Smtp-Source: AGHT+IFsyk0IWnaZFMb265yPeWvESMoqgeE3DSP8XvW62AVSUHg1bVi4x43hO0c3ITnEgvBmjx2LDg== X-Received: by 2002:a17:907:9708:b0:a80:7ce0:8b2a with SMTP id a640c23a62f3a-a897f84d44cmr193846766b.19.1724932909698; Thu, 29 Aug 2024 05:01:49 -0700 (PDT) Received: from localhost (host-80-182-198-72.retail.telecomitalia.it. [80.182.198.72]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8989021960sm71432166b.79.2024.08.29.05.01.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2024 05:01:49 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Thu, 29 Aug 2024 14:01:54 +0200 To: Andrew Lunn Subject: Re: [PATCH 00/11] Add support for RaspberryPi RP1 PCI device using a DT overlay Message-ID: Mail-Followup-To: Andrew Lunn , Krzysztof Kozlowski , Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Linus Walleij , Catalin Marinas , Will Deacon , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Nicolas Ferre , Claudiu Beznea , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Saravana Kannan , Bjorn Helgaas , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, Lee Jones , Stefan Wahren References: <14990d25-40a2-46c0-bf94-25800f379a30@kernel.org> <45a41ed9-2e42-4fd5-a1d5-35de93ce0512@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45a41ed9-2e42-4fd5-a1d5-35de93ce0512@lunn.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240829_050153_909889_BA614F2B X-CRM114-Status: GOOD ( 23.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Michael Turquette , Claudiu Beznea , Eric Dumazet , Dragan Cvetic , Will Deacon , linux-clk@vger.kernel.org, linux-arch@vger.kernel.org, Rob Herring , Florian Fainelli , Lee Jones , Krzysztof Kozlowski , Saravana Kannan , Broadcom internal kernel review list , linux-pci@vger.kernel.org, Jakub Kicinski , Paolo Abeni , Linus Walleij , devicetree@vger.kernel.org, Conor Dooley , Arnd Bergmann , linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Bjorn Helgaas , Andrea della Porta , linux-arm-kernel@lists.infradead.org, Derek Kiernan , Stephen Boyd , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Stefan Wahren , netdev@vger.kernel.org, Krzysztof Kozlowski , "David S. Miller" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrew, On 15:04 Thu 22 Aug , Andrew Lunn wrote: > > WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP > > #673: FILE: drivers/pinctrl/pinctrl-rp1.c:600: > > + return -ENOTSUPP; > > > > This I must investigate: I've already tried to fix it before sending the patchset > > but for some reason it wouldn't work, so I planned to fix it in the upcoming > > releases. > > ENOTSUPP is an NFS error. It should not be used outside for NFS. You > want EOPNOTSUPP. Ack. > > > > WARNING: externs should be avoided in .c files > > #331: FILE: drivers/misc/rp1/rp1-pci.c:58: > > +extern char __dtbo_rp1_pci_begin[]; > > > > True, but in this case we don't have a symbol that should be exported to other > > translation units, it just needs to be referenced inside the driver and > > consumed locally. Hence it would be better to place the extern in .c file. > > Did you try making it static. The dtso is compiled into an obj and linked with the driver which is in a different transaltion unit. I'm not aware on other ways to include that symbol without declaring it extern (the exception being some hackery trick that compile the dtso into a .c file to be included into the driver main source file). Or probably I'm not seeing what you are proposing, could you please elaborate on that? Many thanks, Andrea > > Andrew