From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17F88C83F0A for ; Thu, 29 Aug 2024 12:35:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LnmiFrrbMnxAu5s7ZDc9CRuXaVMnkgjfklYyUU43jJU=; b=b/7XJz2GmeZr8RVrbtyNjrv96n 30nXl/64loeATiWXqrz/TeCiIx+MFrpa2NTgCw/57xFq5HnpTPg/HUBLBWv/2UmwmQVEkxOirsFKw cJpysI7bmSkUtZytI8BGjfc0earS4uWvsa/chEaP2eMAloPSgqttsAGgyEnXOReeWFbgxVx1nVuKb S9cMq226vjRFRukyP34/nIG7tN3aXb5UUUznYCbbYhFcy5w6WyOH+NEJx+IpOh8WC79RSJck47J6s GI54bkxKEIR7ur7jSCXQ4kYDqxc/kTNR6+vPVwy8Cvm53P7L7WGRJI0K+XTxqF7Bpqy+p2VUXcaM9 hIY5SZfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjeMX-00000001wzC-2SgM; Thu, 29 Aug 2024 12:34:53 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjeLg-00000001wku-2HLx for linux-arm-kernel@lists.infradead.org; Thu, 29 Aug 2024 12:34:01 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 441651477 for ; Thu, 29 Aug 2024 05:34:21 -0700 (PDT) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C360E3F762 for ; Thu, 29 Aug 2024 05:33:54 -0700 (PDT) Date: Thu, 29 Aug 2024 13:33:45 +0100 From: Liviu Dudau To: Krzysztof Kozlowski Cc: Linus Walleij , Sudeep Holla , Lorenzo Pieralisi , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ARM: versatile: fix OF node leak in CPUs prepare Message-ID: References: <20240826054934.10724-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240826054934.10724-1-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240829_053400_651624_4D28498A X-CRM114-Status: GOOD ( 19.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 26, 2024 at 07:49:33AM +0200, Krzysztof Kozlowski wrote: > Machine code is leaking OF node reference from of_find_matching_node() > in realview_smp_prepare_cpus(). > > Fixes: 5420b4b15617 ("ARM: realview: add an DT SMP boot method") > Signed-off-by: Krzysztof Kozlowski Acked-by: Liviu Dudau I think Sudeep is going to take the series through his tree, but he might be on holiday at this time. Best regards, Liviu > > --- > > Not Cc-ing stable as this should have almost no impact, except code > correctness. > --- > arch/arm/mach-versatile/platsmp-realview.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-versatile/platsmp-realview.c b/arch/arm/mach-versatile/platsmp-realview.c > index 6965a1de727b..d38b2e174257 100644 > --- a/arch/arm/mach-versatile/platsmp-realview.c > +++ b/arch/arm/mach-versatile/platsmp-realview.c > @@ -70,6 +70,7 @@ static void __init realview_smp_prepare_cpus(unsigned int max_cpus) > return; > } > map = syscon_node_to_regmap(np); > + of_node_put(np); > if (IS_ERR(map)) { > pr_err("PLATSMP: No syscon regmap\n"); > return; > -- > 2.43.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯