From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D03EC8303E for ; Thu, 29 Aug 2024 18:27:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:In-Reply-To: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3WuSlRBbAE14ViqgSTitGeyCxk0WS9L/CSL99pAIvUI=; b=HuG/e5J1TmB9EgW1NZo8Yuv+8f 7bqpRezRuM11KEJnElFKHKtrylnc+ol/NDKrfQsDv2NuAVJnuadHu/C7gpxolQe3RzUOpdT1xJn0r S4UCJQzWqveRX1HKpI+l7DLh8IX6fIW6UWNDK7sqC+y3LGmycGwdMhP8v0zxdNJ4RJtnMC31Xn1TT S6Xk+diMwMI9wkBcqj8tGwgFqH6CByxRBpkwqeMEMQL3gAemW1+es+KBxFkIxYjX7M9DLhOVbrjZq LVXlMECqrkDCXCMCoMxQ0P6uJg7Dwk/JX9zjAQIVmMyz6avJXR5jhUvAVEjkJYJRo54jXsLvewTXS 0qplISjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjjrh-00000003B1Z-0GK7; Thu, 29 Aug 2024 18:27:25 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjjqq-00000003AnE-0cg3 for linux-arm-kernel@lists.infradead.org; Thu, 29 Aug 2024 18:26:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724955989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3WuSlRBbAE14ViqgSTitGeyCxk0WS9L/CSL99pAIvUI=; b=MFijP3KqFgKAUFLTF1Lmu4qYtztgsY2gQiypOUEm7Sl0bYd96NnoEjZg+96i3FmANSZWEg i1/+aAm/jJ5knR+DayiLx9aykgK0omFs3tufBIfV47WemLmniIrYr7qwWPyu9cF1y7e/RB TYE6hMzE0Jp6vBI+nYKP7alU23MWcJw= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-462-7EELMzKwOliN70X5yuWkcg-1; Thu, 29 Aug 2024 14:26:26 -0400 X-MC-Unique: 7EELMzKwOliN70X5yuWkcg-1 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4567730b6a9so18184931cf.1 for ; Thu, 29 Aug 2024 11:26:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724955986; x=1725560786; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3WuSlRBbAE14ViqgSTitGeyCxk0WS9L/CSL99pAIvUI=; b=kgIoeSizki8RoAT5nCnN1p6sBwMW8Gw7Bohnjx7j6BbEk0KoWIsP4nQ1aDRzvibnK5 hDo4Mrfd0Qrru6mSRy4TTQNt744uuRlHlCYsJiiJb6QeZ2l/ge8WcBrB7kB/W7JJXkK+ 5/Qwblw2fKmuiBRwaDg47OAocKv7PDYr0ciXLNBZ/D/H4/TuAmuOyJ974r4Pxq07nl/z PdlZxXtn0K1pnRIui5QyN74k+QyHgmeV9af6A+FJXh/wpKFpvpT4vJibFTw2CjNZZ4yO 7NSR+TKkJE1Oi3jc56uJDxiNg5dGYmAmXzVrSx1GFg5wJvy5A1lL4nwQzShMMCFZ6TMb Um/g== X-Forwarded-Encrypted: i=1; AJvYcCUo94xRrR5CaaQGJs+hudTRdQbElp6du7vV+ss+mRLLe3jJiOUm+X6mFKDvpmiyu8lEv0s86fTgQep9iBHIFSjh@lists.infradead.org X-Gm-Message-State: AOJu0YzQlaM8vBRjzp/0hueD0bFv9hPoIU8E61Fg2mhklXGuh+nq4prR G04qP+YzcKngw/iRuDLCVjiMuZZFwLqMDeaG/2p447w4n8+xJYShJ1ITid+r5mrjSF0IYkX8Wph KMHI4GnzkWglxvbRRcVZ1tvcE79LXV9R53KR1x883/RxWXOcrbQrxmR5ehSEh5PRvxCLX7Crz X-Received: by 2002:a05:622a:4819:b0:456:45cc:2b5a with SMTP id d75a77b69052e-45680261427mr70106651cf.25.1724955985967; Thu, 29 Aug 2024 11:26:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEzclADxCb1u5q8U+Sk7zwoAJ25wF2K4UbrNY0LglvkHgW5dZaI/1Ur1kfLF9ykMtA/fsqWzw== X-Received: by 2002:a05:622a:4819:b0:456:45cc:2b5a with SMTP id d75a77b69052e-45680261427mr70106031cf.25.1724955985521; Thu, 29 Aug 2024 11:26:25 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45682c82a52sm7101381cf.16.2024.08.29.11.26.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2024 11:26:24 -0700 (PDT) Date: Thu, 29 Aug 2024 14:26:22 -0400 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Gavin Shan , Catalin Marinas , x86@kernel.org, Ingo Molnar , Andrew Morton , Paolo Bonzini , Dave Hansen , Thomas Gleixner , Alistair Popple , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sean Christopherson , Oscar Salvador , Jason Gunthorpe , Borislav Petkov , Zi Yan , Axel Rasmussen , Yan Zhao , Will Deacon , Kefeng Wang , Alex Williamson Subject: Re: [PATCH v2 07/19] mm/fork: Accept huge pfnmap entries Message-ID: References: <20240826204353.2228736-1-peterx@redhat.com> <20240826204353.2228736-8-peterx@redhat.com> <78d77162-11df-4437-b70b-fa04f868a494@redhat.com> MIME-Version: 1.0 In-Reply-To: <78d77162-11df-4437-b70b-fa04f868a494@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240829_112632_347268_C29A86D5 X-CRM114-Status: GOOD ( 20.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 29, 2024 at 05:10:42PM +0200, David Hildenbrand wrote: > On 26.08.24 22:43, Peter Xu wrote: > > Teach the fork code to properly copy pfnmaps for pmd/pud levels. Pud is > > much easier, the write bit needs to be persisted though for writable and > > shared pud mappings like PFNMAP ones, otherwise a follow up write in either > > parent or child process will trigger a write fault. > > > > Do the same for pmd level. > > > > Signed-off-by: Peter Xu > > --- > > mm/huge_memory.c | 29 ++++++++++++++++++++++++++--- > > 1 file changed, 26 insertions(+), 3 deletions(-) > > > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > index e2c314f631f3..15418ffdd377 100644 > > --- a/mm/huge_memory.c > > +++ b/mm/huge_memory.c > > @@ -1559,6 +1559,24 @@ int copy_huge_pmd(struct mm_struct *dst_mm, struct mm_struct *src_mm, > > pgtable_t pgtable = NULL; > > int ret = -ENOMEM; > > + pmd = pmdp_get_lockless(src_pmd); > > + if (unlikely(pmd_special(pmd))) { > > I assume I have to clean up your mess here as well? Can you leave meaningful and explicit comment? I'll try to address. -- Peter Xu