From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 010FFC83F16 for ; Thu, 29 Aug 2024 16:02:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RT4eOwO/fytGV0X6ULl+RzmfUuNSzGAo7a1rK0p5FHI=; b=ZNoYxSIx2GJMUVUV1iswltc2f6 xF4Ol8XB+Ypw+AQBhJAJ2VsgEwKXkvrF42n7/sLU4k7xrZcKAU5/G2enakc8NBHIY2536ZXyTTIlx 3IDxk28GYmQEgQ+gTvev/YpL169abaEneFWmdspGDykVEZ7D1rkeVHYIBsjMf74ylvFGr/fd2HsfV X4CvBP4Lbi+xp5ZrFcvLvSXBco1hVH+nzZEYM4xmF90RjLWm3mm0+7xvqEqQQ8QgvnJMorXVViGG8 G8DFkzhd8US2O8OW21H/Fh7AWD24PnakQMe9w/0j7DxAZKhpdbUP58jXlJJgKSojQpMRKgz+zoz8j a8IKvxJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjham-00000002jhL-2wbs; Thu, 29 Aug 2024 16:01:48 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjhZq-00000002jQ2-0w8M for linux-arm-kernel@lists.infradead.org; Thu, 29 Aug 2024 16:00:52 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D98C3DA7; Thu, 29 Aug 2024 09:01:13 -0700 (PDT) Received: from bogus (e107155-lin.cambridge.arm.com [10.1.198.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9876F3F762; Thu, 29 Aug 2024 09:00:46 -0700 (PDT) Date: Thu, 29 Aug 2024 17:00:44 +0100 From: Sudeep Holla To: Miao Wang Cc: Hanjun Guo , "Rafael J. Wysocki" , Len Brown , Sunil V L , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3] ACPI: introduce acpi_arch_init Message-ID: References: <20240808-intro-acpi-arch-init-v3-1-ba510859baff@gmail.com> <64bd9991-61a9-5cb5-60fe-941cb4171290@huawei.com> <4EC8AF0D-321F-437B-93C6-E597E4D4BB34@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4EC8AF0D-321F-437B-93C6-E597E4D4BB34@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240829_090050_323552_782AF116 X-CRM114-Status: GOOD ( 17.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 28, 2024 at 04:40:29AM +0800, Miao Wang wrote: > > > > 2024年8月8日 17:43，Hanjun Guo 写道： > > > > On 2024/8/8 17:00, Miao Wang via B4 Relay wrote: > >> From: Miao Wang > >> To avoid arch-specific code in general ACPI initialization flow, > >> we introduce a weak symbol acpi_arch_init. Currently, arm64 can > >> utillize this to insert its specific flow. In the future, > >> other architectures can also have chance to define their own > >> arch-specific acpi initialization process if necessary. > >> Signed-off-by: Miao Wang > >> Reviewed-by: Sunil V L > >> Reviewed-by: Sudeep Holla > >> --- > >> Changes from v1 > >> - Change acpi_arch_init from a static inline stub to a weak function > >> according to Haijun Guo's advice > >> --- > >> Changes from v2: > >> - Add __init attribute to the weak acpi_arch_init stub > >> - Link to v2: https://lore.kernel.org/r/20240807-intro-acpi-arch-init-v2-1-9231e23a7721@gmail.com > > > > Thanks for the quick update, > > > > Acked-by: Hanjun Guo > > Hi, all. I wonder whether this patch is good to be applied or > any improvement is needed. > LGTM. Rafael, do you want to take this via your tree or arm64(need your ack) once you are happy with the change ? -- Regards, Sudeep