From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EFA2BC83F16 for ; Thu, 29 Aug 2024 16:18:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=f+zHHiDZCrYL7p6WaUspPk5WNBiW1u6N4bEix9vRGGQ=; b=sHvp3lODfWN2gjtssbAB6Epss8 GjRqzs/VdFN+/WRVAzjANusky4H+QaTyqd49LxI5b/44vw0yvYwLjrQ0rZpxwYLUx1VAU6iGid7os /W0SQxSl1tB7xBWh7sTqQewuIpqdtbdD2HLJtTGnmC5XEsoyjfI3fGOdinnSYdtzbAtOc3oWNIBnV hWgtvHOld09wht4sXig7Ts89m8qiqcYI4U3kihZD+2dB5NmjdOQnxgcMgAQZTQfxxK8zCvoQKa9kF t+rwOq4tRrx9N6xzBqDyOwV9fjWpW++JGEbz0PnLAQ44CMeYsa/KJJ3A18lbvjOudJ/PFpq04aHyQ 7ABAffoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjhrB-00000002ndV-30Zn; Thu, 29 Aug 2024 16:18:45 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjhqH-00000002nOK-1ns9 for linux-arm-kernel@lists.infradead.org; Thu, 29 Aug 2024 16:17:50 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9E2DEDA7; Thu, 29 Aug 2024 09:18:14 -0700 (PDT) Received: from bogus (e107155-lin.cambridge.arm.com [10.1.198.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B3ED83F762; Thu, 29 Aug 2024 09:17:46 -0700 (PDT) Date: Thu, 29 Aug 2024 17:17:44 +0100 From: Sudeep Holla To: Aleksandr Mishin Cc: Fu Wei , Lorenzo Pieralisi , Hanjun Guo , "Rafael J. Wysocki" , Len Brown , Mark Rutland , , , , Subject: Re: [PATCH] acpi/arm64: Adjust error handling procedure in gtdt_parse_timer_block() Message-ID: References: <20240827101239.22020-1-amishin@t-argos.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240827101239.22020-1-amishin@t-argos.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240829_091749_528237_145D370A X-CRM114-Status: UNSURE ( 9.19 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 27, 2024 at 01:12:39PM +0300, Aleksandr Mishin wrote: > In case of error in gtdt_parse_timer_block() invalid 'gtdt_frame' > will be used in 'do {} while (i-- >= 0 && gtdt_frame--);' statement block > because do{} block will be executed even if 'i == 0'. > > Adjust error handling procedure by replacing 'i-- >= 0' with 'i-- > 0'. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > (For some reason I don't see the original email in my inbox, might have got blocked 🙁). Anyways LGTM, Acked-by: Aleksandr Mishin -- Regards, Sudeep