From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA03EC8303E for ; Thu, 29 Aug 2024 17:55:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KQvfeHMdtCKVg/0NfLW/JTUJg7HFDcioLIjbQ20soJM=; b=yQopxyE/BWcMFJRH+ZeV+Gdmtb lJHFb2Qs4SR2c0RAjQ+mbhRcrKelBo3IDZZ27RW9Tkstsn3R8E2T4Pyh7oI7cjJJ2WfkChh43fiSp KCj4fCrtN+gd1hVMRhpwnFyKBuH4brHgvfn83qp5ATNmYH1FA/umCfeu8Mw3II3sDcB2mkxEG3sBf NR+bTGtaCB0NxY3VeYh+/QxYHLPvllepowsI+jLXVBdQVpnSgFOU+02raJnr5haQnAccRmuORRwG0 G57cmTKCbxhM7oF8fobgMSkJvDs0bVgLVXTkBw8GPMj5ByKOwAxqMU79pn4o3pp8s9gIeAs3iFiau TnkWQVmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjjMO-000000035wI-3qJg; Thu, 29 Aug 2024 17:55:04 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjjLY-000000035kS-0FFk for linux-arm-kernel@lists.infradead.org; Thu, 29 Aug 2024 17:54:13 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 680EA1480; Thu, 29 Aug 2024 10:54:35 -0700 (PDT) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 722D93F762; Thu, 29 Aug 2024 10:54:07 -0700 (PDT) Date: Thu, 29 Aug 2024 18:54:01 +0100 From: Mark Rutland To: Steven Rostedt Cc: Will Deacon , Puranjay Mohan , Catalin Marinas , "Madhavan T. Venkataraman" , Kalesh Singh , chenqiwu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, puranjay12@gmail.com Subject: Re: [PATCH] arm64: stacktrace: fix the usage of ftrace_graph_ret_addr() Message-ID: References: <20240618162342.28275-1-puranjay@kernel.org> <20240619124318.GA3410@willie-the-truck> <20240624161741.2a16d904@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240624161741.2a16d904@gandalf.local.home> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240829_105412_158148_7386209F X-CRM114-Status: GOOD ( 16.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Steve, On Mon, Jun 24, 2024 at 04:17:41PM -0400, Steven Rostedt wrote: > On Wed, 19 Jun 2024 13:43:18 +0100 > Will Deacon wrote: > > > > Catalin, Will, do you have any preference? > > > > I think it makes most sense if this patch travels together with > > 29c1c24a2707 ("function_graph: Fix up ftrace_graph_ret_addr()"), so that > > would be via Steve's tree. In which case: > > That makes sense to me. I'll go around pulling in all the updates to the > arch code here (with the respective acks). Are you still planning to pick this up? On next-20240829 the ftrace tests blow up (as below) due to having the core ftrace change to ftrace_graph_ret_addr() but lacking the arm64 fix. Splat on next-20240829: [2] Basic test for tracers ------------[ cut here ]------------ WARNING: CPU: 0 PID: 198 at arch/arm64/kernel/stacktrace.c:112 arch_stack_walk+0x1d0/0x350 Modules linked in: CPU: 0 UID: 0 PID: 198 Comm: ftracetest Not tainted 6.11.0-rc5-next-20240829 #1 Hardware name: linux,dummy-virt (DT) pstate: 604000c5 (nZCv daIF +PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : arch_stack_walk+0x1d0/0x350 lr : arch_stack_walk+0x1c4/0x350 sp : ffff800080003e10 x29: ffff800080003e10 x28: ffff800080003fe0 x27: ffff800080003eb8 x26: ffff000003813600 x25: ffff800080004000 x24: ffff80008002ebd8 x23: ffff800080003ed8 x22: ffff800080023c78 x21: ffff80008002ebd8 x20: ffff800080003f40 x19: ffff800080003f30 x18: 0000000082000000 x17: 0000000000000000 x16: ffff800080000000 x15: 00003d0900000000 x14: 00000000000c3500 x13: 0000000000000000 x12: 0001f4e457e39c1c x11: ffff800082f06ca8 x10: ffff800080003f30 x9 : ffff80008002ebd8 x8 : ffff800080003db8 x7 : 7fffffffffffffff x6 : 0000000006dd7418 x5 : 0000000000000023 x4 : ffff800080003e88 x3 : ffff800080003fe0 x2 : ffff80008002ebd8 x1 : 0000000000000000 x0 : ffff80008002ebd8 Call trace: arch_stack_walk+0x1d0/0x350 return_address+0x40/0x80 trace_hardirqs_on+0x8c/0x190 handle_softirqs+0xf0/0x400 ---[ end trace 0000000000000000 ]--- Mark.