From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46E1FCA0EEB for ; Fri, 30 Aug 2024 07:58:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jsq8PTg+1zf/agVdzEy6/WGwIPsW99EeBxvQlklsS3g=; b=vq9VpH5k2EcWzgRNkIizrNdHAz p/OgNQHBQV4TeKfPXLZkMzbGJ32Z0QV4DzyqSrlVGxeiDJNfL9iURktlewH+ADR493oldIkQ/bk6t JPtANdruwTlWazlCSInk29wvMWUjM9XSHebPJDgI+t+IozFa4jDC/jj1UZ9UdnVfFxYtzKZV9Fjr2 PIqn7HgwuLLdSHq2uid5WqGFzgbyc+pMvfbjJXOby0w0HfzMlFBidDmZKauI73XdD2O1iXY9ADT2V Rk00Zldz9KBAnNH0mf4fIgMCTw3d2OtyUzur2M7vYGirUOPW3svYI6e2jnN30C3zRYC7v/RZqzLLW Ed8S7Crw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjwVx-00000005DR6-2jf5; Fri, 30 Aug 2024 07:57:49 +0000 Received: from mail-dm6nam11on2061e.outbound.protection.outlook.com ([2a01:111:f403:2415::61e] helo=NAM11-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjwUm-00000005D6y-3sxr for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2024 07:56:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hJKL0F/CTsSoYIetQLY/aWcJuvV1eMakRCly+P9BF919Fak3WNLEZzEA4dY6olDJ5t+1fJfeHF4uH/hEUoBGIT9ROkDXRc5NsgmE7H9SSyJfQRJp7tqTss27xYQFUWnMzel82uq2Vrxu+lhWarHqhqpl/1r7KQpH3MnfuZPNNB3mIvMQDlzPxYqMa6BS8ZrXkOwljiPwTF3R78/GD89KT7QKCsoLCciWgY9wyHFshT89l8JoWXKNox2XJwdF5zC3//Pjr7eTZ6/6sdBh41KXJmleY/C91fgZNA+gGXSbhoxivrhJsKDUxHCWuCurL+ra6qFLgZjWT16H1nUqz3zSbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jsq8PTg+1zf/agVdzEy6/WGwIPsW99EeBxvQlklsS3g=; b=sNfrL7fVYjZcpJeJrEqkieEoSUHTE1IKPv5l1++hltD8OH1+P95w/Cl8+73SKtKuE+ERccYJ0D9IyRH4O/Dl7itYUGu6VN1soxs0QeA+7k2yhIbt+8iY3lJ70f5zFXHTHUyF1ZylRDYcn/x8DPiELI+ifYUIsSqt8JwoU5QNluBgFOqt5jVSzuWSaylj15RA+wU5ewoecIU2Mzp51lXht3N+/zHs8iNstOIxL89indRXGJ5LsBaT+nyBoLz/j/TG+sq7+Fyksmc7rJRciFMAFqzd+mIHDKnBLqw1NQa5dc8M8wPM+cBnUtscnDLTOizZkhH3ogUbFxmm7XnNq/HuDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jsq8PTg+1zf/agVdzEy6/WGwIPsW99EeBxvQlklsS3g=; b=IehYidbVS5+yGPF9Mhm3S/x5U/29egjhbvYkcb8O0u6Ycj1MjiRhGMPg1PGLhDqwhavGtEJ55OwQX5GBUyE1b+9kqyTh4NOB6SrsUwW9yqFVILCG4i80QyuKuiZmq41n6GBvW9VW2iQ5Hf/7x18+FBosSq6W2KPk1IP3Tx3Nv7FTWmseFPO4RSRN0jyc1HRygTMryEFFr8S9gUd3CLNv9UoydJCsibGkZWrbhI2z8Etm9+K8lddyiRGvDC5DzUgd6BeFkZiCY20OMXtpfp7NeUWCY13ghOYHrycNZYLyLht6CfoIZ0rmO/+izP4gJWpqzXbQaVTlvyN5teSmkDPcDQ== Received: from PH7P220CA0174.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:33b::21) by MN0PR12MB6343.namprd12.prod.outlook.com (2603:10b6:208:3c0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.27; Fri, 30 Aug 2024 07:56:25 +0000 Received: from MWH0EPF000A672E.namprd04.prod.outlook.com (2603:10b6:510:33b:cafe::6c) by PH7P220CA0174.outlook.office365.com (2603:10b6:510:33b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.20 via Frontend Transport; Fri, 30 Aug 2024 07:56:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by MWH0EPF000A672E.mail.protection.outlook.com (10.167.249.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.13 via Frontend Transport; Fri, 30 Aug 2024 07:56:24 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 30 Aug 2024 00:56:07 -0700 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 30 Aug 2024 00:56:06 -0700 Received: from Asurada-Nvidia (10.127.8.13) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Fri, 30 Aug 2024 00:56:05 -0700 Date: Fri, 30 Aug 2024 00:56:04 -0700 From: Nicolin Chen To: "Tian, Kevin" CC: Jason Gunthorpe , "acpica-devel@lists.linux.dev" , Hanjun Guo , "iommu@lists.linux.dev" , Joerg Roedel , "kvm@vger.kernel.org" , Len Brown , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Lorenzo Pieralisi , "Rafael J. Wysocki" , "Moore, Robert" , Robin Murphy , "Sudeep Holla" , Will Deacon , Alex Williamson , Eric Auger , Jean-Philippe Brucker , Moritz Fischer , Michael Shavit , "patches@lists.linux.dev" , "Shameerali Kolothum Thodi" , Mostafa Saleh Subject: Re: [PATCH v2 2/8] iommu/arm-smmu-v3: Use S2FWB when available Message-ID: References: <0-v2-621370057090+91fec-smmuv3_nesting_jgg@nvidia.com> <2-v2-621370057090+91fec-smmuv3_nesting_jgg@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000A672E:EE_|MN0PR12MB6343:EE_ X-MS-Office365-Filtering-Correlation-Id: fe257d7f-07f5-4cba-6066-08dcc8c93eeb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?flTpaXdSBTElDz9FooRF4IbY8DQqnrW48AyscSvJi2O5rk13d7pl8ypUTtP3?= =?us-ascii?Q?CL1X0XSijp7jyTP7HthZ6WXS9tudvVaGk9pBvMowYK4LUtv35M9lKPC/yPn2?= =?us-ascii?Q?zwAPWWMQA7/w4N3YUIfFwv2tz8KNSdtxOHMioZPzwPYvhCsmGS+wZfYnfWrE?= =?us-ascii?Q?HTVMuX2/sTy6EZ1d6DOEuQDIhpeTS2rMgfdVpypih9r50tbd+AHhe0gXnPO8?= =?us-ascii?Q?Fw8a+C1ZoZHGKwNoHuejhVhhb2hLVfUzhi0niXgCfP2/7/8ml+3Tjv8xtAk6?= =?us-ascii?Q?WdatVBVT5VWvZ3izjIWHEkTpmGHnmP/gcj9gExJR3aU7sBxurO67r6GT5UD0?= =?us-ascii?Q?e8/Okeal3S+cqgz5ERIofe7AfWpPpyr4atfXy+I8pbVIsMD2q9fqxG1zqgYY?= =?us-ascii?Q?Lfx19Z0PK/Nkl+5NWrQcwE/xZlthHebKaUlkruQFM772zpLmS8i46PjigxkQ?= =?us-ascii?Q?8B8Ao1oyp8wLxvNZSzaGduVxvSTlI5JshOa+mFG9Zur0UgDVVhntt1d2iJZW?= =?us-ascii?Q?9m3C/tsMUzmKwjNFL586NEFj37r3n1acsnMPjZJk3OwAgHE8nNFx816OhJtA?= =?us-ascii?Q?Swx6494Ct7jxmMjhScZlFtOtJiyskn9sAVcxl/r8nUGKOCRLNKxbn6+K/hKA?= =?us-ascii?Q?1xveOZM9jyivVlKE568Yzu6RuZKiHULmhdkjpCcFzCn8wz9I+tsmoMN8Akq/?= =?us-ascii?Q?RsboFuGtUyqtDdsOV52827hEkPkEf6YurAPzzkknmSUOyYwlFHCtlhRLx3+P?= =?us-ascii?Q?LXWVhAob1WENOBcrgBBjkJToF85cSdSH1Gkqswu1CgzjckuEqumV0B0BDEj7?= =?us-ascii?Q?qcYIzQnNqr18EvdXtr/AhPAhFvoC9yuN+gr8kIboGE/+qLRW5TVHvj/I7Ywp?= =?us-ascii?Q?LwKiQy//WwBtWFw/xl1cM8faCsoztARHrIGufwhsJrtBm3VN9qIg5jcfspDT?= =?us-ascii?Q?uIlJhYwrN1fsSBkiEuKYvzTLjjPa3aDKV/ETfjYnmr83KcrlUidfOY47twJh?= =?us-ascii?Q?sREzRD5ARwGmL5UkPajhNxB3tlSwkj598l2AbeSGFwstHwJbIW76XyvQy1HX?= =?us-ascii?Q?fyZF8UxEYSFGiOuw2kB+QaXW66pOn9BLA4R4BG1e19HoRXxARbb43mRytP6r?= =?us-ascii?Q?vgEHse/IcmGTBm0B+E4/30M+tF3pITym44Q6/97xHKCKhfymMnBjKYCh0QU6?= =?us-ascii?Q?Yy34A5W8eGU+kXmS/qRrKxquG0DCHbPlkX1gliVT3KnN3nx3wJVZN/FikuTO?= =?us-ascii?Q?vkxQCYuUetIbMYb/v9NUMBBP967SA3eSD8YNDTx/tBZ0OSqCfI89//WoJ2qY?= =?us-ascii?Q?0jB5NuizFokzx2XnHvva9YnODj4G8IRBk7EOvQJ4IN9J35Hkvs7usd/M6C+r?= =?us-ascii?Q?kCsmxDhP4qOpXd5ZkcHJpN02tQdB64d0Cg6Ctv9Rx/aMj95ppEWeHcBIIlja?= =?us-ascii?Q?1nzFDHS/vFoWoAHD2bfO5EWKhTjA6vVJ?= X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2024 07:56:24.8268 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fe257d7f-07f5-4cba-6066-08dcc8c93eeb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000A672E.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6343 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240830_005637_046001_9416B749 X-CRM114-Status: GOOD ( 15.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 30, 2024 at 07:44:35AM +0000, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Tuesday, August 27, 2024 11:52 PM > > > > @@ -4189,6 +4193,13 @@ static int arm_smmu_device_hw_probe(struct > > arm_smmu_device *smmu) > > > > /* IDR3 */ > > reg = readl_relaxed(smmu->base + ARM_SMMU_IDR3); > > + /* > > + * If for some reason the HW does not support DMA coherency then > > using > > + * S2FWB won't work. This will also disable nesting support. > > + */ > > + if (FIELD_GET(IDR3_FWB, reg) && > > + (smmu->features & ARM_SMMU_FEAT_COHERENCY)) > > + smmu->features |= ARM_SMMU_FEAT_S2FWB; > > if (FIELD_GET(IDR3_RIL, reg)) > > smmu->features |= ARM_SMMU_FEAT_RANGE_INV; > > then also clear ARM_SMMU_FEAT_NESTING? S2FWB isn't the only HW option for nesting. Pls refer to PATCH-8: https://lore.kernel.org/linux-iommu/8-v2-621370057090+91fec-smmuv3_nesting_jgg@nvidia.com/ +static struct iommu_domain * +arm_smmu_domain_alloc_nesting(struct device *dev, u32 flags, [...] + /* + * Must support some way to prevent the VM from bypassing the cache + * because VFIO currently does not do any cache maintenance. + */ + if (!(fwspec->flags & IOMMU_FWSPEC_PCI_RC_CANWBS) && + !(master->smmu->features & ARM_SMMU_FEAT_S2FWB)) + return ERR_PTR(-EOPNOTSUPP); Thanks Nicolin