From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BFBCCA0EFC for ; Fri, 30 Aug 2024 10:28:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Wn4eD9yWatFflL2/3CKv6e2tbHrAQe8FmHkt92+sPt4=; b=0hWnBpaYDh/Dd/B8VgVm6puJXO RDEy6McHfGeumdpvl3yBGRpcQ/cQ4Qpv0hCMCL6p2X9Lk7HJvYVRis9d8Fiv3ksLL/DuvtAq/iHTI wZXuz2W5LejoJbailXsuwUCqb5NLuXepuqmPCywuMFE28mngEBKY4mnvyKVHbBo0Ph6ZHrM8FsWV8 GRVkLYzNWi1W604QZbxjWeyQyP3ghwMzMgkAVN/acj/UGB0pC8J0MQcVc9h4X+wo9artzHLw0pCGF xzdKOrQO9JmoeCyZYeatNCtDKsrwNd+CQh82JpgFicMwv9OquCuG0zUyfgxQ36pUzqYBcldvZLSsY hRCsKt+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjyrN-00000005ohj-0N5S; Fri, 30 Aug 2024 10:28:05 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjypk-00000005nyk-1xhE for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2024 10:26:26 +0000 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-42bb7298bdeso17583415e9.1 for ; Fri, 30 Aug 2024 03:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725013578; x=1725618378; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Wn4eD9yWatFflL2/3CKv6e2tbHrAQe8FmHkt92+sPt4=; b=3HJEREDum/TFXMeVRaUpUkpybukBca23Y/JAclxLpCghVmfudqj5YUyhLdMNMPznpo 3jQWXSuZ0XrxLInyIaFu+3+XhCDL2KUrzXV2g1e8EzjSBjLZok1thxZs6BpSTAYhw0Ly MlwEUDHdW7byVBACeXtY2KyhjYCKFw9CQHvrJcDvbA69PeqOzzPCxQPRp5mQ4ianCXTr mJluUc02Eei8+l7gp+mgXn8BIBmSMnrk9MqN1cnQHx6dqJqwEgoG8Efj6sZCAfQ4AJFO mPmVdK8c37FNsa+EhnouI/04+Jyft01o1r9SRgs0PaoUAjNXBUzlXFA5fl+pVjC3KPb8 hPdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725013578; x=1725618378; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Wn4eD9yWatFflL2/3CKv6e2tbHrAQe8FmHkt92+sPt4=; b=bHmD9+4luipVfh4sFb61VFaHubO4tAHz5rrLKVRDrTAXornIB6H5WGfida81HkQ0vq sg9Jmy2HfS7TniJgamFWuDG8ULYKUDyACSwIjmOf2BCSD5T5uHLQ9Pk8c0zzxZjGwJOR HV33vjXWO3PgQgw8+/ndl8KvnIPLHxaS8OzIsLFMV/CmDyJcm2C+HxCnC/89K+ZLjZrr JKUwW0idlqOkULbMkdzYPXaoWrQ99W5giAFbVvdWqQtkB44hM2p4HZjExIV/uMKPYQqb 5249k7N2BXTnbmynLGZgxG/S8vKS8zGVqc3e5lC28BRH/gU4PL1SlegC8gnlsp3HAbUk zFrw== X-Forwarded-Encrypted: i=1; AJvYcCX7yXlXvzTQuGq3xuv2dD0RpVl+Dod2GwIeviwa7xKNvQGFLX8f0qhJWyMx+Pzcea98011zw+MxwUJKFYwEzT0U@lists.infradead.org X-Gm-Message-State: AOJu0YzZrI1PdI+SaERa6kyWxXQzXk83nZiRx7EA8AtADowleMu6JHbJ d3c/2hxICxdaSbkKXDxBEZT4S690n4ClVc+8BRrzTxp2LxY9MMlv2ydCQ5DqRw== X-Google-Smtp-Source: AGHT+IHI/5ydMtgQPWhtQcchOILEP7cSDqvBil+uOoViRI+AG38bTMnFmDMcZTINUD1xJvmzIZz6LQ== X-Received: by 2002:a05:600c:3b10:b0:426:6ed5:fcb with SMTP id 5b1f17b1804b1-42bb01ae1fbmr57292825e9.4.1725013577995; Fri, 30 Aug 2024 03:26:17 -0700 (PDT) Received: from google.com (203.75.199.104.bc.googleusercontent.com. [104.199.75.203]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42ba7b4271fsm70580775e9.29.2024.08.30.03.26.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Aug 2024 03:26:17 -0700 (PDT) Date: Fri, 30 Aug 2024 11:26:12 +0100 From: Vincent Donnefort To: Sebastian Ene Cc: akpm@linux-foundation.org, alexghiti@rivosinc.com, ankita@nvidia.com, ardb@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, james.morse@arm.com, mark.rutland@arm.com, maz@kernel.org, oliver.upton@linux.dev, rananta@google.com, ryan.roberts@arm.com, shahuang@redhat.com, suzuki.poulose@arm.com, will@kernel.org, yuzenghui@huawei.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v9 5/5] KVM: arm64: Introduce the PTDUMP_STAGE2_DEBUGFS config Message-ID: References: <20240827084549.45731-1-sebastianene@google.com> <20240827084549.45731-6-sebastianene@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240827084549.45731-6-sebastianene@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240830_032624_601585_3CAC27D6 X-CRM114-Status: GOOD ( 21.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 27, 2024 at 08:45:48AM +0000, Sebastian Ene wrote: > When this config is enabled, it exposes the stage-2 pagetable layout > through a debugfs file. > > Signed-off-by: Sebastian Ene It doesn't feel like having a separated patch for Kconfig brings anything and I would have squashed it with the previous change. Otherwise: Reviewed-by: Vincent Donnefort > --- > arch/arm64/kvm/Kconfig | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm64/kvm/Kconfig b/arch/arm64/kvm/Kconfig > index 8304eb342be9..ead632ad01b4 100644 > --- a/arch/arm64/kvm/Kconfig > +++ b/arch/arm64/kvm/Kconfig > @@ -66,4 +66,21 @@ config PROTECTED_NVHE_STACKTRACE > > If unsure, or not using protected nVHE (pKVM), say N. > > +config PTDUMP_STAGE2_DEBUGFS > + bool "Present the stage-2 pagetables to debugfs" > + depends on KVM > + depends on DEBUG_KERNEL > + depends on DEBUG_FS > + depends on GENERIC_PTDUMP > + select PTDUMP_CORE > + default n > + help > + Say Y here if you want to show the stage-2 kernel pagetables > + layout in a debugfs file. This information is only useful for kernel developers > + who are working in architecture specific areas of the kernel. > + It is probably not a good idea to enable this feature in a production > + kernel. > + > + If in doubt, say N. > + > endif # VIRTUALIZATION > -- > 2.46.0.295.g3b9ea8a38a-goog >