From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 514A5CA0EFC for ; Fri, 30 Aug 2024 10:42:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:Date:From:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=h5Au08vB5OeNxHqyShPMASavhrXq4vVsx5hzYBAmcP4=; b=eN7iJP+g5lFFximaNiCJD7fMVX 94XVLOilnojoiTxGSs9RdtNCTUJuwgpKo8a8nUBaUcsugjvqkd9iljg9Py8gemttByKpVUD1pKMj6 vx/rKKTeCGTaxhMQ+fyBo70nHdxU1trqiXwvKmBRcBCFYFuRkPzGxngxsLfNYKlQCiJmlZYqf26I7 InUfWN07zMvvlpITJgn3ruxXjqZovaRUjM3kPBfnQUmpunf0nyDiB1IIj+WaN6CYHoSXXTqGFyfts TGz9aX7FYbQJ7qVISqGlUCgAGceEuk2G5Rv1bvNhtojmVeGmzQ/9Zuyl8P3b9zCZ6AZYtnYzSYE5Y v3YVNbOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjz5W-00000005sCO-2S5g; Fri, 30 Aug 2024 10:42:42 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjz1s-00000005rRd-3ulr for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2024 10:38:59 +0000 Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-a866cea40c4so186009866b.0 for ; Fri, 30 Aug 2024 03:38:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1725014335; x=1725619135; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=h5Au08vB5OeNxHqyShPMASavhrXq4vVsx5hzYBAmcP4=; b=dm4FQ+4HZNBEu2KWyqFUsuvqs4YkB2FfSX7OGYRA6IqnGu8D2vY4QGR6hSN+QolxRg 9rd5+DiQufBw8zc/JmBe0hS7H2CNOeBWzANXGerxdpO6r5Et+sA9VVHonrdQ5GNW6dRb 1U5KGCCpvl0yVvgl/hQiHVL9pQJyW64MjQOr5+otdpdT0Dp/eUBa6Bw84iuCSPmzKx3a x++Ex8zBIhsj6Io0JDiRuUZnswbI865kVvKTx989voHzEaf1EjhninoQZz0cV1O9Xr1B HVrsPvCJKRLKOCdUX0Vy/V9n5BFQrgWMJB4JtZc3hiFgG9GAxXfo33dduh8t3/2PgmdJ tL6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725014335; x=1725619135; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h5Au08vB5OeNxHqyShPMASavhrXq4vVsx5hzYBAmcP4=; b=EUYdcoKRhLBGO5WFOhFogki+VrPHKhO5YjthbPVqDn0qLfFuViKOTiLK10SrOvnrou y+ADF7HQL/q2jC6O6Lcho+D/2AQjPKyB0aDIa39d+4U/2Qi5AoixWrwTY8veGhfG3VEI Cz62SpqW0ytketESBwVpfXt4SJk30MrCepjVd2S0zE1GF0BgYcXoceScXRtjZX5cVsex phRKzGHF07dpksTSI7ZA3cOU+heSOK0kuT9rUqoQGfQxJcvv8OKeEiG1rADOBmIi1HCm YgutR4LTYGvNw8UjMG8bm6YMhGGxlY+1u+wFkmG2fAgABG4QyhR83nxAtzGlEagfVfkv ELYw== X-Forwarded-Encrypted: i=1; AJvYcCXCPO+u1C+BWvjKX5WWMpGXM44Ua7jYudUvVXUnKEHHYDoToBi38Jbp+HaI6746GJqJlsIeVPvw1J86cIOp2rbY@lists.infradead.org X-Gm-Message-State: AOJu0YwFhBBo7KvnnyyeHqBYVfnZcjcqV519v3vlptpF/1Dnchx7SDoj 60GniA4atE8hb7wDvqFDupVaLCucJS9ZHsZIPopsUY+UYG1KzFiTo8vHnDJsBuQ= X-Google-Smtp-Source: AGHT+IGFX+JpOuBNkuiqWpwqqojLsjyd0c1q3uUvAXvmTXay18Cll/dJEuA1ST8QE4ynzxsCiSRyHw== X-Received: by 2002:a17:907:e8d:b0:a86:6e5e:620d with SMTP id a640c23a62f3a-a897f84d602mr429881266b.27.1725014334494; Fri, 30 Aug 2024 03:38:54 -0700 (PDT) Received: from localhost (host-80-182-198-72.retail.telecomitalia.it. [80.182.198.72]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a89892220e5sm197540666b.195.2024.08.30.03.38.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Aug 2024 03:38:54 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Fri, 30 Aug 2024 12:39:00 +0200 To: Krzysztof Kozlowski Subject: Re: [PATCH 07/11] pinctrl: rp1: Implement RaspberryPi RP1 gpio support Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240830_033857_006103_1EDB2144 X-CRM114-Status: GOOD ( 28.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Catalin Marinas , Michael Turquette , Claudiu Beznea , Eric Dumazet , Dragan Cvetic , Will Deacon , linux-clk@vger.kernel.org, linux-arch@vger.kernel.org, Rob Herring , Florian Fainelli , Lee Jones , Saravana Kannan , Broadcom internal kernel review list , linux-pci@vger.kernel.org, Jakub Kicinski , Paolo Abeni , Linus Walleij , devicetree@vger.kernel.org, Conor Dooley , Arnd Bergmann , linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Bjorn Helgaas , Andrea della Porta , linux-arm-kernel@lists.infradead.org, Derek Kiernan , Stephen Boyd , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Stefan Wahren , netdev@vger.kernel.org, Krzysztof Kozlowski , "David S. Miller" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On 10:45 Wed 21 Aug , Krzysztof Kozlowski wrote: > On Tue, Aug 20, 2024 at 04:36:09PM +0200, Andrea della Porta wrote: > > The RP1 is an MFD supporting a gpio controller and /pinmux/pinctrl. > > Add minimum support for the gpio only portion. The driver is in > > pinctrl folder since upcoming patches will add the pinmux/pinctrl > > support where the gpio part can be seen as an addition. > > > > Signed-off-by: Andrea della Porta > > --- > > MAINTAINERS | 1 + > > drivers/pinctrl/Kconfig | 10 + > > drivers/pinctrl/Makefile | 1 + > > drivers/pinctrl/pinctrl-rp1.c | 719 ++++++++++++++++++++++++++++++++++ > > 4 files changed, 731 insertions(+) > > create mode 100644 drivers/pinctrl/pinctrl-rp1.c > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 4ce7b049d67e..67f460c36ea1 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -19122,6 +19122,7 @@ S: Maintained > > F: Documentation/devicetree/bindings/clock/raspberrypi,rp1-clocks.yaml > > F: Documentation/devicetree/bindings/pinctrl/raspberrypi,rp1-gpio.yaml > > F: drivers/clk/clk-rp1.c > > +F: drivers/pinctrl/pinctrl-rp1.c > > F: include/dt-bindings/clock/rp1.h > > F: include/dt-bindings/misc/rp1.h > > > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > > index 7e4f93a3bc7a..18bb1a8bd102 100644 > > --- a/drivers/pinctrl/Kconfig > > +++ b/drivers/pinctrl/Kconfig > > @@ -565,6 +565,16 @@ config PINCTRL_MLXBF3 > > each pin. This driver can also be built as a module called > > pinctrl-mlxbf3. > > > > +config PINCTRL_RP1 > > + bool "Pinctrl driver for RP1" > > + select PINMUX > > + select PINCONF > > + select GENERIC_PINCONF > > + select GPIOLIB_IRQCHIP > > + help > > + Enable the gpio and pinctrl/mux driver for RaspberryPi RP1 > > + multi function device. > > + > > source "drivers/pinctrl/actions/Kconfig" > > source "drivers/pinctrl/aspeed/Kconfig" > > source "drivers/pinctrl/bcm/Kconfig" > > diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile > > index cc809669405a..f1ca23b563f6 100644 > > --- a/drivers/pinctrl/Makefile > > +++ b/drivers/pinctrl/Makefile > > @@ -45,6 +45,7 @@ obj-$(CONFIG_PINCTRL_PIC32) += pinctrl-pic32.o > > obj-$(CONFIG_PINCTRL_PISTACHIO) += pinctrl-pistachio.o > > obj-$(CONFIG_PINCTRL_RK805) += pinctrl-rk805.o > > obj-$(CONFIG_PINCTRL_ROCKCHIP) += pinctrl-rockchip.o > > +obj-$(CONFIG_PINCTRL_RP1) += pinctrl-rp1.o > > obj-$(CONFIG_PINCTRL_SCMI) += pinctrl-scmi.o > > obj-$(CONFIG_PINCTRL_SINGLE) += pinctrl-single.o > > obj-$(CONFIG_PINCTRL_ST) += pinctrl-st.o > > diff --git a/drivers/pinctrl/pinctrl-rp1.c b/drivers/pinctrl/pinctrl-rp1.c > > new file mode 100644 > > index 000000000000..c035d2014505 > > --- /dev/null > > +++ b/drivers/pinctrl/pinctrl-rp1.c > > @@ -0,0 +1,719 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Driver for Raspberry Pi RP1 GPIO unit > > + * > > + * Copyright (C) 2023 Raspberry Pi Ltd. > > + * > > + * This driver is inspired by: > > + * pinctrl-bcm2835.c, please see original file for copyright information > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > Half of these headers are not used. Drop them. Ack. Many thanks, Andrea > > Best regards, > Krzysztof >