From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89BB3CA1002 for ; Fri, 30 Aug 2024 15:28:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H3AaOlacpjrdS6dYgrqk+vOy/n/WnhMvz5SZv0q3vtA=; b=NvQagHCqyJysMP9G+U2zKe+cKK DvP6XyCe2YtSPXEPb2xGjwg5wdsI68MpyIuptYZd4WOBQderfXVkFpvp3DaHXbCL55GeZ4skOmxzn xPekIZi//Jk3e16DPCBr9A+EItrl8Qv8BdAwh5LjcLkfzGtY19HW/MiYv+aRMMqEvMal7PTZvO+8W 2lMVis68DpsClM2OaXGFLcBuMkR4jyodeiOM8JtwT5XLFAq3qojBPdhXrP2QHUpszyvjhjm1AZ5fI 4J268sKrGPAk9vXe3kYwI3+/RYuFF/soNpJU65QguC8WqFuUvh0VP6fpdE/RqnP5XxKXth+85ODWl Iw7sTDVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sk3Xi-00000006nFF-3MG4; Fri, 30 Aug 2024 15:28:06 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sk3Wk-00000006mVx-2s5a for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2024 15:27:08 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-427fc9834deso67335e9.0 for ; Fri, 30 Aug 2024 08:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725031625; x=1725636425; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=H3AaOlacpjrdS6dYgrqk+vOy/n/WnhMvz5SZv0q3vtA=; b=bFBGOvMLn9cGadx5i8RRqqWZUhqOpCNZPf5Xpa7ken9PwNL8i5uTbq1kR5bUQ3i1pU 6xriCVyEwgDTwAEeD9+Tet6W5n2tvyuqqm1rBp41iD+7s3ogMw/IdozY3C7tV4Oe6z+r NeV538sdyYBR5RU3+X8uM8HOuTZ2q1od78dH98t7AB6b6XpxvektePU4hk55lu8abM15 W+l3mfWQeafCIpwF5n167sM26gdMGAM1aoYatYAumCMIjsB+ifCPSbgw4kv37Uvkz4z/ pzoVH4TC/2ltILOopexRXwA6GcNHI03kwV6xP3XnUnhcBC+zi4egKAsKzi+SLA/cO2WA 1s7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725031625; x=1725636425; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=H3AaOlacpjrdS6dYgrqk+vOy/n/WnhMvz5SZv0q3vtA=; b=mQR9c+KAMCzxFGUIAMbx1Ou39ppi4e4H75raL0e7AJsXdJsu7FvHWwuItahYs6UrlD bQdoijuYyzKs0V2ZlGzEMm+fFFFaw5QAjoWkNzPDY3pIORgVMIJj1G6qT7V89P1vQK8W 59AcKAHWBl4oKsZ5M30H8vambp7+ULXtlaEzHArio9xNk/7eyXEkV92ocAntEn/G9UtR 5m5UzcNo6RXKVwrM4Pgn9SAakaUx50cjd27MpgnV/UUTdKW6aYZEvBnC2xeBSr1IHvFD Z1gUFroIKbnCOYfx5Xd+ajqEhd4gqnyp/NTtslEH9ZV5M+ndbzNiLNZuAUxb8Bl2PEyk Dthw== X-Forwarded-Encrypted: i=1; AJvYcCVK0qRpOqZ+tQPUQoOuFko+gAf9ZTxvrgYuJT1uz+jN0py/ZIWxjAMar6JRluSpDozwrVrj5mc+LsN+k+CmSu3U@lists.infradead.org X-Gm-Message-State: AOJu0YwM/ZePFppF+ximll9ctSVStamu76e/oJHdfMSwKyij7wsqpnVY 3N3+sLaYn5xQy2IGO2+7tUqtzSlQHCW9++kjcdSU5Rkj+n14noCGUw5BFHA8g0cmz9ncSvkFvWS p4Q== X-Google-Smtp-Source: AGHT+IGXR29Kld8IDQGNVEA4AoJiwGiXxRFNMNP4VkTKAZ9VuEsRIqNCnFf+Xrf87qSHJgw8pR22qg== X-Received: by 2002:a05:600c:1da1:b0:42b:892a:333b with SMTP id 5b1f17b1804b1-42bbaa2b0a9mr1463235e9.2.1725031624257; Fri, 30 Aug 2024 08:27:04 -0700 (PDT) Received: from google.com (109.36.187.35.bc.googleusercontent.com. [35.187.36.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42ba7b4271fsm78764955e9.29.2024.08.30.08.27.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Aug 2024 08:27:03 -0700 (PDT) Date: Fri, 30 Aug 2024 15:27:00 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: acpica-devel@lists.linux.dev, Hanjun Guo , iommu@lists.linux.dev, Joerg Roedel , Kevin Tian , kvm@vger.kernel.org, Len Brown , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lorenzo Pieralisi , "Rafael J. Wysocki" , Robert Moore , Robin Murphy , Sudeep Holla , Will Deacon , Alex Williamson , Eric Auger , Jean-Philippe Brucker , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameerali Kolothum Thodi Subject: Re: [PATCH v2 7/8] iommu/arm-smmu-v3: Implement IOMMU_HWPT_ALLOC_NEST_PARENT Message-ID: References: <0-v2-621370057090+91fec-smmuv3_nesting_jgg@nvidia.com> <7-v2-621370057090+91fec-smmuv3_nesting_jgg@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7-v2-621370057090+91fec-smmuv3_nesting_jgg@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240830_082706_749270_D6D164E4 X-CRM114-Status: GOOD ( 19.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jason, On Tue, Aug 27, 2024 at 12:51:37PM -0300, Jason Gunthorpe wrote: > For SMMUv3 the parent must be a S2 domain, which can be composed > into a IOMMU_DOMAIN_NESTED. > > In future the S2 parent will also need a VMID linked to the VIOMMU and > even to KVM. > > Signed-off-by: Jason Gunthorpe > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > index ec2fcdd4523a26..8db3db6328f8b7 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > @@ -3103,7 +3103,8 @@ arm_smmu_domain_alloc_user(struct device *dev, u32 flags, > const struct iommu_user_data *user_data) > { > struct arm_smmu_master *master = dev_iommu_priv_get(dev); > - const u32 PAGING_FLAGS = IOMMU_HWPT_ALLOC_DIRTY_TRACKING; > + const u32 PAGING_FLAGS = IOMMU_HWPT_ALLOC_DIRTY_TRACKING | > + IOMMU_HWPT_ALLOC_NEST_PARENT; > struct arm_smmu_domain *smmu_domain; > int ret; > > @@ -3116,6 +3117,14 @@ arm_smmu_domain_alloc_user(struct device *dev, u32 flags, > if (!smmu_domain) > return ERR_PTR(-ENOMEM); > > + if (flags & IOMMU_HWPT_ALLOC_NEST_PARENT) { > + if (!(master->smmu->features & ARM_SMMU_FEAT_NESTING)) { > + ret = -EOPNOTSUPP; I think that should be: ret = ERR_PTR(-EOPNOTSUPP); Thanks, Mostafa > + goto err_free; > + } > + smmu_domain->stage = ARM_SMMU_DOMAIN_S2; > + } > + > smmu_domain->domain.type = IOMMU_DOMAIN_UNMANAGED; > smmu_domain->domain.ops = arm_smmu_ops.default_domain_ops; > ret = arm_smmu_domain_finalise(smmu_domain, master->smmu, flags); > -- > 2.46.0 >