Re: [PATCH v14 00/10] Add Tegra241 (Grace) CMDQV Support (part 1/2)

[Nicolin Chen <nicolinc@nvidia.com>]

On Fri, Aug 30, 2024 at 05:12:12PM +0100, Will Deacon wrote:

> On Thu, 29 Aug 2024 15:34:29 -0700, Nicolin Chen wrote:
> > NVIDIA's Tegra241 (Grace) SoC has a CMDQ-Virtualization (CMDQV) hardware
> > that extends standard ARM SMMUv3 to support multiple command queues with
> > virtualization capabilities. Though this is similar to the ECMDQ in SMMU
> > v3.3, CMDQV provides additional Virtual Interfaces (VINTFs) allowing VMs
> > to have their own VINTFs and Virtual Command Queues (VCMDQs). The VCMDQs
> > can only execute a limited set of commands, mainly invalidation commands
> > when exclusively used by the VMs, compared to the standard SMMUv3 CMDQ.
> >
> > [...]
> 
> Thanks for this, Nicolin! I did drop the 'default' statement in the end,
> as I think it's a bit overkill to fail the probe in that case.
> 
> Applied to will (for-joerg/arm-smmu/updates), thanks!
> 
> [01/10] iommu/arm-smmu-v3: Issue a batch of commands to the same cmdq
>         https://git.kernel.org/will/c/56ae8866f3b4
> [02/10] iommu/arm-smmu-v3: Pass in cmdq pointer to arm_smmu_cmdq_build_sync_cmd
>         https://git.kernel.org/will/c/2ea1f0120f90
> [03/10] iommu/arm-smmu-v3: Pass in cmdq pointer to arm_smmu_cmdq_init
>         https://git.kernel.org/will/c/e736c895c45b
> [04/10] iommu/arm-smmu-v3: Make symbols public for CONFIG_TEGRA241_CMDQV
>         https://git.kernel.org/will/c/a7a08b857a32
> [05/10] iommu/arm-smmu-v3: Add ARM_SMMU_OPT_TEGRA241_CMDQV
>         https://git.kernel.org/will/c/b935a5b1c670
> [06/10] iommu/arm-smmu-v3: Add acpi_smmu_iort_probe_model for impl
>         https://git.kernel.org/will/c/6f3f9ff43d00
> [07/10] iommu/arm-smmu-v3: Add struct arm_smmu_impl_ops
>         https://git.kernel.org/will/c/6de80d619203
> [08/10] iommu/arm-smmu-v3: Add in-kernel support for NVIDIA Tegra241 (Grace) CMDQV
>         https://git.kernel.org/will/c/918eb5c856f6
> [09/10] iommu/arm-smmu-v3: Start a new batch if new command is not supported
>         https://git.kernel.org/will/c/f59e85490712
> [10/10] iommu/tegra241-cmdqv: Limit CMDs for VCMDQs of a guest owned VINTF
>         https://git.kernel.org/will/c/a9d40285bdef
> 
> Cheers,

This makes my day :)

Cheers!
Nicolin