From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED7DECA1009 for ; Fri, 30 Aug 2024 19:13:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fHv0L6bwU0s7zHLuN2xRYZiqWzdsk3ar5TXeEdfUtlo=; b=LiAHlWZSkJU0Z8jAuwBnoneN8B i8nHzWDqZJGid1sCWmnCQrG4RUy9Y9IpzkrlguLrgExECY2ly05GE8HS+HCakqmZ5YzQ1pHRShGLs XePQIxv3sFLvHTlYTj8dvwjxt7fCe34iMy8pogrF/LiBRBzZubeyTdW2Zgv1OHQdAm6OumukQ7WCI Bqhh3/pnp82vSxL4PJHcJ3u342cg5NVFEDJfToiWZsk7Qg1+JvgdJwF5zPvRBAIQcM4b6Df1SrJQn JHo5ALcQaVACak1kV6vJkUYKT7KzJH4q1pXW4KZWH/oDw8Rgl2FSIm5QwU+4I5ahyMto/3gHb/poL h5ShDt8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sk73Q-00000007Q5l-0vkX; Fri, 30 Aug 2024 19:13:04 +0000 Received: from mgamail.intel.com ([192.198.163.13]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sk72W-00000007Prq-3BvZ for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2024 19:12:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725045128; x=1756581128; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=dzWh+GQLUAty+8IfUKGWuOCoAVmfzi1JX5RFpods71E=; b=QboyXIUBXnKdLLe6CoZAL0E6rFrCYJ6lN9CGUuwxu1SVssq/9Je9MLY/ NkN+BthNqkoJlCATtFNZPdQg1IZSsAfpkII6sD4W/U/9eFYjZV7ClBaF9 DFDiIwlPpelTliVLZCDSpb1b9gbUKqNCmtvR28UMvdIWHGrcH4Yxy8cYv JLDz9XfQ2gGfQXZugvrCOQr127O+QKH9MPyvv9WWOio3E5Y/2bwnvkrGP z2YcLGNNq2vXIvOyG0cUmTgexhM1HcTXNmJgRmlBZssTGsJ5uamxNZK4O LbdPGsa71/3YtEwdGH2ZXX4W8lf8De3rdOZWRSneytgNd666XMi3lhX2w A==; X-CSE-ConnectionGUID: boL4zKqARuezqFGXHsf6bQ== X-CSE-MsgGUID: mDP1aDb5TtuxZglGK3wS+A== X-IronPort-AV: E=McAfee;i="6700,10204,11180"; a="26599435" X-IronPort-AV: E=Sophos;i="6.10,189,1719903600"; d="scan'208";a="26599435" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2024 12:12:08 -0700 X-CSE-ConnectionGUID: xNbOcizQSWGEFqMOtuOdlA== X-CSE-MsgGUID: vQ6n6zePSSONSDhO+5BYLw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,189,1719903600"; d="scan'208";a="63682533" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2024 12:12:06 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1sk72R-00000003SLA-19tq; Fri, 30 Aug 2024 22:12:03 +0300 Date: Fri, 30 Aug 2024 22:12:03 +0300 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Yang Ruibin <11162571@vivo.com>, Mark Brown , Daniel Mack , Haojian Zhuang , Robert Jarzmik , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com Subject: Re: [PATCH v2] drivers: spi: Insert the missing pci_dev_put()before return Message-ID: References: <20240829033511.1917015-1-11162571@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240830_121208_832138_D497CFCB X-CRM114-Status: GOOD ( 13.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 30, 2024 at 10:55:06AM +0200, Geert Uytterhoeven wrote: > On Thu, Aug 29, 2024 at 5:35 AM Yang Ruibin <11162571@vivo.com> wrote: > > Increase the reference count by calling pci_get_slot(), and remember to > > decrement the reference count by calling pci_dev_put(). > > > > Signed-off-by: Yang Ruibin <11162571@vivo.com> > > Thanks for your patch, which is now commit 8a0ec8c2d736961f ("spi: > Insert the missing pci_dev_put()before return") in spi/for-next. Which should be reverted. Who is going to send one? I also have one revert for double applied spi-ppc44x commit. But Mark haven't replied if I need to send a v2 of that as it has Subject and first line of the commit message generated by `git revert` without editing. -- With Best Regards, Andy Shevchenko