From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E95CCA101B for ; Fri, 30 Aug 2024 22:38:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:Date:From:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FuOHjHN01pwLhTn870hGi0iyigFDRibUrDrwMdxDl98=; b=mlw/4XxtOGh6pN7N7ci0WlXc2j JAcHJ7RfpzSSF7t4Y2U45xk1EOU97ZkfqjIMG2CsBz1pFIA/QZBSaDM+1AIsFZ1reeBCDwrCGniCc n4aOe7j2GiWMzrwkNncrbITym1OcVyPR4ocT9BmPKUMooEbFrHmwwDfotPFrckqsLInvD/Z8FHapW gpf42LPY/EPMKiDItSrPsoGMc3GOEGtWLUFadJuXAYX0OJMy1cM147bcQDLbjdVkXrw9/56Au7c66 Ce+Xldu2MikaUnkcKHraC9u81Dh4r4Q33UH0hPKOGWFcPIMnd8cYwodv13mbsXSGQP/MQPckXaV6a 0qB6XZdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1skAG6-00000007vSU-0rrT; Fri, 30 Aug 2024 22:38:22 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1skA9u-00000007tr5-2G68 for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2024 22:32:00 +0000 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-533488ffaddso2978973e87.1 for ; Fri, 30 Aug 2024 15:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1725057116; x=1725661916; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=FuOHjHN01pwLhTn870hGi0iyigFDRibUrDrwMdxDl98=; b=R3TpPUhSm+D+EggAT6v9DYiBo8i/wgYGZOlmVfny6PmSzeuYIWbfkUD40fVRHL8oL6 ai+YB0U7Hkz569xlPcg1j5ikyOh4xlAu4L9Ef8K0m/hrrCrOou5nyhjh3+g0xGuSycKV clcEs4dVxtgnpaNuz+IbOePR7SdYUqKOwwzpafVn7pci5i6qXmu2bZ3wSILwnt99VLGP YGn84U0mBvoUKNwzlQBknNvPSamUc+6e2kVgU7v6aI5e65KRtLQCZTV+B07Ojgri0PEQ xhtagngBcQyHhN1bWPSxmjmN/n1voto3bbyj1NpU0t4myphssFe7j4Tnh6brIYZThasb 2S+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725057116; x=1725661916; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FuOHjHN01pwLhTn870hGi0iyigFDRibUrDrwMdxDl98=; b=Ulf9vuyS+OvfXKyl08ULl1ZUDhgNM6ffp+3H4vRGTlADTdA9rsyASx1SF0XI89llTN YPG9oIxFExlSRcAoXWqA6TAKv+nIOICl7KaaVfUW4ohhobSxeFWX0M0HYgN69Mfp8A/R ltKuy2Aadd0nkpheS7H/ywrwonPj3yMhTh/XJYgl51k0eCgF7XgFSSqK+tGBVKa8eHd2 0tsPv8toWumvYgey+jPbkZQLWGZr+ha5v64lqCpNLculUFsdQOrsWWw8JpGxQh1OuJTf x/ea0tU/4lTvpqiecEoBbIKjB52tJsbXazuvraSvSOtH7Z/W68Nw7Z25EE0ckb/ngnAC aAfA== X-Forwarded-Encrypted: i=1; AJvYcCV8tsQNY29WOPZeck9qvdPcynbGghmtaZIxZzv8pypE8hsiCfwQIftj/YOkLzn3W+XXTRe92BXNfDODHGprUdNT@lists.infradead.org X-Gm-Message-State: AOJu0YxmWblh2gtmxQ93G8vYiPfdlxLe6nhSV3P3NEZJkur0698rl8E9 ltrZZ1VltEeslBbeJ4e5bn3x6kC7qcFzU8ty0WMcOSmJMJr2JKwfly39xi4/bH0= X-Google-Smtp-Source: AGHT+IGclcXXmfEYFitTuWbyIOxJTqBHu8I4vUSw06+6AvY4Xvz0PRfaVlPP3p7/PlrqVhE+LPRQGg== X-Received: by 2002:a05:6512:3b11:b0:52c:e054:4149 with SMTP id 2adb3069b0e04-53546b052fdmr2712927e87.15.1725057115910; Fri, 30 Aug 2024 15:31:55 -0700 (PDT) Received: from localhost (host-80-182-198-72.pool80182.interbusiness.it. [80.182.198.72]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a89891d6f9esm260898466b.154.2024.08.30.15.31.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Aug 2024 15:31:55 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Sat, 31 Aug 2024 00:32:02 +0200 To: Krzysztof Kozlowski Subject: Re: [PATCH 10/11] net: macb: Add support for RP1's MACB variant Message-ID: References: <775000dfb3a35bc691010072942253cb022750e1.1724159867.git.andrea.porta@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240830_153158_585563_C288FD26 X-CRM114-Status: GOOD ( 22.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Catalin Marinas , Michael Turquette , Claudiu Beznea , Eric Dumazet , Dragan Cvetic , Will Deacon , linux-clk@vger.kernel.org, linux-arch@vger.kernel.org, Rob Herring , Florian Fainelli , Lee Jones , Saravana Kannan , Broadcom internal kernel review list , linux-pci@vger.kernel.org, Jakub Kicinski , Paolo Abeni , Linus Walleij , devicetree@vger.kernel.org, Conor Dooley , Arnd Bergmann , linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Bjorn Helgaas , Andrea della Porta , linux-arm-kernel@lists.infradead.org, Derek Kiernan , Stephen Boyd , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Stefan Wahren , netdev@vger.kernel.org, Krzysztof Kozlowski , "David S. Miller" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On 10:49 Wed 21 Aug , Krzysztof Kozlowski wrote: > On Tue, Aug 20, 2024 at 04:36:12PM +0200, Andrea della Porta wrote: > > RaspberryPi RP1 contains Cadence's MACB core. Implement the > > changes to be able to operate the customization in the RP1. > > > > Signed-off-by: Andrea della Porta > > > > @@ -5100,6 +5214,11 @@ static int macb_probe(struct platform_device *pdev) > > } > > } > > } > > + > > + device_property_read_u8(&pdev->dev, "cdns,aw2w-max-pipe", &bp->aw2w_max_pipe); > > + device_property_read_u8(&pdev->dev, "cdns,ar2r-max-pipe", &bp->ar2r_max_pipe); > > Where are the bindings? As stated in the cover letter, this patch (and the dtb patch #11 for macb) is completely unpolished and intended only for a quick test of the ethernet peripheral underneath the RP1. As such, it's not intended to be upstreamed yet. However, your feedback is really appreaciated and will be used in a future patch that will deal with ethernet mac support. > > > + bp->use_aw2b_fill = device_property_read_bool(&pdev->dev, "cdns,use-aw2b-fill"); > > + > > spin_lock_init(&bp->lock); > > > > /* setup capabilities */ > > @@ -5155,6 +5274,21 @@ static int macb_probe(struct platform_device *pdev) > > else > > bp->phy_interface = interface; > > > > + /* optional PHY reset-related properties */ > > + bp->phy_reset_gpio = devm_gpiod_get_optional(&pdev->dev, "phy-reset", > > Where is the binding? Ditto. > > > + GPIOD_OUT_LOW); > > + if (IS_ERR(bp->phy_reset_gpio)) { > > + dev_err(&pdev->dev, "Failed to obtain phy-reset gpio\n"); > > + err = PTR_ERR(bp->phy_reset_gpio); > > + goto err_out_free_netdev; > > + } > > + > > + bp->phy_reset_ms = 10; > > + of_property_read_u32(np, "phy-reset-duration", &bp->phy_reset_ms); > > Where is the binding? Ditto. Cheers, Andrea > > > + /* A sane reset duration should not be longer than 1s */ > > + if (bp->phy_reset_ms > 1000) > > + bp->phy_reset_ms = 1000; > > + > > /* IP specific init */ > > err = init(pdev); > > Best regards, > Krzysztof >