From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BEA0CA101E for ; Sun, 1 Sep 2024 07:38:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XUKwHwHeZnfMiWQx9ysnjJQqAF9uH2ywN1zSmv3u0Yw=; b=Xr1TvZDP3FFKjs48watLj/FXxr b8tw9o7QBj4cqI1PG/eP+7zbhEcwp/hexPUPUquBKHH2CtMyReTrWZjehv/xW52eg7REGTPgo3/iD 6EqVpWkmt7eNXGChH2VPX5o5RplBHuF2O6qIJs1bJibTU+XJVjDbgDZ2+783eDuETzXRSWce0gL7b 20hrXBsZ+PDOg+r7xeEy3UYYIFADKsSgoF07+u1Oje3Bvgk405r1BuvIZ/6iSfCJTPzpwL41oYd5u IPpybZ+kpRBplZJoMsgfU6C3FCULZ3tk/0nby2FSpwtHHGmNIZX27x7WZCzEH3tv1+3YMLcBtRegI 8/fC9eoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1skfA2-0000000B7an-3AWM; Sun, 01 Sep 2024 07:38:10 +0000 Received: from mail-m16.yeah.net ([1.95.21.16]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1skf99-0000000B7Xp-3hvz for linux-arm-kernel@lists.infradead.org; Sun, 01 Sep 2024 07:37:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version: Content-Type; bh=XUKwHwHeZnfMiWQx9ysnjJQqAF9uH2ywN1zSmv3u0Yw=; b=Ssy/SiYtfJuY8YrQQnXuAmU+ujDdWwc5Ej+/795nngedfvpht9mGJbjGwaxRig XIB3NBhbMZAa6RhoK/i2FchRFDkbQCRZf4zn81jql+9MSChXVBQHPcZcSK3ODn+i TSHPwOxq3leFrdb/HmTZztUCWqGJ9ytW6X5Sjy//LnQoM= Received: from dragon (unknown [114.216.210.89]) by gzsmtp3 (Coremail) with SMTP id M88vCgD3J_WbGdRmIqJCAA--.32384S3; Sun, 01 Sep 2024 15:37:01 +0800 (CST) Date: Sun, 1 Sep 2024 15:36:59 +0800 From: Shawn Guo To: Nathan Chancellor Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, llvm@lists.linux.dev, patches@lists.linux.dev Subject: Re: [PATCH] ARM: imx: Annotate imx7d_enet_init() as __init Message-ID: References: <20240822-imx7d-mark-imx7d_enet_init-as-init-v1-1-8dfadee3bed4@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240822-imx7d-mark-imx7d_enet_init-as-init-v1-1-8dfadee3bed4@kernel.org> X-CM-TRANSID: M88vCgD3J_WbGdRmIqJCAA--.32384S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7Xryxtr47tr1Dtr4DXFWrXwb_yoWfGrg_Zr 48Xw1xCr1UWw1vkw1vgFy3Aryqkw40qFy3Zrn5W3yIq34fJayvyas5G393J3s7WwsrZF98 CrW5Jr43trnFqjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU0XVy7UUUUU== X-Originating-IP: [114.216.210.89] X-CM-SenderInfo: pvkd40hjxrjqh1hdxhhqhw/1tbiCQJNZWbUDFkdrQAAs0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240901_003716_265304_3658B739 X-CRM114-Status: UNSURE ( 9.57 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 22, 2024 at 05:05:17PM -0700, Nathan Chancellor wrote: > After a recent LLVM change [1] that deduces __cold on functions that > only call cold code (such as __init functions), there is a section > mismatch warning from imx7d_enet_init(), which got moved to > .text.unlikely. as a result of that optimization: > > WARNING: modpost: vmlinux: section mismatch in reference: imx7d_enet_init+0x20 (section: .text.unlikely.) -> imx7d_enet_clk_sel (section: .init.text) > > Drop the inline keyword (which does not guarantee inlining) and replace > it with __init, as imx7d_enet_init() is only called from __init code, > which clears up the warning. > > Link: https://github.com/llvm/llvm-project/commit/6b11573b8c5e3d36beee099dbe7347c2a007bf53 [1] > Signed-off-by: Nathan Chancellor Applied, thanks!