From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3EBA2CD13CF for ; Mon, 2 Sep 2024 08:59:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rDJ3c/SnX1xtZaObviOe/fqhAy0qt+DAWX/W/IrfKf8=; b=GGEJ58hQBcgLpVKkOTTXrmztIz hM1fhzyR+xM7vd5F03n3AByoyF4v/T+UmpBXjAnY3N4jipecF0EsUWZS/jqtUVQ53enEIjj7AwgD2 4Ps1PA8PiBAyOeVmrb/xPbrJZf5dWB1lX5D5ztjOdKV3RB39EpXaQzGqkf7Y1sEIVMl1D7yJHmnl5 S/BJmrCme7IUVGQ9FjNKPrrJyolLmIfcKTbVLP28iepqCzyd2LIq3OpKR06V0lo21Y7jFXZaudD2B 4VN+LG1nU2a2hGAfsc31ZdOuyxlFGnoDWltxKj1dAyuGx5pCL8bE+o0rgHiThgWl17B1Y9qmfPT70 s5OKJH9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sl2ti-0000000DcI3-2xAY; Mon, 02 Sep 2024 08:58:54 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sl2so-0000000Dc0b-0gF6 for linux-arm-kernel@lists.infradead.org; Mon, 02 Sep 2024 08:57:59 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-42bba6a003bso61945e9.0 for ; Mon, 02 Sep 2024 01:57:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725267476; x=1725872276; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rDJ3c/SnX1xtZaObviOe/fqhAy0qt+DAWX/W/IrfKf8=; b=ecBQK7aS3KhyAsuc+dsIxuS5OFXtylpzmoEASdDy7jWAyEd+/r/AkecW6B151S58Wp uEDAHAMUtgZu452m5TX5ZLrOjzrPChS1zJCZpDjXQ86cv+Sx8DydyLdFO1QmM1mJK3Lt uJPAZJNPODcfZ16J9rJULJ3YugRXmtQfYizlnwQ5JEknlzmGTM/2PYibqQn6VDtntns7 zJxScvAaFLP/Isxyb+vYepzygN/rfvnPdH/cDUGroH8ymNSDmhmtQ69dYMI1ijZPotAF 9jO/JPBd97AOxPw16Ob6So8oVx9CNZ2EBLH2K6gpEcEcsa5K3MdiuP+mHgTlZ5pRw4r1 TQzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725267476; x=1725872276; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rDJ3c/SnX1xtZaObviOe/fqhAy0qt+DAWX/W/IrfKf8=; b=W2fMQAj8Ls5bAtke4F1361FFUzVUiH3leAR0paTG4HPLah+qPj0BLJA1fE7UBxXjlu ToNsmBDfWWU3iEap0c8N44/JVIOiPHPsfuZ/GVhLSI45j9jYbt/y0TyBzEoTZq0j5IdV BCnULvCvfVG3yE1o2Trre4ufPUfQLdrrRCyQdOyNTBhO/R1C3DrsGUpDrlIRvG9CSLsu 0MgpPcHjFJcQkab/syrIkZYwalsOe6YGd09fLkHYjUCLFAWKK51M1M9Hh7sLrz5KDHB8 AxdLkV/VhxsgZBuQ1ar3m/Uu4aMc8tX4Vsa3zYv4pD1PKuNyx9vsbktMhxO3S1EOAPRu lw/w== X-Forwarded-Encrypted: i=1; AJvYcCVrZ062cH5Kb6UiYivDAsf+q5Cji6WWO9+OjVpCTFSTs4a5X1CTHhsvO1hltLQwFsBSzzhIRjVED6fjEmOPwg4y@lists.infradead.org X-Gm-Message-State: AOJu0YyJUvDx4zzQKwUsrHIjm8UAfro/L7EHv9j5Vv3A9JNMBPywU4Af AN4yRlRieCmrleX2aXOnjJvVIJjhCT7DGYkKrCVwUhtXfGd7w7w+A5TfKEQUuQ== X-Google-Smtp-Source: AGHT+IEaLVJ/wTV51wop3m+lk/qJDgyUDoC18kpCfu1q8TvT9dKkREX0von9jbn66ji3B2gnWNgrVA== X-Received: by 2002:a05:600c:3ac8:b0:428:31c:5a4f with SMTP id 5b1f17b1804b1-42c787685fbmr1905585e9.3.1725267475261; Mon, 02 Sep 2024 01:57:55 -0700 (PDT) Received: from google.com (109.36.187.35.bc.googleusercontent.com. [35.187.36.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-374c2ffe062sm4918816f8f.29.2024.09.02.01.57.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Sep 2024 01:57:54 -0700 (PDT) Date: Mon, 2 Sep 2024 08:57:50 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: acpica-devel@lists.linux.dev, Hanjun Guo , iommu@lists.linux.dev, Joerg Roedel , Kevin Tian , kvm@vger.kernel.org, Len Brown , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lorenzo Pieralisi , "Rafael J. Wysocki" , Robert Moore , Robin Murphy , Sudeep Holla , Will Deacon , Alex Williamson , Eric Auger , Jean-Philippe Brucker , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameerali Kolothum Thodi Subject: Re: [PATCH v2 7/8] iommu/arm-smmu-v3: Implement IOMMU_HWPT_ALLOC_NEST_PARENT Message-ID: References: <0-v2-621370057090+91fec-smmuv3_nesting_jgg@nvidia.com> <7-v2-621370057090+91fec-smmuv3_nesting_jgg@nvidia.com> <20240830171817.GY3773488@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240830171817.GY3773488@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240902_015758_230244_FFEB292A X-CRM114-Status: GOOD ( 24.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 30, 2024 at 02:18:17PM -0300, Jason Gunthorpe wrote: > On Fri, Aug 30, 2024 at 03:27:00PM +0000, Mostafa Saleh wrote: > > Hi Jason, > > > > On Tue, Aug 27, 2024 at 12:51:37PM -0300, Jason Gunthorpe wrote: > > > For SMMUv3 the parent must be a S2 domain, which can be composed > > > into a IOMMU_DOMAIN_NESTED. > > > > > > In future the S2 parent will also need a VMID linked to the VIOMMU and > > > even to KVM. > > > > > > Signed-off-by: Jason Gunthorpe > > > --- > > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 11 ++++++++++- > > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > > > index ec2fcdd4523a26..8db3db6328f8b7 100644 > > > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > > > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > > > @@ -3103,7 +3103,8 @@ arm_smmu_domain_alloc_user(struct device *dev, u32 flags, > > > const struct iommu_user_data *user_data) > > > { > > > struct arm_smmu_master *master = dev_iommu_priv_get(dev); > > > - const u32 PAGING_FLAGS = IOMMU_HWPT_ALLOC_DIRTY_TRACKING; > > > + const u32 PAGING_FLAGS = IOMMU_HWPT_ALLOC_DIRTY_TRACKING | > > > + IOMMU_HWPT_ALLOC_NEST_PARENT; > > > struct arm_smmu_domain *smmu_domain; > > > int ret; > > > > > > @@ -3116,6 +3117,14 @@ arm_smmu_domain_alloc_user(struct device *dev, u32 flags, > > > if (!smmu_domain) > > > return ERR_PTR(-ENOMEM); > > > > > > + if (flags & IOMMU_HWPT_ALLOC_NEST_PARENT) { > > > + if (!(master->smmu->features & ARM_SMMU_FEAT_NESTING)) { > > > + ret = -EOPNOTSUPP; > > I think that should be: > > ret = ERR_PTR(-EOPNOTSUPP); > > Read again :) Oops, sorry about the noise. Thanks, Mostafa > > static struct iommu_domain * > arm_smmu_domain_alloc_user(struct device *dev, u32 flags, > struct iommu_domain *parent, > const struct iommu_user_data *user_data) > { > struct arm_smmu_master *master = dev_iommu_priv_get(dev); > const u32 PAGING_FLAGS = IOMMU_HWPT_ALLOC_DIRTY_TRACKING | > IOMMU_HWPT_ALLOC_NEST_PARENT; > struct arm_smmu_domain *smmu_domain; > int ret; > ^^^^^^^^^^^^^^ > > err_free: > kfree(smmu_domain); > return ERR_PTR(ret); > ^^^^^^^^^^^^^^^^^^ > > Jason