From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C299FCA0ED3 for ; Mon, 2 Sep 2024 08:45:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:Date:From:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DtFvUOlggwnSeLAOJpUbgPD+rPcosq7JSEShF0DBVDE=; b=PmvOSa3SaSPn+FFuym30fFN1e/ 57CUpmoCd341vQ3uE8rwvpGtgoJfyL1bxGeWgbhmGr0cfdRycqJYDdlxYi2qEH37AaLE3Km4VdhM2 uFBAICaPgcong+HTCOnspfD39tcXN2VHdm2+OCCaUjTxkn92BlfCXpPKcVhBhSpob2ROZrAGhB2Eb 0kXvHBLoFCJ3D6Q8mBl4/CkOJWIFNLmzdQME+GVkpeYAqeo/S5efGqG20W0tYTWSzLzXjMe60+BKk p25LJReqZ7VmgJV+46ABExowEXTgWh/hazvOGdZAxOPoAq0lSYuSwnuYp37/hmUGurJZaGxIjRqhl bGzu9nuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sl2gV-0000000DZOd-3o4K; Mon, 02 Sep 2024 08:45:15 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sl2fc-0000000DZEk-0qaM for linux-arm-kernel@lists.infradead.org; Mon, 02 Sep 2024 08:44:21 +0000 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5c0aa376e15so2152243a12.1 for ; Mon, 02 Sep 2024 01:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1725266658; x=1725871458; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=DtFvUOlggwnSeLAOJpUbgPD+rPcosq7JSEShF0DBVDE=; b=PLFENn3/0fSh9UrbOcG5fHH8R2M+agBFAD9coFheO4bsAyQ8Ea7Xl2gEyRmVTHn9PM rRj54xIonxFjJzi4vFU/tXz2ubgBoGqRJCd+QB0593w0tA7lCqVpdINeOyJasa1VSQSY WHt1VpN98WpvokzPxesNNOs2MUWMiIkOK9BXHQICdToqXKm13oEMlOb9l7aNFXq+EH5e 40aL3IkRvandsqX0PR1kza2wyvivWd30llLNANkhAOeszLdg+b+boDWDmnahLG99Tch+ Z756k6aDhMWsJT2Pq++Rtipk2JIntgNnAa0fwYr0lsspiDkVhG4PcBtgshoZc7IiYUQg lCDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725266658; x=1725871458; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DtFvUOlggwnSeLAOJpUbgPD+rPcosq7JSEShF0DBVDE=; b=aXsw9B1btn8CX6m7PUT031twUtJKL3th1O72GKzO7gsxoBB+BXMOfBKMC4tFoAGbxG 7edkB3xxgZnUhXfA+2rYXM1gqL9dzWGENBQ79VglGPiDOvzL1Hvg/pQX2CIy63C1wwYj OrNgBngIfSJtg9Ipy3i2UoIF0BQ7yhaVkY6mvu20gi322ouiKPd8zsNztCTwUqkgaAOn vLpjj7xTk++q2ElEzY830A07cNBmTN4qfnKbyR8ynlz1W513IGBQJgxXfgCN3TpR+UTJ 2OSyvTdLQj0zLETH3GCcA3kQfjFElXCB1GN8BkYMinQtgg10uSzB/pVsT4fBMZahWsJA UFDA== X-Forwarded-Encrypted: i=1; AJvYcCUo95aSjrx7/vfJpdPy/C3aLw/TT1TYaGmNA1Jc9nmurZzapFHG8pK+ShGbIDYS4MmPv0S0dB3/94CoC6tbm7sC@lists.infradead.org X-Gm-Message-State: AOJu0YxFo5pQSysjVnao8Ryzj52vHCBhlGdrS0TXrCZ2OPmdZOAYAxdm 62tdOP3nbwszFpyFDfOYpaGhB5IKkdWxTui2e9t49bZKJLPScoIV9Gev+3qp8yU= X-Google-Smtp-Source: AGHT+IG98mGI6ewy00GdXcZOqWLixBDXOEPu/wYdqw/JNaxYhNTMsSkYAS1b2LLsz7REgS8Iyi90kg== X-Received: by 2002:a05:6402:40ca:b0:5be:9bc5:f6b4 with SMTP id 4fb4d7f45d1cf-5c21ed315fbmr13546644a12.8.1725266657478; Mon, 02 Sep 2024 01:44:17 -0700 (PDT) Received: from localhost (host-80-182-198-72.retail.telecomitalia.it. [80.182.198.72]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c226c7c1f7sm4978743a12.42.2024.09.02.01.44.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Sep 2024 01:44:17 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Mon, 2 Sep 2024 10:44:24 +0200 To: Krzysztof Kozlowski Subject: Re: [PATCH 02/11] dt-bindings: pinctrl: Add RaspberryPi RP1 gpio/pinctrl/pinmux bindings Message-ID: References: <82d57814075ed1bc76bf17bde124c5c83925ac59.1724159867.git.andrea.porta@suse.com> <5zlaxts46utk66k2n2uxeqr6umppfasnqoxhwdzah44hcmyfnp@euwjda6zk5rh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240902_014420_262297_5D7FBCD1 X-CRM114-Status: GOOD ( 22.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Catalin Marinas , Michael Turquette , Claudiu Beznea , Eric Dumazet , Dragan Cvetic , Will Deacon , linux-clk@vger.kernel.org, linux-arch@vger.kernel.org, Rob Herring , Florian Fainelli , Lee Jones , Saravana Kannan , Broadcom internal kernel review list , linux-pci@vger.kernel.org, Jakub Kicinski , Paolo Abeni , Linus Walleij , devicetree@vger.kernel.org, Conor Dooley , Arnd Bergmann , linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Bjorn Helgaas , Andrea della Porta , linux-arm-kernel@lists.infradead.org, Derek Kiernan , Stephen Boyd , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Stefan Wahren , netdev@vger.kernel.org, Krzysztof Kozlowski , "David S. Miller" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On 13:46 Fri 30 Aug , Krzysztof Kozlowski wrote: > On 30/08/2024 12:22, Andrea della Porta wrote: > > Hi Krzysztof, > > > > ... > > >>> +#define RP1_USBHOST0_AXIS_BASE 0x200000 > >>> +#define RP1_USBHOST1_AXIS_BASE 0x300000 > >>> +#define RP1_EXAC_BASE 0x400000 > >>> + > >>> +/* Interrupts */ > >>> + > >>> +#define RP1_INT_IO_BANK0 0 > >>> +#define RP1_INT_IO_BANK1 1 > >> > >> Also no, interrupt numbers are not considered bindings. That's too much > >> churn. Otherwise, please point me to driver code using the define > >> (directly! that's the requirement). > > > > As mentioned above, RP1_INT_END is used in rp1-pci.c. To get rid of all those > > Number of interrupts is not a binding, either. Does not appear in the DTS. Ack. > > > macroes from dt-binding would mean to hardcode the interrupt number in both > > the binding example and in dtso, from this: > > > > interrupts = , > > , > > ; > > > > to this: > > > > interrupts = <0 IRQ_TYPE_LEVEL_HIGH>, > > <1 IRQ_TYPE_LEVEL_HIGH>, > > <2 IRQ_TYPE_LEVEL_HIGH>; > > > > is this what you are proposing? > > Yes, just like every DTS does. I think the hard-coding of numbers is not > a problem. Ack. Regards, Andrea > > Best regards, > Krzysztof >