From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91374CD13CF for ; Mon, 2 Sep 2024 05:38:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MQ7nhItI8VmPcJbkkl0nLAZengIZ/zDRojcMk7WM8B8=; b=i6GlWdP7Fo2rDrgmmJ3jSKwE8X oQdsqetWIA6SR6Cw6lwl2PgEXRLNiUBjVIKIWK98snjN0m1lo937m39nOM0wyKo39dd3HBqjfootD 5NLTCXFtzy3reIyqV7/GcZB2eudt9EMyjajz8fiGHa0imYZwule/9+ygMfvvXZnLSjTfuoSHDaXvr 36OiYdGQZ3QtcpjO4blv5juc3F0SvbzqZwEjs3IOC94DdfkIQTDP/nllVBYRnDnxrLj/vNwtbbXxX jyaLSDmFsXl5XD8cmQFcqT+2K2qe5SXZj6E61zSImea1fUcACZAzBcBVmTIcMFWh1NpBZejwSc7m1 VdEGTBNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1skzl9-0000000D2zi-2Rii; Mon, 02 Sep 2024 05:37:51 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1skzkH-0000000D2ph-0LvG for linux-arm-kernel@lists.infradead.org; Mon, 02 Sep 2024 05:36:58 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-427fc9834deso54855e9.0 for ; Sun, 01 Sep 2024 22:36:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725255415; x=1725860215; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MQ7nhItI8VmPcJbkkl0nLAZengIZ/zDRojcMk7WM8B8=; b=24+7ef7WgmfaLu7q4oXQilzuNKqeK42UyWCBoVtMQ6bU/LPGl/YPiZkb9dPcZvez4e sSoHXWSkShfFDukZ05bofmNKuohc8YTQNWIVs+I54X7GpMPr0kBtJxdXQKtshhcAw+eO 3EdIb6Q6SeEYi1SZWzDbmj7F0uzDQ33ftYBKgCyohgsoaufPuIF2EZDBnncHXOikmADb CsflfgJ0dDlvnzx5u4r9puhyIhoCikduPhzYwxoD1oDCMJVA42pNtxqt7+8POKhkpdYl k7gKZ+/01SMH2XJSEH8qe9RvLT82WiXU+4uj5IjMBlgPwpmgAY8vFZP2xLjMAeriIpBh 3Z9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725255415; x=1725860215; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MQ7nhItI8VmPcJbkkl0nLAZengIZ/zDRojcMk7WM8B8=; b=ld5M1Yeicru9bh41DIUT2aGoj2Wq5xh/dKeYI5axpA4MRsDjAyLnL8V3AtAW7T+uET pkih/oEkrukeyiQ+PPBWkyjqywmrjpQwDftOGsxO+RoKkz5IFItkdgN5m1dNSScSiUp3 tcWHqCyr9SFt55i9wSsB4Db1pmg6SIuYdKzLEhoifCYI34g/SzY3D2XvW0WwUNaTiUxt M6IxbLBYH21eN+7lSDRgEc++QrJotQ5cbZaLD24txXL3ZO0VzvsGtIK1BJsW1X7H3VuH tQkjMNC9wOX0SsT5bSwNShCaGa1gBq8lnt+C3wrGfmyD+U5Jqh/03+3/c5nWuNtJFbEo 7lfQ== X-Forwarded-Encrypted: i=1; AJvYcCVGabhjeYW905H9MnJryreVuI9lMK1ictqlRL9Fa/t8b1yiI2VUU2E+W6iW5QGLdOd718ytd7NLfFjxfGqdlud1@lists.infradead.org X-Gm-Message-State: AOJu0Yw0ihRKXiIJ9/0zCh08mOPJZ3821RMPZJdaW+qz/vi3ifD1809i xLe5sYsjXoNFW1giwYxWIoCNT/rBtGnoUf5/+cfWtejmVFHErVHG5KAM+WVUDg== X-Google-Smtp-Source: AGHT+IGH0lniufb3F4A3bPXzpfW2OpZ/dm4ZIb2y+w4AUpvlVhKTQmc4hKWVFLY4JC77+3GFg8WYZA== X-Received: by 2002:a05:600c:c15:b0:426:68ce:c97a with SMTP id 5b1f17b1804b1-42c787718b8mr1641265e9.7.1725255415043; Sun, 01 Sep 2024 22:36:55 -0700 (PDT) Received: from google.com (44.232.78.34.bc.googleusercontent.com. [34.78.232.44]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42c846d2fdesm11837575e9.22.2024.09.01.22.36.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Sep 2024 22:36:54 -0700 (PDT) Date: Mon, 2 Sep 2024 05:36:53 +0000 From: Sebastian Ene To: Marc Zyngier Cc: akpm@linux-foundation.org, alexghiti@rivosinc.com, ankita@nvidia.com, ardb@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, james.morse@arm.com, vdonnefort@google.com, mark.rutland@arm.com, oliver.upton@linux.dev, rananta@google.com, ryan.roberts@arm.com, shahuang@redhat.com, suzuki.poulose@arm.com, will@kernel.org, yuzenghui@huawei.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v9 2/5] arm64: ptdump: Expose the attribute parsing functionality Message-ID: References: <20240827084549.45731-1-sebastianene@google.com> <20240827084549.45731-3-sebastianene@google.com> <868qwew5xn.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <868qwew5xn.wl-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240901_223657_145140_C2CA4200 X-CRM114-Status: GOOD ( 19.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 30, 2024 at 01:28:36PM +0100, Marc Zyngier wrote: > On Tue, 27 Aug 2024 09:45:45 +0100, > Sebastian Ene wrote: > > > > Reuse the descriptor parsing functionality to keep the same output format > > as the original ptdump code. Hello Mark, > > This sentence seems either out of place or missing something, because > this change it not reusing anything... > > > In order for this to happen, move the state > > tracking objects into a common header. > > ... but instead doing this ^^^. > > I propose to rewrite the commit message as: > > "Adding a new page-table dumper for stage-2 requires parsing the page > tables, and reusing the descriptor parsing functionality would help > keeping the same output format as the original ptdump code. > > In order for this to happen, move the state tracking object > definitions into a common header." Thanks for the feedback, I think the re-wording works much better and I'll make use of it. > > Shout if you object to it! > > Thanks, > > M. > Seb > -- > Without deviation from the norm, progress is not possible.