From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33708CA0ED3 for ; Mon, 2 Sep 2024 06:12:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Qt/pdhmIWCaDpBvzCVUeydNCVwTTuBE7DiHS/h0oVUg=; b=UIFqsfYhB54zzi4vkSmmTKYIN8 BCMBqYu8mfWi8xYczUgReXAH1gKY2qqv/jcZdxq9A10cKUes99K7aWNWIWYTLT6UZyCkEX2vSwTPE cEmkx4cihuT+RTDuAh1zP+UsNYShCKiBqREw2ZmGo9ItdEwp6DwHMyQAKbQloXm/8YdYsljAge2fE kuaxSojWar4pcIJNi/isGwWkGm+ZNoVq1XLpLYV786t1BqtBPjzv1JJv/OPdzRUTUSptrW04tHF8x sbeZVBZR9ORhjuUFVdLt7Um7U4MpPr3GQMVyPZnpk+8AwrpQBJhlik0lNBujSacTiXZhmHPI89+Gw 8fIIBZSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sl0IJ-0000000D73y-3BXE; Mon, 02 Sep 2024 06:12:07 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sl0HN-0000000D6uy-2UKY for linux-arm-kernel@lists.infradead.org; Mon, 02 Sep 2024 06:11:14 +0000 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-427fc9834deso55915e9.0 for ; Sun, 01 Sep 2024 23:11:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725257467; x=1725862267; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Qt/pdhmIWCaDpBvzCVUeydNCVwTTuBE7DiHS/h0oVUg=; b=MRHItWTSe0YvLWKJtUTOSMckmtORyqTmiS18Lj6+1JJ80J5as33gi05oVz03eK+57i XUb936xiXikc5ia1jPFPVXTIHg5JLgwktKsyCh8N/HMR/fJcDjcUX14Mpn+2wSEOqT+j ih/PYk6JFbIJXXwESHQbA/vry9FoK2hRhS2D7/1sH86tROK9IdV1wN4ondDBbXuFx0c3 bal4mpbE9tinEQzKNv0NZMKEQdVFvnVf1z+i0bEp9vOpolMYhuxn5l4HL8oVNq5tYUdT Aell+/sW+WvCdCS50sFwrAWMOpVQBhqFJ8zS6Xir3Lq1NpsS8SN3ILQUEWKIsJbGKhDM IKXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725257467; x=1725862267; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Qt/pdhmIWCaDpBvzCVUeydNCVwTTuBE7DiHS/h0oVUg=; b=aF4vd4luEjowi5P1LVyqCvmj+PCpQ/iiPdTkDexyslSFgGFDiR86xp+2ITiuXYqiG1 gqOpqrc9NF2bsZZFHjGLaSVYA/S3qvJNY3HW0MOsbvq1vefUmZh17l9dBNBxT34w3u0l BdTNYRrj4s+i9Bid88u+O1JxKssgkek46b0qfN9sWd7LSSqqgqfivf1Duabn/+9lxSj+ TkU9nv4GVymeglfTz87DRCJVUtStW3NwsXQCPWhVLkZZDAqG4HJ4fXl485NYMkjqAQax jC8mhLZtKUbjTVx38Tl1yWhiiod6rkiQym+Ah6pUOcKjkPz6qG5nJ2wY+ASx9npubhHW CR9A== X-Forwarded-Encrypted: i=1; AJvYcCWWcWvi9Qq0kP/Nj5F+Q5V0L0XSBTS665ERh6KQHNRgPY0eSI4f6WZGXZt7usxqSV/sf+jufjeTfPpepfoTEmMU@lists.infradead.org X-Gm-Message-State: AOJu0YzBcT8JXNCxTKp2H2smw1ypj0zFklqBmTzth3c397+rJNLqwPEr mEKzjZRGW2VqPadRfvs5JSqwg9ss79Wam3h8+t+Su8EGIG7knwRtJhicnx471Q== X-Google-Smtp-Source: AGHT+IHKtVCpGX9bH5U9KFiXdwjXiY8dpd2rUZf/jifFQW9iyvTCQi9VEs44YJiTljvwor2vaDBCZQ== X-Received: by 2002:a05:600c:34c9:b0:42b:892a:333b with SMTP id 5b1f17b1804b1-42c2e54127emr1907065e9.2.1725257466373; Sun, 01 Sep 2024 23:11:06 -0700 (PDT) Received: from google.com (44.232.78.34.bc.googleusercontent.com. [34.78.232.44]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-374b67ff88dsm7477026f8f.26.2024.09.01.23.11.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Sep 2024 23:11:06 -0700 (PDT) Date: Mon, 2 Sep 2024 06:11:04 +0000 From: Sebastian Ene To: Marc Zyngier Cc: akpm@linux-foundation.org, alexghiti@rivosinc.com, ankita@nvidia.com, ardb@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, james.morse@arm.com, vdonnefort@google.com, mark.rutland@arm.com, oliver.upton@linux.dev, rananta@google.com, ryan.roberts@arm.com, shahuang@redhat.com, suzuki.poulose@arm.com, will@kernel.org, yuzenghui@huawei.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v9 0/5] arm64: ptdump: View the second stage page-tables Message-ID: References: <20240827084549.45731-1-sebastianene@google.com> <864j72vzmw.wl-maz@kernel.org> <8634mmvyx0.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8634mmvyx0.wl-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240901_231110_308244_03A1D15F X-CRM114-Status: GOOD ( 25.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 30, 2024 at 04:00:11PM +0100, Marc Zyngier wrote: > On Fri, 30 Aug 2024 15:44:39 +0100, > Marc Zyngier wrote: Hello Marc, > > > > Hi Seb, > > [...] > > > I've been giving this a go on my test systems with 16k pages, and it > > doesn't really work as advertised: > > > > root@babette:/sys/kernel/debug/kvm# cat 2573-13/stage2_* > > 2 > > ---[ Guest IPA ]--- > > 0x0000000000000000-0x0000000008000000 128M > > 0x0000000008000000-0x00000000090a0000 17024K 3 > > 0x00000000090a0000-0x00000000090a4000 16K 3 R W X AF > > 0x00000000090a4000-0x000000000a000000 15728K 3 > > > > Only 16kB mapped? This is a full Linux guest running the Debian > > installer, and just the kernel is about 20MB (the VM has 4GB of RAM, > > and is using QEMU as the VMM) > > > > So clearly something isn't playing as expected. Also, this '128M' > > without a level being displayed makes me wonder. It is probably the > > QEMU flash, but then the rest of the addresses don't make much sense > > (RAM on QEMU is at 1GB, not at 128MB. > > > > On another system with kvmtool, I get something similar: > > > > root@duodenum:/home/maz# cat /sys/kernel/debug/kvm/*/stage2_* > > 2 > > ---[ Guest IPA ]--- > > 0x0000000000000000-0x0000000001020000 16512K 3 > > 0x0000000001020000-0x0000000001024000 16K 3 R W X AF > > 0x0000000001024000-0x0000000002000000 16240K 3 > > > > and kvmtool places the RAM at 2GB. Clearly not what we're seeing here. > > > > Could you please verify this? Ughh, this doesn't look right. I will give it a spin with a different granule, thanks for bringing me to attention. I will look first at mm/ptdump.c if it works as intended. > > For the record, on a 4kB host, I get much more plausible results: > > root@big-leg-emma:/home/maz# cat /sys/kernel/debug/kvm/632-12/stage2_* > 3 > ---[ Guest IPA ]--- > 0x0000000000000000-0x0000000000200000 2M 2 R AF BLK > 0x0000000000200000-0x0000000040000000 1022M 2 > 0x0000000040000000-0x0000000040200000 2M 2 R W X AF BLK > 0x0000000040200000-0x0000000044000000 62M 2 > 0x0000000044000000-0x0000000044200000 2M 2 R W X AF BLK > 0x0000000044200000-0x0000000047600000 52M 2 > 0x0000000047600000-0x0000000047800000 2M 2 R W AF BLK > 0x0000000047800000-0x0000000047e00000 6M 2 R W X AF BLK > 0x0000000047e00000-0x0000000048000000 2M 2 R W AF BLK > 0x0000000048000000-0x00000000b9c00000 1820M 2 > 0x00000000b9c00000-0x00000000b9e00000 2M 2 R W X AF BLK > 0x00000000b9e00000-0x00000000bb800000 26M 2 > 0x00000000bb800000-0x00000000bba00000 2M 2 R W X AF BLK > 0x00000000bba00000-0x00000000bbe00000 4M 2 R W AF BLK > 0x00000000bbe00000-0x00000000bc200000 4M 2 R W X AF BLK > 0x00000000bc200000-0x00000000bc800000 6M 2 R W AF BLK > 0x00000000bc800000-0x00000000be400000 28M 2 > 0x00000000be400000-0x00000000bf800000 20M 2 R W X AF BLK > 0x00000000bf800000-0x00000000bfe00000 6M 2 R W AF BLK > 0x00000000bfe00000-0x00000000c0000000 2M 2 R W X AF BLK > > So 16kB is the one that needs investigating, and I strongly suspect > that 64kB is in the same boat... > > Thanks, > > M. (signing off for the day) > Thanks, Sebastian > -- > Without deviation from the norm, progress is not possible.