From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47738CA0ED3 for ; Mon, 2 Sep 2024 09:23:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:Date:From:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1ZDs/9l3dOZ4/JRpcNDnT31Gwsua2/3rtLsltEu9Mww=; b=pMjtqWcNWcGnTnzIgNDc9qlmTG pnahIXfOyAYPA4i1Gj6HO9EiAxvUQvE7d30hbuaBrADpYmBkFnVtJKJ/f0QK88S604CZBzEO1rZp7 EkwDipYyJbXFYgrQiRWoGQGcflaVorO6x1V5J/aoPrpgxUsMvLFKm5pW3WkUZkU242/1Pd+KiT23H 7fmqreksq45amgv7ZHpWzuW8YNkNfMJaixvPrCH6LtC+f3luTis3ylxo9bZ98dQUJ+K4RZiaDQYok apMcb1aVgQZXi8jPizTwzSCQ5YEsBmcl3pstQNEQyh4RTO2ZmXcJew5zdyoe6c/6wZZAbhf+f+SLy E/X7Thvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sl3HR-0000000Dgd0-2kYv; Mon, 02 Sep 2024 09:23:25 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sl3Fg-0000000Dg6C-3K8b for linux-arm-kernel@lists.infradead.org; Mon, 02 Sep 2024 09:21:44 +0000 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a89c8db505bso189746566b.0 for ; Mon, 02 Sep 2024 02:21:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1725268894; x=1725873694; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=1ZDs/9l3dOZ4/JRpcNDnT31Gwsua2/3rtLsltEu9Mww=; b=CKh6bJfXZsmm4K/LyJW6ck7cWNcFiYp5FoY8tYBJyYSLndjaAfHu7+z+G2tVjNBlT0 5UkmPBLbBRkM04UXBBInVAzkw+KJo2m8s1LkWmVjsvw6WQpHVK4qw7MWbx2wRorVj6/v fgwt+MOCIye8fNZVyqC2poslqSmgHpB6d2AdFVwuyzF46yvB/+S/Xw3RLEF31TT9n1Nb hqp4SG79ITYMCdXafk2519iUnMerHPNK3jg7xaOkH+ClCxAJ9AzK8Op8x6hxKoRRwAw8 FtnwwAnlI4lPMcR2aBN5kUNlVOQQq4nbxNC2YS4yjVUDRraYdZoh3YBpnWE56pIsimJm zdUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725268894; x=1725873694; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1ZDs/9l3dOZ4/JRpcNDnT31Gwsua2/3rtLsltEu9Mww=; b=DXTBAyKwlUmDjjue0dMKW8cmugwTJn08vT6LKxPXf9rnsxmbynLHXb/eh+RH5f08gN dKZDpUZ3+D3nOvqO/7/4naj/ghjYchTa0MTi5IQ85esmHGTQT4iWz4h3FNWqEgDSy2Hr 7to5UwhT3s8fYMMu8ySeKyPL3Ctkt0n4ihJxI8XnLtp86w7cwv6tWuZCwVkpN2IOb6Vr 3U3o8xhke9z0XqyUvPoKSeO3j7Q60iOhepc2ohQPyODJxC9qeolY394MGun1XU7ztuQ2 U1LnI9S+gonyzR9iuEo0KokjoUVlogCLnI7IYyPmSAjYKDzbVqYGAHfjAQfG3icOyIOU 53PA== X-Forwarded-Encrypted: i=1; AJvYcCWLuXVGT9OkwIZeFQRCzxSM/iSwr0a02gI1OxOd1Xd9jEWDWpj9CqMdfd89Z3f323Y/XXT2mZEptgpTDaMdpNUg@lists.infradead.org X-Gm-Message-State: AOJu0YzlC5692osR94ExCcXTvGwHjxxFnP/GECU5mZvp6LqO1ZfJtlqo cxkjPMQmuxW0IZyRnd3Yj9XLY4S78rrQpfesN+UT2Jg1LSg/4D9QVaVDVtl8Ayw= X-Google-Smtp-Source: AGHT+IFiJyKI83M4pAEH+bJt4D+2x9ZKVCIWaumLPxOS3x0JckDJtyYxve6HAvVZNlN6e2kKZafDDw== X-Received: by 2002:a17:907:6094:b0:a7a:adac:57d5 with SMTP id a640c23a62f3a-a897f84d7efmr930072566b.18.1725268894023; Mon, 02 Sep 2024 02:21:34 -0700 (PDT) Received: from localhost (host-80-182-198-72.retail.telecomitalia.it. [80.182.198.72]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a89891db42fsm527788266b.184.2024.09.02.02.21.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Sep 2024 02:21:33 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Mon, 2 Sep 2024 11:21:41 +0200 To: Andrew Lunn Subject: Re: [PATCH 00/11] Add support for RaspberryPi RP1 PCI device using a DT overlay Message-ID: References: <14990d25-40a2-46c0-bf94-25800f379a30@kernel.org> <45a41ed9-2e42-4fd5-a1d5-35de93ce0512@lunn.ch> <334b382a-c9ab-47e4-b860-b8477f04c3fb@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <334b382a-c9ab-47e4-b860-b8477f04c3fb@lunn.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240902_022138_848548_8265E029 X-CRM114-Status: GOOD ( 23.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Michael Turquette , Claudiu Beznea , Eric Dumazet , Dragan Cvetic , Will Deacon , linux-clk@vger.kernel.org, linux-arch@vger.kernel.org, Rob Herring , Florian Fainelli , Lee Jones , Krzysztof Kozlowski , Saravana Kannan , Broadcom internal kernel review list , linux-pci@vger.kernel.org, Jakub Kicinski , Paolo Abeni , Linus Walleij , devicetree@vger.kernel.org, Conor Dooley , Arnd Bergmann , linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Bjorn Helgaas , Andrea della Porta , linux-arm-kernel@lists.infradead.org, Derek Kiernan , Stephen Boyd , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Stefan Wahren , netdev@vger.kernel.org, Krzysztof Kozlowski , "David S. Miller" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrew, On 16:10 Fri 30 Aug , Andrew Lunn wrote: > > On a second thought, are you really sure we want to proceed with the header file? > > After all the only line in it would be the extern declaration and the only one to > > include it would be rp1-dev.c. Moreover, an header file would convey the false > > premise that you can include it and use that symbol while in fact it should be > > only used inside the driver. > > OTOH, not creating that header file will continue to trigger the warning... > > The header file does not need to be in global scope. It could be in > the driver source directory. As such, nothing outside of the driver > can use it. Ack. > > Headers like this have multiple proposes. One is they make a symbol > visible to the linker. But having two different .c files include the Hmm... not sure what second file is including it, since only rp1_pci.c needs it. > header enables type checking, which for long term maintenance is just > as important. So a one line header is fine. Done. Cheers, Andrea > > Andrew >