Re: [PATCH v8 04/11] PCI: imx6: Rename imx6_* with imx_*

Bjorn Helgaas
2024-09-03T19:38:54Z

On Mon, Jul 29, 2024 at 04:18:11PM -0400, Frank Li wrote:
> Since this driver has evolved to support other i.MX SoCs such as i.MX7/8/9,
> let's rename the 'imx6' prefix to 'imx' to avoid confusion. But the driver
> name is left unchanged to avoid breaking userspace scripts

s/let's//

It's not a proposal, it's what the patch *does*.

s/But the driver name is left unchanged/Leave the driver name unchanged/

s/scripts/scripts./ (add period)

> -#define IMX6_PCIE_FLAG_IMX6_PHY BIT(0)
> -#define IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE BIT(1)
> -#define IMX6_PCIE_FLAG_SUPPORTS_SUSPEND BIT(2)
> -#define IMX6_PCIE_FLAG_HAS_PHYDRV BIT(3)
> -#define IMX6_PCIE_FLAG_HAS_APP_RESET BIT(4)
> -#define IMX6_PCIE_FLAG_HAS_PHY_RESET BIT(5)
> -#define IMX6_PCIE_FLAG_HAS_SERDES BIT(6)
> -#define IMX6_PCIE_FLAG_SUPPORT_64BIT BIT(7)
> +#define IMX_PCIE_FLAG_IMX_PHY BIT(0)
> +#define IMX_PCIE_FLAG_IMX_SPEED_CHANGE BIT(1)
> +#define IMX_PCIE_FLAG_SUPPORTS_SUSPEND BIT(2)
> +#define IMX_PCIE_FLAG_HAS_PHYDRV BIT(3)

Good opportunity to fix the whitespace errors while renaming these.
IMX_PCIE_FLAG_IMX_SPEED_CHANGE and IMX_PCIE_FLAG_HAS_PHYDRV end up
with the wrong indentation.

> -#define imx6_check_flag(pci, val) (pci->drvdata->flags & val)
> +#define imx_check_flag(pci, val) (pci->drvdata->flags & val)
>
> -#define IMX6_PCIE_MAX_CLKS 6
> +#define IMX_PCIE_MAX_CLKS 6

Could also make these look nicer.

We can touch these up, no need to repost.