From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2EAD7CD342F for ; Tue, 3 Sep 2024 05:19:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bTKtworgaiEsdSnCBJDp7J7YlVXvBMfMILS4vXfQXjk=; b=eMiKkOm9tynaIw0N54HQeWeTYa gCjlBcEGmzrv7SUoh/KsISUcpPfvziBu/Df4reeMmpSID+z3FPRlHtavrUovHPzqi/O60fRgD5P7g mTIluAYoCM723zapgdXTQXPWJYyxcaDQ+tqmYrQQNw4qr15olX6/t+5hYfKPm71hY4I9k2nCvKW3/ br8Lp4YTJcwl8XBhSEMu9G91mZ5U6MdPZKH5wF02k6H/Godb2saHAm/DP+XfhoA2sNVixF7GBOGUX vvl2hmu7u/C4pSKqQO11Sy98G8zx2xszTcrigSuZJ/M6xT4dBW+dnvBZslyATVdC2O+2kJxlUby5/ 5WSZQcWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slLx4-0000000GMLo-3vVE; Tue, 03 Sep 2024 05:19:39 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slLwB-0000000GMDC-0T7K for linux-arm-kernel@lists.infradead.org; Tue, 03 Sep 2024 05:18:44 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 76C145C599B; Tue, 3 Sep 2024 05:18:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14CF9C4CEC5; Tue, 3 Sep 2024 05:18:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725340719; bh=4bXI3Y8VgVB+Lkxuh2fA0DFR+CCa5qj8nePbkreELfo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JzHn2DmNQ6IBXWBJpx/ch9sp5m81g75P1sV5za2Wvos4a6t41IZjSkMGrrnb6RdZZ BvPUMF1psE5woM+DTarNamh0vgYzJo5usn5p1oN3uHGPVpjKKvXCJXeRXB16l0b0FT iOcBNb7rTEXka1XtaIKvIhukBn+3PAlw3oI9qoiQxffg0/TK/OqiaFU+nJ6IoJOZ3M lYiofQu89Kryk8Xugz9jNPp4JwTXYwCW6IcYRUS0pfpP5f+K+WpXj0ce7MiFQbBRIy 89CsReNJH4xZQZUducx2Zm1W4o4YhRZXiRF/O2Ay5GfH5aKvmBieMgwVAIaOh/uypw udiZhsGmZZ1uA== Date: Tue, 3 Sep 2024 10:48:35 +0530 From: Vinod Koul To: Krzysztof Kozlowski Cc: Liao Yuanhong , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: Re: [PATCH v2 0/7] dmaengine:Use devm_clk_get_enabled() helpers Message-ID: References: <20240830094118.15458-1-liaoyuanhong@vivo.com> <6829a2e4-f7e0-4f34-8702-e00b005e9e0c@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6829a2e4-f7e0-4f34-8702-e00b005e9e0c@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240902_221843_230092_DF5DB166 X-CRM114-Status: GOOD ( 13.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30-08-24, 20:11, Krzysztof Kozlowski wrote: > On 30/08/2024 11:41, Liao Yuanhong wrote: > > The devm_clk_get_enabled() helpers: > > - call devm_clk_get() > > - call clk_prepare_enable() and register what is needed in order to > > call clk_disable_unprepare() when needed, as a managed resource. > > > > This simplifies the code and avoids the calls to clk_disable_unprepare(). > > --- > > v2:remove inappropriate modifications, configure COMPILE_TEST for easy > > testing, add devm_clk_getprepaed() for imx sdma device. > > --- > > > > Vinod, > > Since ~2 weeks there is tremendous amount of trivial patches coming from > vivo.com. I identified at least 6 buggy, where the contributor did not > understand the code. Not sure about intention, but I advise extra > carefulness > when dealing with these "trivial" improvements. Agree, these are introducing bugs as well.. Vivo folks, please channel your energies into fixing some real problems, contributing support for your vivo phones including DT, drivers and running mainline on them... That would be better use of your and our time :-) BR -- ~Vinod