* [PATCH 2/2] dt-bindings: arm: fsl: drop usage of VAR-SOM-MX8MM SoM compatible alone
2024-09-02 7:52 [PATCH 1/2] arm64: dts: imx8mm-var-som: drop unused top-level compatible Krzysztof Kozlowski
@ 2024-09-02 7:52 ` Krzysztof Kozlowski
2024-09-02 10:15 ` Peng Fan
` (2 more replies)
2024-09-02 10:13 ` [PATCH 1/2] arm64: dts: imx8mm-var-som: drop unused top-level compatible Peng Fan
` (2 subsequent siblings)
3 siblings, 3 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2024-09-02 7:52 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree,
linux-kernel, imx, linux-arm-kernel
Cc: Krzysztof Kozlowski
The Variscite VAR-SOM-MX8MM System-on-Module cannot be used alone
without motherboard, so drop the usage of its compatible alone.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/arm/fsl.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 1abdeb804468..e5f982fa750b 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -953,7 +953,6 @@ properties:
- toradex,verdin-imx8mm # Verdin iMX8M Mini Modules
- toradex,verdin-imx8mm-nonwifi # Verdin iMX8M Mini Modules without Wi-Fi / BT
- toradex,verdin-imx8mm-wifi # Verdin iMX8M Mini Wi-Fi / BT Modules
- - variscite,var-som-mx8mm # i.MX8MM Variscite VAR-SOM-MX8MM module
- prt,prt8mm # i.MX8MM Protonic PRT8MM Board
- const: fsl,imx8mm
--
2.43.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* RE: [PATCH 2/2] dt-bindings: arm: fsl: drop usage of VAR-SOM-MX8MM SoM compatible alone
2024-09-02 7:52 ` [PATCH 2/2] dt-bindings: arm: fsl: drop usage of VAR-SOM-MX8MM SoM compatible alone Krzysztof Kozlowski
@ 2024-09-02 10:15 ` Peng Fan
2024-09-02 10:20 ` Krzysztof Kozlowski
2024-09-02 12:26 ` Peng Fan
2024-09-03 15:14 ` Rob Herring (Arm)
2 siblings, 1 reply; 10+ messages in thread
From: Peng Fan @ 2024-09-02 10:15 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
> Subject: [PATCH 2/2] dt-bindings: arm: fsl: drop usage of VAR-SOM-
> MX8MM SoM compatible alone
>
> The Variscite VAR-SOM-MX8MM System-on-Module cannot be used
> alone without motherboard, so drop the usage of its compatible alone.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/arm/fsl.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml
> b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 1abdeb804468..e5f982fa750b 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -953,7 +953,6 @@ properties:
> - toradex,verdin-imx8mm # Verdin iMX8M Mini Modules
> - toradex,verdin-imx8mm-nonwifi # Verdin iMX8M Mini
> Modules without Wi-Fi / BT
> - toradex,verdin-imx8mm-wifi # Verdin iMX8M Mini Wi-Fi /
> BT Modules
> - - variscite,var-som-mx8mm # i.MX8MM Variscite VAR-SOM-
> MX8MM module
> - prt,prt8mm # i.MX8MM Protonic PRT8MM Board
> - const: fsl,imx8mm
>
Line 1072
"const: variscite,var-som-mx8mm" should this one also need removed?
Regards,
Peng.
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] dt-bindings: arm: fsl: drop usage of VAR-SOM-MX8MM SoM compatible alone
2024-09-02 10:15 ` Peng Fan
@ 2024-09-02 10:20 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2024-09-02 10:20 UTC (permalink / raw)
To: Peng Fan, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org
On 02/09/2024 12:15, Peng Fan wrote:
>> Subject: [PATCH 2/2] dt-bindings: arm: fsl: drop usage of VAR-SOM-
>> MX8MM SoM compatible alone
>>
>> The Variscite VAR-SOM-MX8MM System-on-Module cannot be used
>> alone without motherboard, so drop the usage of its compatible alone.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> Documentation/devicetree/bindings/arm/fsl.yaml | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml
>> b/Documentation/devicetree/bindings/arm/fsl.yaml
>> index 1abdeb804468..e5f982fa750b 100644
>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>> @@ -953,7 +953,6 @@ properties:
>> - toradex,verdin-imx8mm # Verdin iMX8M Mini Modules
>> - toradex,verdin-imx8mm-nonwifi # Verdin iMX8M Mini
>> Modules without Wi-Fi / BT
>> - toradex,verdin-imx8mm-wifi # Verdin iMX8M Mini Wi-Fi /
>> BT Modules
>> - - variscite,var-som-mx8mm # i.MX8MM Variscite VAR-SOM-
>> MX8MM module
>> - prt,prt8mm # i.MX8MM Protonic PRT8MM Board
>> - const: fsl,imx8mm
>>
>
> Line 1072
> "const: variscite,var-som-mx8mm" should this one also need removed?
Of course not! How is this related to patch description?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH 2/2] dt-bindings: arm: fsl: drop usage of VAR-SOM-MX8MM SoM compatible alone
2024-09-02 7:52 ` [PATCH 2/2] dt-bindings: arm: fsl: drop usage of VAR-SOM-MX8MM SoM compatible alone Krzysztof Kozlowski
2024-09-02 10:15 ` Peng Fan
@ 2024-09-02 12:26 ` Peng Fan
2024-09-03 15:14 ` Rob Herring (Arm)
2 siblings, 0 replies; 10+ messages in thread
From: Peng Fan @ 2024-09-02 12:26 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
> Subject: [PATCH 2/2] dt-bindings: arm: fsl: drop usage of VAR-SOM-
> MX8MM SoM compatible alone
>
> The Variscite VAR-SOM-MX8MM System-on-Module cannot be used
> alone without motherboard, so drop the usage of its compatible alone.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
I got a mistake in my previous comment, so
Reviewed-by: Peng Fan <peng.fan@nxp.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] dt-bindings: arm: fsl: drop usage of VAR-SOM-MX8MM SoM compatible alone
2024-09-02 7:52 ` [PATCH 2/2] dt-bindings: arm: fsl: drop usage of VAR-SOM-MX8MM SoM compatible alone Krzysztof Kozlowski
2024-09-02 10:15 ` Peng Fan
2024-09-02 12:26 ` Peng Fan
@ 2024-09-03 15:14 ` Rob Herring (Arm)
2 siblings, 0 replies; 10+ messages in thread
From: Rob Herring (Arm) @ 2024-09-03 15:14 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Shawn Guo, Krzysztof Kozlowski, linux-arm-kernel,
Pengutronix Kernel Team, Sascha Hauer, Conor Dooley,
Fabio Estevam, linux-kernel, devicetree, imx
On Mon, 02 Sep 2024 09:52:20 +0200, Krzysztof Kozlowski wrote:
> The Variscite VAR-SOM-MX8MM System-on-Module cannot be used alone
> without motherboard, so drop the usage of its compatible alone.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/arm/fsl.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH 1/2] arm64: dts: imx8mm-var-som: drop unused top-level compatible
2024-09-02 7:52 [PATCH 1/2] arm64: dts: imx8mm-var-som: drop unused top-level compatible Krzysztof Kozlowski
2024-09-02 7:52 ` [PATCH 2/2] dt-bindings: arm: fsl: drop usage of VAR-SOM-MX8MM SoM compatible alone Krzysztof Kozlowski
@ 2024-09-02 10:13 ` Peng Fan
2024-09-02 10:19 ` Krzysztof Kozlowski
2024-09-02 12:27 ` Peng Fan
2024-09-03 6:53 ` Shawn Guo
3 siblings, 1 reply; 10+ messages in thread
From: Peng Fan @ 2024-09-02 10:13 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
> Subject: [PATCH 1/2] arm64: dts: imx8mm-var-som: drop unused top-
> level compatible
>
> The Variscite VAR-SOM-MX8MM System-on-Module cannot be used
> alone without motherboard, so drop the top-level compatible field to
> avoid any false impression that such usage is possible.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
> index d7830df5b6f9..cdfacbc35db5 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
> @@ -8,7 +8,6 @@
>
> / {
> model = "Variscite VAR-SOM-MX8MM module";
> - compatible = "variscite,var-som-mx8mm", "fsl,imx8mm";
>
> chosen {
> stdout-path = &uart4;
> --
> 2.43.0
>
Should the " variscite,var-som-mx8mm " also removed from
imx8mm-var-som-symphony.dts?
Regards,
Peng.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 1/2] arm64: dts: imx8mm-var-som: drop unused top-level compatible
2024-09-02 10:13 ` [PATCH 1/2] arm64: dts: imx8mm-var-som: drop unused top-level compatible Peng Fan
@ 2024-09-02 10:19 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2024-09-02 10:19 UTC (permalink / raw)
To: Peng Fan, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org
On 02/09/2024 12:13, Peng Fan wrote:
>> Subject: [PATCH 1/2] arm64: dts: imx8mm-var-som: drop unused top-
>> level compatible
>>
>> The Variscite VAR-SOM-MX8MM System-on-Module cannot be used
>> alone without motherboard, so drop the top-level compatible field to
>> avoid any false impression that such usage is possible.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
>> b/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
>> index d7830df5b6f9..cdfacbc35db5 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
>> @@ -8,7 +8,6 @@
>>
>> / {
>> model = "Variscite VAR-SOM-MX8MM module";
>> - compatible = "variscite,var-som-mx8mm", "fsl,imx8mm";
>>
>> chosen {
>> stdout-path = &uart4;
>> --
>> 2.43.0
>>
>
> Should the " variscite,var-som-mx8mm " also removed from
> imx8mm-var-som-symphony.dts?
No, why?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH 1/2] arm64: dts: imx8mm-var-som: drop unused top-level compatible
2024-09-02 7:52 [PATCH 1/2] arm64: dts: imx8mm-var-som: drop unused top-level compatible Krzysztof Kozlowski
2024-09-02 7:52 ` [PATCH 2/2] dt-bindings: arm: fsl: drop usage of VAR-SOM-MX8MM SoM compatible alone Krzysztof Kozlowski
2024-09-02 10:13 ` [PATCH 1/2] arm64: dts: imx8mm-var-som: drop unused top-level compatible Peng Fan
@ 2024-09-02 12:27 ` Peng Fan
2024-09-03 6:53 ` Shawn Guo
3 siblings, 0 replies; 10+ messages in thread
From: Peng Fan @ 2024-09-02 12:27 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
> Subject: [PATCH 1/2] arm64: dts: imx8mm-var-som: drop unused top-
> level compatible
>
> The Variscite VAR-SOM-MX8MM System-on-Module cannot be used
> alone without motherboard, so drop the top-level compatible field to
> avoid any false impression that such usage is possible.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
I got a mistake in my previous comment, so
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Thanks,
Peng.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] arm64: dts: imx8mm-var-som: drop unused top-level compatible
2024-09-02 7:52 [PATCH 1/2] arm64: dts: imx8mm-var-som: drop unused top-level compatible Krzysztof Kozlowski
` (2 preceding siblings ...)
2024-09-02 12:27 ` Peng Fan
@ 2024-09-03 6:53 ` Shawn Guo
3 siblings, 0 replies; 10+ messages in thread
From: Shawn Guo @ 2024-09-03 6:53 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree,
linux-kernel, imx, linux-arm-kernel
On Mon, Sep 02, 2024 at 09:52:19AM +0200, Krzysztof Kozlowski wrote:
> The Variscite VAR-SOM-MX8MM System-on-Module cannot be used alone
> without motherboard, so drop the top-level compatible field to avoid any
> false impression that such usage is possible.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Applied both, thanks!
^ permalink raw reply [flat|nested] 10+ messages in thread