From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00C7ECD379F for ; Tue, 3 Sep 2024 16:39:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+dHIfzaeLWIWA+kaGYIDBPcUI1EDfni54Q8J+imu4wY=; b=omj2uSTJH65msAcjLtdDEDEEeH UZ81xHjupoEZZIMXeKF2xlIRJoQ84DX9dgzRCqTFfuY+KjqM3mw62EvQSOUS3bJ8+1/5e00e7GNI9 nb1U0bmxhQRIIpiRF9NQwxE2NXP22dpsH+2c51dKYRxVrscVQ4xbulHXsBIZEnTytmqEe68NIj78M c26YpGTBYkzzozlZpKkF0c9pqle5b2JPRzUj49vrTI4gTPln89MB/na+hIlC1EXPP0jA4e1RWaCKH Mti+J4oZmUGc1cf936dmeiIK8YpBLY5CyBA+jcUigra71tIwlSjSDOGCXxTGDShDPwbe8kdE5BeLA cNJKOYDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slWYy-00000001A02-15qA; Tue, 03 Sep 2024 16:39:28 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slWY1-000000019ig-3CC6; Tue, 03 Sep 2024 16:38:31 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 3094DA4374F; Tue, 3 Sep 2024 16:38:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 697ECC4CEC4; Tue, 3 Sep 2024 16:38:22 +0000 (UTC) Date: Tue, 3 Sep 2024 17:38:20 +0100 From: Catalin Marinas To: Mark Brown Cc: Will Deacon , Jonathan Corbet , Andrew Morton , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , Szabolcs Nagy , Kees Cook , "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Florian Weimer , Christian Brauner , Thiago Jung Bauermann , Ross Burton , Yury Khrustalev , Wilco Dijkstra , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v12 26/39] arm64/ptrace: Expose GCS via ptrace and core files Message-ID: References: <20240829-arm64-gcs-v12-0-42fec947436a@kernel.org> <20240829-arm64-gcs-v12-26-42fec947436a@kernel.org> <3f190f54-477e-48dd-8a57-8d61ea20413b@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f190f54-477e-48dd-8a57-8d61ea20413b@sirena.org.uk> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240903_093829_885098_DDD53D94 X-CRM114-Status: GOOD ( 13.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 02, 2024 at 07:58:28PM +0100, Mark Brown wrote: > On Mon, Sep 02, 2024 at 07:56:32PM +0100, Catalin Marinas wrote: > > On Thu, Aug 29, 2024 at 12:27:42AM +0100, Mark Brown wrote: > > > > +static int gcs_get(struct task_struct *target, > > > + const struct user_regset *regset, > > > + struct membuf to) > > > > + if (target == current) > > > + gcs_preserve_current_state(); > > > What's the use-case where target == current and do we need something > > similar for gcs_set()? > > IIRC core file generation so no. Ah, true. Makes sense. -- Catalin