From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C876DCD343E for ; Tue, 3 Sep 2024 14:57:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:Date:From:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DIv1iCvMP6bRoC9RIud+CJguG+zl0N1bX8dXz6wFLmQ=; b=QLxZOinLzDaKKsF9avO1wVCtQp SfyxYcAadkk4WlDXtqBId6BstHwt0v4CnLjlC446TZpOfXbu1bOVHtc8Bfi3c6gal2ZtJX+VjBWCA AqtZNjAogQf+EdmPMYJ8dEiHZi8htSmlgqx8AKTh2V4sZd+4qLntYRi/ntvpDROU5h6LSSFyEuX7m 9kPZSsbydONBgi0czYkkfvBDjsw6/8gbTrROH8FkQwcUQTqJisGjKPf+jV7ytyCL4c5w/8lIO+J40 +xwCUj47D+QoMzQa8DSoLetzPhuVwDJD/AHMMUBuX2V+WVXcn8qgEmEXxANEUMyFjj3cOI95jWVav g7bg68hw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slUyV-00000000iAy-1YWy; Tue, 03 Sep 2024 14:57:43 +0000 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slUxY-00000000hsb-0U1C for linux-arm-kernel@lists.infradead.org; Tue, 03 Sep 2024 14:56:46 +0000 Received: by mail-lj1-x241.google.com with SMTP id 38308e7fff4ca-2f4f8742138so61797081fa.0 for ; Tue, 03 Sep 2024 07:56:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1725375402; x=1725980202; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=DIv1iCvMP6bRoC9RIud+CJguG+zl0N1bX8dXz6wFLmQ=; b=eDfYTMtsUOJOvfg5hbu43i6qN3iXuCpLi7ll0jNvL03WSRTlESqHLXQ+JhBlO5tnWK YXWZqtKWmXOqF1l32Wm+XV6auEc0g+g18bdcPmlCk9pfTwqmgdJaQMYkisFx6EXJR+Xj kp+B9e2ZgZTtm6yaKRg3njfNLxfylF2A4jdg0r+rw4HzG6hoYB9h9lI8ciT40bQTkVge EPMk3p3ByyAN3U5O2BbAjbfF0NfTard9CK3gmbS/gEfpxl31+i3XLKgYCZgjYxBwhCqA 5tD0wfbrMKUD0ZBFbSJraF6zOzgsrabFGZ9xFxbqkCO2vnCfjXoYZXaRIPPTahl5zowE 1lhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725375402; x=1725980202; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DIv1iCvMP6bRoC9RIud+CJguG+zl0N1bX8dXz6wFLmQ=; b=cOStsaPVzQsXhq0yXb7YrsDayBSHKbo0Hnuibhy8p5lA7K5y5vJLrj4hT7sM8I0T2I dx2CNUN/kCeVhuiAbLZw4d5o3clW86IF+zk2r6vBy9GzTUtw9mR2Vb32BPPcOxSZrBKZ roM38Hy9viuUAb0cO75xUhb/lKjooj8zSi7Z8NWBC/iFsBy3T7L50RTYgasF6fl2v1Xc c9e/zNzrmpFNWMbX9uDolcCrL0v9jS8rOvfGADquStgWEwIjddeLWwHKdBRRfLcAoe7b G8KtP1PmW4wb1MSzA1165s2TSJu3EQrVZ1G9EZ9RrOX2O2nw0v8W3X4Y6MMc03itlDAk u2xA== X-Forwarded-Encrypted: i=1; AJvYcCXsRHu05e6GnAZDr0bMbY93f5Rc2rAeLpQ7xMSE87kvYNjvieOwOry6e+zFbF6aTkMQ6q0amybS6uhOL/pfMDC2@lists.infradead.org X-Gm-Message-State: AOJu0YxGJ2G2d2nBLBWi1cakAyOUvNJegNxXfli5dLOeNQuYOqPXv+hL 4jgYRdsCOp97uVuIO4ejVjlTr6BoVxmSo3d67dClh9lCsShD2MpumKzqUYZIUuE= X-Google-Smtp-Source: AGHT+IGPXzXKjSyzj6ohNmy2x1Ly5xLLwbpSN9O7C4k6PqMn2bhMNSeS1m3Dv1qGKiKQSC913q2XHw== X-Received: by 2002:a2e:4e01:0:b0:2f3:b76e:4983 with SMTP id 38308e7fff4ca-2f64d4aa546mr6486601fa.22.1725375401093; Tue, 03 Sep 2024 07:56:41 -0700 (PDT) Received: from localhost (host-80-182-198-72.retail.telecomitalia.it. [80.182.198.72]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c226c6a29bsm6517320a12.17.2024.09.03.07.56.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2024 07:56:40 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Tue, 3 Sep 2024 16:56:48 +0200 To: Andrew Lunn Subject: Re: [PATCH 08/11] misc: rp1: RaspberryPi RP1 misc driver Message-ID: References: <5954e4dccc0e158cf434d2c281ad57120538409b.1724159867.git.andrea.porta@suse.com> <26efbff0-ba1a-4e9a-bc5e-4fd53ac0ed99@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26efbff0-ba1a-4e9a-bc5e-4fd53ac0ed99@lunn.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240903_075644_164130_1E80DC81 X-CRM114-Status: GOOD ( 32.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Michael Turquette , Claudiu Beznea , Eric Dumazet , Dragan Cvetic , Will Deacon , linux-clk@vger.kernel.org, linux-arch@vger.kernel.org, Rob Herring , Florian Fainelli , Lee Jones , Krzysztof Kozlowski , Saravana Kannan , Broadcom internal kernel review list , linux-pci@vger.kernel.org, Jakub Kicinski , Paolo Abeni , Linus Walleij , devicetree@vger.kernel.org, Conor Dooley , Arnd Bergmann , linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Bjorn Helgaas , Andrea della Porta , linux-arm-kernel@lists.infradead.org, Derek Kiernan , Stephen Boyd , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Stefan Wahren , netdev@vger.kernel.org, Krzysztof Kozlowski , "David S. Miller" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrew, On 16:21 Fri 30 Aug , Andrew Lunn wrote: > On Fri, Aug 30, 2024 at 03:49:04PM +0200, Andrea della Porta wrote: > > Hi Krzysztof, > > > > On 10:38 Wed 21 Aug , Krzysztof Kozlowski wrote: > > > On Tue, Aug 20, 2024 at 04:36:10PM +0200, Andrea della Porta wrote: > > > > The RaspberryPi RP1 is ia PCI multi function device containing > > > > peripherals ranging from Ethernet to USB controller, I2C, SPI > > > > and others. > > > > Implement a bare minimum driver to operate the RP1, leveraging > > > > actual OF based driver implementations for the on-borad peripherals > > > > by loading a devicetree overlay during driver probe. > > > > The peripherals are accessed by mapping MMIO registers starting > > > > from PCI BAR1 region. > > > > As a minimum driver, the peripherals will not be added to the > > > > dtbo here, but in following patches. > > > > > > > > Link: https://datasheets.raspberrypi.com/rp1/rp1-peripherals.pdf > > > > Signed-off-by: Andrea della Porta > > > > --- > > > > MAINTAINERS | 2 + > > > > arch/arm64/boot/dts/broadcom/rp1.dtso | 152 ++++++++++++ > > > > > > Do not mix DTS with drivers. > > > > > > These MUST be separate. > > > > Separating the dtso from the driver in two different patches would mean > > that the dtso patch would be ordered before the driver one. This is because > > the driver embeds the dtbo binary blob inside itself, at build time. So > > in order to build the driver, the dtso needs to be there also. This is not > > the standard approach used with 'normal' dtb/dtbo, where the dtb patch is > > ordered last wrt the driver it refers to. > > Are you sure you want to proceed in this way? > > It is more about they are logically separate things. The .dtb/dtbo > describes the hardware. It should be possible to review that as a > standalone thing. The code them implements the binding. It makes no > sense to review the code until the binding is correct, because changes > to the binding will need changes to the code. Hence, we want the > binding first, then the code which implements it. Ack. Cheers, Andrea > > Andrew