From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 483DDCA0ED3 for ; Wed, 4 Sep 2024 07:01:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zpRDeQGb2VSe/NjP71YY09+PtxsiDxQ7Ns4fcS2jwNk=; b=37VDa6ba477Cel0Z1M+74Ty1QL RzXQLJRxfIZFXIpJs1TVabAHFJwbkKhSQ5Qy6VQxbJSQWfwUzK65t1TkYo56mPtYl22awU8VZypLo jo6j2Uw9PUP+6EqVDOGwmmpiwBTwBGY0EQMv8B7ASE46aHu2Uu+aIrlFNdQw/lMtox7x5Jon/iz9X YaOJxRuCS3QLe0gdb7FC5UhJuFbJNAg5OqhAnoq4M7RDJHnOgg4vWYr5aIvcn9m3Nj7zy1PHZxar0 oV1PtbYPnMsgtDTdQNOatSgERi2yUELeBtzG+Eq7KoVT4Kn23YUWC/VQpxDwCMZE62Bxi/DwJKatd 3xLJrOeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slk0y-000000036R7-15Dz; Wed, 04 Sep 2024 07:01:16 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sljzz-0000000366f-41hC for linux-arm-kernel@lists.infradead.org; Wed, 04 Sep 2024 07:00:17 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 624945C5734; Wed, 4 Sep 2024 07:00:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D98DC4CEC3; Wed, 4 Sep 2024 07:00:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725433214; bh=7MUwc0Qz0mHMQ92cWtSf9OiJINGcpduG0xrHBToFdFg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PlWhKMY+y29pV2JFKEgiVv1fRmL7I6BIjNLFtnSo2ClJ0W2PC5eXWq+p5L7yDGZIT OhDNggb/1Q05WL09OIpO1g7ARtP76HSjqwNDnUxCFgPmpqMFS4fzFExYxca7WjuNgX UH3925GZYmOyM1IvdnCT5ckT/X1CHXWU69nRBVoqpIanBc40kV0n/Th6+4Ig7chcX0 qvr0//Ecmn7ubYaoH9FljyNg65Lv2egcv3EyOXMVlRUtZS3dbD/KEc3BPKJsdm0vD2 VyPEqLFLcOd9ZMGQwZOvZjty2l3YVbCWqtGoIG6k6/3yTJkqGL2TbKNm4TBWrkcMLC FEUERxPzRF5KQ== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1slk0F-0000000012U-0M0T; Wed, 04 Sep 2024 09:00:31 +0200 Date: Wed, 4 Sep 2024 09:00:31 +0200 From: Johan Hovold To: Sibi Sankar Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, konradybcio@kernel.org Subject: Re: [PATCH V2 1/2] firmware: arm_scmi: Ensure that the message-id supports fastchannel Message-ID: References: <20240904031324.2901114-1-quic_sibis@quicinc.com> <20240904031324.2901114-2-quic_sibis@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240904031324.2901114-2-quic_sibis@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_000016_087137_EB1F1DD9 X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 04, 2024 at 08:43:23AM +0530, Sibi Sankar wrote: > Currently the perf and powercap protocol relies on the protocol domain > attributes, which just ensures that one fastchannel per domain, before > instantiating fastchannels for all possible message-ids. Fix this by > ensuring that each message-id supports fastchannel before initialization. Please include the warnings that I reported seeing on x1e80100 and that this patch suppresses to the commit message: arm-scmi firmware:scmi: Failed to get FC for protocol 13 [MSG_ID:6 / RES_ID:0] - ret:-95. Using regular messaging. arm-scmi firmware:scmi: Failed to get FC for protocol 13 [MSG_ID:6 / RES_ID:1] - ret:-95. Using regular messaging. arm-scmi firmware:scmi: Failed to get FC for protocol 13 [MSG_ID:6 / RES_ID:2] - ret:-95. Using regular messaging. > Fixes: 6f9ea4dabd2d ("firmware: arm_scmi: Generalize the fast channel support") And add: Reported-by: Johan Hovold Link: https://lore.kernel.org/lkml/ZoQjAWse2YxwyRJv@hovoldconsulting.com/ (or use Closes: if you prefer). > Signed-off-by: Sibi Sankar > --- > > v1: > * add missing MSG_SUPPORTS_FASTCHANNEL definition. Unfortunately, this patch breaks resume from suspend on the x1e80100 crd: [ 26.919676] CPU4: Booted secondary processor 0x0000010000 [0x511f0011] [ 26.960607] arm-scmi firmware:scmi: timed out in resp(caller: do_xfer+0x164/0x568) [ 26.987142] cpufreq: cpufreq_online: ->get() failed and then the machine hangs (mostly, I saw an nvme timeout message after a while). Make sure you test suspend as well as some of the warnings I reported only show up during suspend. Johan