From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D2BDCD37AE for ; Wed, 4 Sep 2024 07:10:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wyV0UaAFncPIInlinvyosMYEs9Q6TiybembYJVv7sFw=; b=ML0NxmaLhggwrKqmeLGuBWg/iW GeyrpET0fcy4nL1a2wI88LsPkTkutMD6okZ+viK4dTdaWRRM/dCHdREFGfn1pz+j/ONECN0WhM2gX +SmyJm6eyqF+zsoEeFb2ponwZq5pTtCqBhp4Fk6aZO16546YUdGYkT8gBAv0ouOveTV2bIOPVwmd0 AFgeusqjfMWrJwqKhY9l+TjCUe7XKxgxTb4wYCODnFkOzW0hsNOEFaAlm8eyOWzpdCYSAP1nNY5+e 4bWaQQcB/TCLMkyTiMMADgyokTuTWJaeI/nnOehU33kkXC2BmJpwgD2Q9ROZK0gSSszsUC/zQu/rr g/YfW/1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slkA3-000000037yk-3UCD; Wed, 04 Sep 2024 07:10:39 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slk96-000000037jP-2zYR for linux-arm-kernel@lists.infradead.org; Wed, 04 Sep 2024 07:09:42 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id A1B24A416CB; Wed, 4 Sep 2024 07:09:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D336C4CEC2; Wed, 4 Sep 2024 07:09:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725433779; bh=U7ShB99LMxLCv80JBZpXfOThgO3T2QrCzDNel6QhBhA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DO6RB7tyywf0ai1BqJXYXdF+mvcKUnltH5kHrqZzHq06+ZOHH5TY4H7VVWAL3PxVn IJEVMnMu1wpEVi/XhVUl7rvGoIKh65VSNGX3wRCqotMpE+8ZR/xHDbq12Jyj8hV/Na Hp2fUadwzUf8+k2d5XAaMvFFHVlyojlbdhQEjRLe2JNmbfqWOgwV/cpijKLYZ5cX5c ItwWToIPYDOssdqZq3nd5gI5MbhE23LtmP4d5oQ7+XmC0R4OiC0sWFygAvJGx5hRvk 2Mfzj0M66qGnmygz0mhv7hGRywB4ZYPek9bT97b79V+MMrOi81Asl5QvNtaVcx6m4g TdJZZC5TVIHdA== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1slk9L-0000000019G-2PP2; Wed, 04 Sep 2024 09:09:56 +0200 Date: Wed, 4 Sep 2024 09:09:55 +0200 From: Johan Hovold To: Sibi Sankar Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, konradybcio@kernel.org Subject: Re: [PATCH V2 2/2] firmware: arm_scmi: Skip adding bad duplicates Message-ID: References: <20240904031324.2901114-1-quic_sibis@quicinc.com> <20240904031324.2901114-3-quic_sibis@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240904031324.2901114-3-quic_sibis@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_000940_900344_26C44426 X-CRM114-Status: GOOD ( 12.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 04, 2024 at 08:43:24AM +0530, Sibi Sankar wrote: > Ensure that the bad duplicates reported by the platform firmware doesn't > get added to the opp-tables. Please expand on why this is an issue on Qualcomm platforms, these entries aren't just "bad duplicates" if IIUC. Also here, please add (examples of) the warnings I reported. During boot of the x1e80100 crd, I see: [ 8.992956] cpu cpu4: _opp_is_duplicate: duplicate OPPs detected. Existing: freq: 3417600000, volt: 0, enabled: 1. New: freq: 3417600000, volt: 0, enabled: 1 [ 9.021940] cpu cpu4: _opp_is_duplicate: duplicate OPPs detected. Existing: freq: 3417600000, volt: 0, enabled: 1. New: freq: 3417600000, volt: 0, enabled: 1 [ 9.036171] cpu cpu8: _opp_is_duplicate: duplicate OPPs detected. Existing: freq: 3417600000, volt: 0, enabled: 1. New: freq: 3417600000, volt: 0, enabled: 1 [ 9.036177] cpu cpu8: _opp_is_duplicate: duplicate OPPs detected. Existing: freq: 3417600000, volt: 0, enabled: 1. New: freq: 3417600000, volt: 0, enabled: 1 and during resume: [ 85.286615] cpu cpu4: _opp_is_duplicate: duplicate OPPs detected. Existing: freq: 3417600000, volt: 0, enabled: 1. N ew: freq: 3417600000, volt: 0, enabled: 1 [ 85.319849] cpu cpu4: _opp_is_duplicate: duplicate OPPs detected. Existing: freq: 3417600000, volt: 0, enabled: 1. N ew: freq: 3417600000, volt: 0, enabled: 1 [ 85.334686] debugfs: File 'cpu5' in directory 'opp' already present! [ 85.341399] debugfs: File 'cpu6' in directory 'opp' already present! [ 85.348016] debugfs: File 'cpu7' in directory 'opp' already present! [ 85.443093] cpu cpu8: _opp_is_duplicate: duplicate OPPs detected. Existing: freq: 3417600000, volt: 0, enabled: 1. N ew: freq: 3417600000, volt: 0, enabled: 1 [ 85.476595] cpu cpu8: _opp_is_duplicate: duplicate OPPs detected. Existing: freq: 3417600000, volt: 0, enabled: 1. N ew: freq: 3417600000, volt: 0, enabled: 1 [ 85.491645] debugfs: File 'cpu9' in directory 'opp' already present! [ 85.498409] debugfs: File 'cpu10' in directory 'opp' already present! [ 85.505187] debugfs: File 'cpu11' in directory 'opp' already present! Please also add: Reported-by: Johan Hovold Link: https://lore.kernel.org/lkml/ZoQjAWse2YxwyRJv@hovoldconsulting.com/ > Signed-off-by: Sibi Sankar But with this patch applied, instead of the above warnings I now get two *errors* at boot: [ 8.952173] cpu cpu4: EM: non-increasing freq: 0 [ 8.979460] cpu cpu8: EM: non-increasing freq: 0 Can you do something about that as well? At least make sure to highlight this in the commit message as this is information that is needed to be able to evaluate the patch. Johan